+global\ECPayLogistics::CreateFamilyB2CReturnOrder()

Complexity

Conditions	13
Paths	31

Size

Total Lines	84
Code Lines	56

Duplication

Lines	15
Ratio	17.86 %

Importance

Changes

0

<?php
        public function CreateFamilyB2CReturnOrder()
        {

            // 參數初始化
            $ParamList = [
                'MerchantID' => '',
                'AllPayLogisticsID' => '',
                'ServerReplyURL' => '',
                'GoodsName' => '',
                'GoodsAmount' => 0,
                'SenderName' => '',
                'SenderPhone' => '',
                'Remark' => '',
                'Quantity' => '',
                'Cost' => '',
                'PlatformID' => '',
            ];
            $this->PostParams = $this->GetPostParams($this->Send, $ParamList);
            $this->PostParams['CollectionAmount'] = 0;
            $this->PostParams['ServiceType'] = 4; // 退貨不付款

            // 參數檢查
            $this->ValidateHashKey();
            $this->ValidateHashIV();
            $this->ValidateID('MerchantID', $this->PostParams['MerchantID'], 10);
            $this->ServiceURL = $this->GetURL('FAMILY_RETURN_ORDER');
            $this->ValidateID('AllPayLogisticsID', $this->PostParams['AllPayLogisticsID'], 20, true);
            $this->ValidateURL('ServerReplyURL', $this->PostParams['ServerReplyURL']);
            $this->ValidateString('GoodsName', $this->PostParams['GoodsName'], 50, true);
            $this->ValidateAmount('GoodsAmount', $this->PostParams['GoodsAmount']);
            $this->ValidateString('SenderName', $this->PostParams['SenderName'], 50);
            $this->ValidatePhoneNumber('SenderPhone', $this->PostParams['SenderPhone'], true);
            $this->ValidateString('Remark', $this->PostParams['Remark'], 20, true);
            $this->ValidateString('Quantity', $this->PostParams['Quantity'], 50, true);
            $this->ValidateString('Cost', $this->PostParams['Cost'], 50, true);
            $this->ValidateID('PlatformID', $this->PostParams['PlatformID'], 10, true);

            // 檢查商品名稱, 數量 與 成本
            $GoodsNameNumber = count(explode('#', $this->PostParams['GoodsName']));
            $QuantityNumber = count(explode('#', $this->PostParams['Quantity']));
            $CostNumber = count(explode('#', $this->PostParams['Cost']));

            if (! empty($this->PostParams['GoodsName']) and ! empty($this->PostParams['Quantity'])) {

This code seems to be duplicated across your project.

Using logical operators such as and instead of && is generally not recommended.

                if ($GoodsNameNumber != $QuantityNumber) {
                    throw new Exception('GoodsName number and Quantity number do not match.');
                }
            }

            if (! empty($this->PostParams['Quantity']) and ! empty($this->PostParams['Cost'])) {

This code seems to be duplicated across your project.

Using logical operators such as and instead of && is generally not recommended.

                if ($GoodsNameNumber != $CostNumber) {
                    throw new Exception('Quantity number and Cost number do not match.');
                }
            }

            if (! empty($this->PostParams['Cost']) and ! empty($this->PostParams['GoodsName'])) {

This code seems to be duplicated across your project.

Using logical operators such as and instead of && is generally not recommended.

                if ($GoodsNameNumber != $CostNumber) {
                    throw new Exception('Cost number and GoodsName number do not match.');
                }
            }

            $MinAmount = 1; // 金額下限
            $MaxAmount = 20000; // 金額上限
            if ($this->PostParams['GoodsAmount'] < $MinAmount or $this->PostParams['GoodsAmount'] > $MaxAmount) {

Using logical operators such as or instead of || is generally not recommended.

                throw new Exception('Invalid GoodsAmount.');
            }

            // 產生 CheckMacValue
            $this->PostParams['CheckMacValue'] = ECPay_CheckMacValue::generate($this->PostParams, $this->HashKey, $this->HashIV);

            // 解析回傳結果
            // 正確：RtnMerchantTradeNo | RtnOrderNo
            // 錯誤：|ErrorMessage
            $Feedback = ECPay_IO::ServerPost($this->PostParams, $this->ServiceURL);
            $Pieces = explode('|', $Feedback);
            $Result = ['RtnMerchantTradeNo' => '', 'RtnOrderNo' => ''];
            if (empty($Pieces[0])) {
                $Result = ['ErrorMessage' => $Pieces[1]];
            } else {
                $Result['RtnMerchantTradeNo'] = $Pieces[0];
                $Result['RtnOrderNo'] = $Pieces[1];
            }

            return $Result;
        }