CaptureAction   A
last analyzed

Complexity

Total Complexity 7

Size/Duplication

Total Lines 53
Duplicated Lines 11.32 %

Coupling/Cohesion

Components 1
Dependencies 12

Test Coverage

Coverage 100%

Importance

Changes 0
Metric Value
wmc 7
lcom 1
cbo 12
dl 6
loc 53
ccs 27
cts 27
cp 1
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
B execute() 6 32 5
A supports() 0 6 2

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace PayumTW\Ecpay\Action;
4
5
use Payum\Core\Request\Capture;
6
use Payum\Core\GatewayAwareTrait;
7
use Payum\Core\GatewayAwareInterface;
8
use Payum\Core\Action\ActionInterface;
9
use Payum\Core\Bridge\Spl\ArrayObject;
10
use Payum\Core\Request\GetHttpRequest;
11
use PayumTW\Ecpay\Action\Api\BaseApiAwareAction;
12
use PayumTW\Ecpay\Request\Api\CreateTransaction;
13
use Payum\Core\Exception\RequestNotSupportedException;
14
use Payum\Core\Security\GenericTokenFactoryAwareTrait;
15
use Payum\Core\Security\GenericTokenFactoryAwareInterface;
16
17
class CaptureAction extends BaseApiAwareAction implements ActionInterface, GatewayAwareInterface, GenericTokenFactoryAwareInterface
18
{
19
    use GatewayAwareTrait;
20
    use GenericTokenFactoryAwareTrait;
21
22
    /**
23
     * {@inheritdoc}
24
     *
25
     * @param Capture $request
26
     */
27 2
    public function execute($request)
28
    {
29 2
        RequestNotSupportedException::assertSupports($this, $request);
30 2
        $details = ArrayObject::ensureArrayObject($request->getModel());
31
32 2
        $httpRequest = new GetHttpRequest();
33 2
        $this->gateway->execute($httpRequest);
34
35 2
        if (isset($httpRequest->request['RtnCode']) === true) {
36 1
            if ($this->api->verifyHash($httpRequest->request) === false) {
37 1
                $httpRequest->request['RtnCode'] = '10400002';
38 1
            }
39 1
            $details->replace($httpRequest->request);
40
41 1
            return;
42
        }
43
44 1
        $token = $request->getToken();
45 1
        $targetUrl = $token->getTargetUrl();
46
47 1
        if (empty($details['OrderResultURL']) === true) {
48 1
            $details['OrderResultURL'] = $targetUrl;
49 1
        }
50
51 1 View Code Duplication
        if (empty($details['ReturnURL']) === true) {
52 1
            $notifyToken = $this->tokenFactory->createNotifyToken(
53 1
                $token->getGatewayName(), $token->getDetails()
54 1
            );
55 1
            $details['ReturnURL'] = $notifyToken->getTargetUrl();
56 1
        }
57 1
        $this->gateway->execute(new CreateTransaction($details));
58 1
    }
59
60
    /**
61
     * {@inheritdoc}
62
     */
63 2
    public function supports($request)
64
    {
65
        return
66 2
            $request instanceof Capture &&
67 2
            $request->getModel() instanceof \ArrayAccess;
68
    }
69
}
70