PayumTW\Collect\Api

Complexity

Total Complexity

10

Size/Duplication

Total Lines	125
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	6

Test Coverage

Coverage

96.97%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
	getApiEndpoint()	0	1	?
	createTransaction()	0	1	?
A	__construct()	0	7	2
B	doRequest()	0	19	5
A	verifyHash()	0	18	2
A	calculateHash()	0	6	1

<?php

namespace PayumTW\Collect;

use Http\Message\MessageFactory;
use Payum\Core\HttpClientInterface;
use Payum\Core\Exception\Http\HttpException;

abstract class Api
{
    /**
     * TIMEZONE.
     *
     * @var string
     */
    const TIMEZONE = 'Asia/Taipei';

    /**
     * @var \Payum\Core\HttpClientInterface
     */
    protected $client;

    /**
     * @var \Http\Message\MessageFactory
     */
    protected $messageFactory;

    /**
     * @var array
     */
    protected $options = [];

    /**
     * $encrypter.
     *
     * @var Encrypter
     */
    protected $encrypter;

    /**
     * @param array $options
     * @param \Payum\Core\HttpClientInterface $client
     * @param \Http\Message\MessageFactory $messageFactory
     * @param Encrypter $encrypter
     *
     * @throws \Payum\Core\Exception\InvalidArgumentException if an option is invalid
     */
    public function __construct(array $options, HttpClientInterface $client, MessageFactory $messageFactory, Encrypter $encrypter = null)
    {
        $this->options = $options;
        $this->client = $client;
        $this->messageFactory = $messageFactory;
        $this->encrypter = $encrypter ?: new Encrypter();
    }

    /**
     * @param string $method
     * @param array $params
     * @param string $type
     * @param bool $isJson
     * @return string
     */
    protected function doRequest($method, $params, $type = 'cancel', $isJson = true)
    {
        $request = $this->messageFactory->createRequest($method, $this->getApiEndpoint($type), [
            'Content-Type' => 'application/x-www-form-urlencoded',
        ], is_array($params) === true ? http_build_query($params) : $params);

        $response = $this->client->send($request);

        $statusCode = $response->getStatusCode();
        if (false == ($statusCode >= 200 && $statusCode < 300)) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            throw HttpException::factory($request, $response);
        }

        $contents = $response->getBody()->getContents();

        return $isJson === true
            ? json_decode($contents, true)
            : $contents;
    }

    /**
     * @return string
     */
    abstract public function getApiEndpoint($type = 'capture');

    /**
     * createTransaction.
     *
     * @param array $params
     * @return array
     */
    abstract public function createTransaction(array $params);

    /**
     * Verify if the hash of the given parameter is correct.
     *
     * @param array $params
     * @return bool
     */
    public function verifyHash(array $params)
    {
        $filters = [
            'ok' => ['order_amount', 'send_time', 'ret', 'acquire_time', 'auth_code', 'card_no', 'notify_time', 'cust_order_no'],
            'fail' => ['order_amount', 'send_time', 'ret', 'notify_time', 'cust_order_no'],
            'status' => ['api_id', 'trans_id', 'amount', 'status', 'nonce'],
        ];

        if (isset($params['status']) === true) {
            $hashKey = 'checksum';
            $filterKeys = $filters['status'];
        } else {
            $hashKey = 'chk';
            $filterKeys = $filters[strtolower($params['ret'])];
        }

        return $params[$hashKey] === $this->calculateHash($params, $filterKeys);
    }

    /**
     * calculateHash.
     *
     * @param array $params
     * @return string
     */
    protected function calculateHash($params, $filterKeys = [])
    {
        return $this->encrypter
            ->setKey($this->options['hash_base'])
            ->encrypt($params, $filterKeys);
    }
}