Handler::shouldRenderException() - Code Metrics - Inspection of "refactoring" - recca0120/laravel-tracy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1aa61a...c182a1 )

by recca

created 2017-07-19 06:16 UTC

Handler::shouldRenderException() B

↳ Parent: Project

Complexity

Conditions	6
Paths	5

Size

Total Lines	20
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	6
eloc	10
c	1
b	0
f	0
nc	5
nop	1
dl	0
loc	20
ccs	10
cts	10
cp	1
crap	6
rs	8.8571

<?php

namespace Recca0120\LaravelTracy\Exceptions;

use Exception;
use Illuminate\Http\Response;
use Illuminate\Contracts\View\View;
use Recca0120\LaravelTracy\DebuggerManager;
use Illuminate\Contracts\Debug\ExceptionHandler;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\RedirectResponse;

class Handler implements ExceptionHandler
{
    /**
     * app exception handler.
     *
     * @var \Illuminate\Contracts\Debug\ExceptionHandler
     */
    protected $exceptionHandler;

    /**
     * $debuggerManager.
     *
     * @var \Recca0120\LaravelTracy\DebuggerManager
     */
    protected $debuggerManager;

    /**
     * __construct.
     *
     * @param \Illuminate\Contracts\Debug\ExceptionHandler $exceptionHandler
     * @param \Recca0120\LaravelTracy\DebuggerManager $debuggerManager
     */
    public function __construct(ExceptionHandler $exceptionHandler, DebuggerManager $debuggerManager)
    {
        $this->exceptionHandler = $exceptionHandler;
        $this->debuggerManager = $debuggerManager;
    }

    /**
     * Report or log an exception.
     *
     * @param \Exception $e
     */
    public function report(Exception $e)
    {
        $this->exceptionHandler->report($e);
    }

    /**
     * Render an exception into an HTTP response.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Exception $e
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function render($request, Exception $e)
    {
        $response = $this->exceptionHandler->render($request, $e);

        if ($this->shouldRenderException($response) === true) {
            return $response;
        }

        $response->setContent(
            $this->debuggerManager->exceptionHandler($e)
        );

        return $response;
    }

    /**
     * Render an exception to the console.
     *
     * @param \Symfony\Component\Console\Output\OutputInterface $output
     * @param \Exception $e
     */
    public function renderForConsole($output, Exception $e)
    {
        $this->exceptionHandler->renderForConsole($output, $e);
    }

    /**
     * shouldRenderException.
     *
     * @param \Illuminate\Http\Response|\Symfony\Component\HttpFoundation\Response $response
     * @return bool
     */
    protected function shouldRenderException($response)
    {
        if ($response instanceof RedirectResponse) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            return true;
        }

        if ($response instanceof JsonResponse) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            return true;
        }

        if ($response->getContent() instanceof View) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            return true;
        }

        if ($response instanceof Response && $response->getOriginalContent() instanceof View) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            return true;
        }

        return false;
    }
}


1		<?php
2
3		namespace Recca0120\LaravelTracy\Exceptions;
4
5		use Exception;
6		use Illuminate\Http\Response;
7		use Illuminate\Contracts\View\View;
8		use Recca0120\LaravelTracy\DebuggerManager;
9		use Illuminate\Contracts\Debug\ExceptionHandler;
10		use Symfony\Component\HttpFoundation\JsonResponse;
11		use Symfony\Component\HttpFoundation\RedirectResponse;
12
13		class Handler implements ExceptionHandler
14		{
15		/**
16		* app exception handler.
17		*
18		* @var \Illuminate\Contracts\Debug\ExceptionHandler
19		*/
20		protected $exceptionHandler;
21
22		/**
23		* $debuggerManager.
24		*
25		* @var \Recca0120\LaravelTracy\DebuggerManager
26		*/
27		protected $debuggerManager;
28
29		/**
30		* __construct.
31		*
32		* @param \Illuminate\Contracts\Debug\ExceptionHandler $exceptionHandler
33		* @param \Recca0120\LaravelTracy\DebuggerManager $debuggerManager
34		*/
35	11	public function __construct(ExceptionHandler $exceptionHandler, DebuggerManager $debuggerManager)
36		{
37	11	$this->exceptionHandler = $exceptionHandler;
38	11	$this->debuggerManager = $debuggerManager;
39	11	}
40
41		/**
42		* Report or log an exception.
43		*
44		* @param \Exception $e
45		*/
46	1	public function report(Exception $e)
47		{
48	1	$this->exceptionHandler->report($e);
49	1	}
50
51		/**
52		* Render an exception into an HTTP response.
53		*
54		* @param \Illuminate\Http\Request $request
55		* @param \Exception $e
56		* @return \Symfony\Component\HttpFoundation\Response
57		*/
58	8	public function render($request, Exception $e)
59		{
60	8	$response = $this->exceptionHandler->render($request, $e);
61
62	8	if ($this->shouldRenderException($response) === true) {
63	7	return $response;
64		}
65
66	1	$response->setContent(
67	1	$this->debuggerManager->exceptionHandler($e)
68		);
69
70	1	return $response;
71		}
72
73		/**
74		* Render an exception to the console.
75		*
76		* @param \Symfony\Component\Console\Output\OutputInterface $output
77		* @param \Exception $e
78		*/
79	1	public function renderForConsole($output, Exception $e)
80		{
81	1	$this->exceptionHandler->renderForConsole($output, $e);
82	1	}
83
84		/**
85		* shouldRenderException.
86		*
87		* @param \Illuminate\Http\Response\|\Symfony\Component\HttpFoundation\Response $response
88		* @return bool
89		*/
90	8	protected function shouldRenderException($response)
91		{
92	8	if ($response instanceof RedirectResponse) {
		0 ignored issues – show Bug introduced 2017-05-17 09:41 UTC by Report Bug Copy Issue Report The class `Symfony\Component\HttpFoundation\RedirectResponse` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
93	2	return true;
94		}
95
96	6	if ($response instanceof JsonResponse) {
		0 ignored issues – show Bug introduced 2017-05-17 09:41 UTC by Report Bug Copy Issue Report The class `Symfony\Component\HttpFoundation\JsonResponse` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
97	2	return true;
98		}
99
100	4	if ($response->getContent() instanceof View) {
		0 ignored issues – show Bug introduced 2017-05-17 09:41 UTC by Report Bug Copy Issue Report The class `Illuminate\Contracts\View\View` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
101	2	return true;
102		}
103
104	2	if ($response instanceof Response && $response->getOriginalContent() instanceof View) {
		0 ignored issues – show Bug introduced 2017-07-19 06:18 UTC by Report Bug Copy Issue Report The class `Illuminate\Http\Response` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history... Bug introduced 2017-07-19 06:18 UTC by Report Bug Copy Issue Report The class `Illuminate\Contracts\View\View` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
105	1	return true;
106		}
107
108	1	return false;
109		}
110		}
111

recca0120 / laravel-tracy

Push — master ( 1aa61a...c182a1 )

Handler::shouldRenderException() B

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like