LaravelPanel::setLaravel() - Code Metrics - Inspection of "interface" - recca0120/laravel-tracy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4df4ca...f9b142 )

by recca

created 2017-03-05 06:47 UTC

LaravelPanel::setLaravel() A

↳ Parent: LaravelPanel

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	3
nop	1
dl	0
loc	11
ccs	8
cts	8
cp	1
crap	3
rs	9.4285
c	0
b	0
f	0

<?php

namespace Recca0120\LaravelTracy\Panels;

use Illuminate\Contracts\Foundation\Application;

trait LaravelPanel
{
    /**
     * $laravel description.
     *
     * @var \Illuminate\Contracts\Foundation\Application
     */
    protected $laravel;

    /**
     * setLaravel.
     *
     * @param \Illuminate\Contracts\Foundation\Application $laravel
     * @return static
     */
    public function setLaravel(Application $laravel = null)
    {
        if (is_null($laravel) === false) {
            $this->laravel = $laravel;
            if (is_subclass_of($this, 'Recca0120\LaravelTracy\Panels\ISubscriablePanel') === true) {
                $this->subscribe();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        }

        return $this;
    }

    /**
     * is laravel.
     *
     * @return bool
     */
    protected function isLaravel()
    {
        return is_a($this->laravel, Application::class);
    }
}


1		<?php
2
3		namespace Recca0120\LaravelTracy\Panels;
4
5		use Illuminate\Contracts\Foundation\Application;
6
7		trait LaravelPanel
8		{
9		/**
10		* $laravel description.
11		*
12		* @var \Illuminate\Contracts\Foundation\Application
13		*/
14		protected $laravel;
15
16		/**
17		* setLaravel.
18		*
19		* @param \Illuminate\Contracts\Foundation\Application $laravel
20		* @return static
21		*/
22	17	public function setLaravel(Application $laravel = null)
23		{
24	17	if (is_null($laravel) === false) {
25	16	$this->laravel = $laravel;
26	16	if (is_subclass_of($this, 'Recca0120\LaravelTracy\Panels\ISubscriablePanel') === true) {
27	7	$this->subscribe();
		0 ignored issues – show Bug introduced 2017-03-05 06:49 UTC by Report Bug Copy Issue Report It seems like `subscribe()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28	7	}
29	16	}
30
31	17	return $this;
32		}
33
34		/**
35		* is laravel.
36		*
37		* @return bool
38		*/
39	8	protected function isLaravel()
40		{
41	8	return is_a($this->laravel, Application::class);
42		}
43		}
44

recca0120 / laravel-tracy

Push — master ( 4df4ca...f9b142 )

LaravelPanel::setLaravel() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like