RenderBar::renderBar() - Code Metrics - Inspection of "Fix session flash lost" - recca0120/laravel-tracy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#35)

by recca

created 2017-06-15 13:33 UTC

RenderBar::renderBar() A

↳ Parent: Project

Complexity

Conditions	3
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	6
c	0
b	0
f	0
nc	2
nop	2
dl	0
loc	10
ccs	6
cts	6
cp	1
crap	3
rs	9.4285

<?php

namespace Recca0120\LaravelTracy\Middleware;

use Illuminate\Http\Request;
use Illuminate\Contracts\Events\Dispatcher;
use Recca0120\LaravelTracy\DebuggerManager;
use Symfony\Component\HttpFoundation\Response;
use Recca0120\LaravelTracy\Events\BeforeBarRender;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\StreamedResponse;
use Symfony\Component\HttpFoundation\BinaryFileResponse;

class RenderBar
{
    /**
     * $debuggerManager.
     *
     * @var \Recca0120\LaravelTracy\DebuggerManager
     */
    protected $debuggerManager;

    /**
     * $events.
     *
     * @var \Illuminate\Contracts\Events\Dispatcher
     */
    protected $events;

    /**
     * __construct.
     *
     *
     * @param \Recca0120\LaravelTracy\DebuggerManager $debuggerManager
     * @param \Illuminate\Contracts\Events\Dispatcher $events
     */
    public function __construct(DebuggerManager $debuggerManager, Dispatcher $events)
    {
        $this->debuggerManager = $debuggerManager;
        $this->events = $events;
    }

    /**
     * handle.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure $next
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function handle($request, $next)
    {
        return $request->has('_tracy_bar') === true
            ? $this->renderBar($request, $next)
            : $this->appendBar($request, $next);
    }

    /**
     * appendBar.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure $next
     * @return \Symfony\Component\HttpFoundation\Response
     */
    protected function renderBar($request, $next)
    {
        $response = $next($request);
        $type = $request->get('_tracy_bar');
        if ($request->hasSession() === true && in_array($type, ['js', 'css'], true) === false) {
            $request->session()->reflash();
        }

        return $response;
    }

    /**
     * appendBar.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure $next
     * @return \Symfony\Component\HttpFoundation\Response
     */
    protected function appendBar($request, $next)
    {
        $this->debuggerManager->dispatch();

        $response = $next($request);

        if ($this->shouldNotRenderBar($response, $request) === true) {
            return $response;
        }

        $this->events->fire(new BeforeBarRender($request, $response));

        $response->setContent(
            $this->debuggerManager->shutdownHandler(
                $response->getContent()
            )
        );

        return $response;
    }

    /**
     * shouldNotRenderBar.
     *
     * @param \Symfony\Component\HttpFoundation\Response $response
     * @param \Illuminate\Http\Request $request
     *
     * @return bool
     */
    protected function shouldNotRenderBar(Response $response, Request $request)
    {
        if ($this->debuggerManager->showBar() === false ||
            $response instanceof BinaryFileResponse ||
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $response instanceof StreamedResponse ||
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $response instanceof RedirectResponse
if ($x instanceof DoesNotExist) {
    // Do something.
}
        ) {
            return true;
        }

        if ($request->ajax() === true) {
            return false;
        }

        $contentType = strtolower($response->headers->get('Content-Type'));
        $accepts = $this->debuggerManager->accepts();
        if ((empty($contentType) === true && $response->getStatusCode() >= 400) ||
            count($accepts) === 0
        ) {
            return false;
        }

        foreach ($accepts as $accept) {
            if (strpos($contentType, $accept) !== false) {
                return false;
            }
        }

        return true;
    }
}


1		<?php
2
3		namespace Recca0120\LaravelTracy\Middleware;
4
5		use Illuminate\Http\Request;
6		use Illuminate\Contracts\Events\Dispatcher;
7		use Recca0120\LaravelTracy\DebuggerManager;
8		use Symfony\Component\HttpFoundation\Response;
9		use Recca0120\LaravelTracy\Events\BeforeBarRender;
10		use Symfony\Component\HttpFoundation\RedirectResponse;
11		use Symfony\Component\HttpFoundation\StreamedResponse;
12		use Symfony\Component\HttpFoundation\BinaryFileResponse;
13
14		class RenderBar
15		{
16		/**
17		* $debuggerManager.
18		*
19		* @var \Recca0120\LaravelTracy\DebuggerManager
20		*/
21		protected $debuggerManager;
22
23		/**
24		* $events.
25		*
26		* @var \Illuminate\Contracts\Events\Dispatcher
27		*/
28		protected $events;
29
30		/**
31		* __construct.
32		*
33		*
34		* @param \Recca0120\LaravelTracy\DebuggerManager $debuggerManager
35		* @param \Illuminate\Contracts\Events\Dispatcher $events
36		*/
37	10	public function __construct(DebuggerManager $debuggerManager, Dispatcher $events)
38		{
39	10	$this->debuggerManager = $debuggerManager;
40	10	$this->events = $events;
41	10	}
42
43		/**
44		* handle.
45		*
46		* @param \Illuminate\Http\Request $request
47		* @param \Closure $next
48		* @return \Symfony\Component\HttpFoundation\Response
49		*/
50	10	public function handle($request, $next)
51		{
52	10	return $request->has('_tracy_bar') === true
53	1	? $this->renderBar($request, $next)
54	10	: $this->appendBar($request, $next);
55		}
56
57		/**
58		* appendBar.
59		*
60		* @param \Illuminate\Http\Request $request
61		* @param \Closure $next
62		* @return \Symfony\Component\HttpFoundation\Response
63		*/
64	1	protected function renderBar($request, $next)
65		{
66	1	$response = $next($request);
67	1	$type = $request->get('_tracy_bar');
68	1	if ($request->hasSession() === true && in_array($type, ['js', 'css'], true) === false) {
69	1	$request->session()->reflash();
70		}
71
72	1	return $response;
73		}
74
75		/**
76		* appendBar.
77		*
78		* @param \Illuminate\Http\Request $request
79		* @param \Closure $next
80		* @return \Symfony\Component\HttpFoundation\Response
81		*/
82	9	protected function appendBar($request, $next)
83		{
84	9	$this->debuggerManager->dispatch();
85
86	9	$response = $next($request);
87
88	9	if ($this->shouldNotRenderBar($response, $request) === true) {
89	5	return $response;
90		}
91
92	4	$this->events->fire(new BeforeBarRender($request, $response));
93
94	4	$response->setContent(
95	4	$this->debuggerManager->shutdownHandler(
96	4	$response->getContent()
97		)
98		);
99
100	4	return $response;
101		}
102
103		/**
104		* shouldNotRenderBar.
105		*
106		* @param \Symfony\Component\HttpFoundation\Response $response
107		* @param \Illuminate\Http\Request $request
108		*
109		* @return bool
110		*/
111	9	protected function shouldNotRenderBar(Response $response, Request $request)
112		{
113	9	if ($this->debuggerManager->showBar() === false \|\|
114	8	$response instanceof BinaryFileResponse \|\|
		0 ignored issues – show Bug introduced 2017-05-17 09:41 UTC by Report Bug Copy Issue Report The class `Symfony\Component\HttpFo...tion\BinaryFileResponse` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
115	7	$response instanceof StreamedResponse \|\|
		0 ignored issues – show Bug introduced 2017-05-17 09:41 UTC by Report Bug Copy Issue Report The class `Symfony\Component\HttpFoundation\StreamedResponse` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
116	6	$response instanceof RedirectResponse
		0 ignored issues – show Bug introduced 2017-05-17 09:41 UTC by Report Bug Copy Issue Report The class `Symfony\Component\HttpFoundation\RedirectResponse` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
117		) {
118	4	return true;
119		}
120
121	5	if ($request->ajax() === true) {
122	1	return false;
123		}
124
125	4	$contentType = strtolower($response->headers->get('Content-Type'));
126	4	$accepts = $this->debuggerManager->accepts();
127	4	if ((empty($contentType) === true && $response->getStatusCode() >= 400) \|\|
128	3	count($accepts) === 0
129		) {
130	2	return false;
131		}
132
133	2	foreach ($accepts as $accept) {
134	2	if (strpos($contentType, $accept) !== false) {
135	1	return false;
136		}
137		}
138
139	1	return true;
140		}
141		}
142

recca0120 / laravel-tracy

Pull Request — master (#35)

RenderBar::renderBar() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like