ArtisanTinker::fire() - Code Metrics - Inspection of "update" - recca0120/laravel-terminal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ecc98d...289748 )

by recca

created 2017-05-30 03:30 UTC

ArtisanTinker::fire() B

↳ Parent: ArtisanTinker

Complexity

Conditions	6
Paths	10

Size

Total Lines	28
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	24
CRAP Score	6

Importance

Changes	5
Bugs	0	Features	0

Metric	Value
cc	6
eloc	20
c	5
b	0
f	0
nc	10
nop	0
dl	0
loc	28
ccs	24
cts	24
cp	1
crap	6
rs	8.439

<?php

namespace Recca0120\Terminal\Console\Commands;

use Illuminate\Console\Command;
use Symfony\Component\Console\Input\InputOption;

class ArtisanTinker extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'tinker';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'artisn tinker';

    /**
     * fire.
     */
    public function fire()
    {
        $command = $this->option('command');

        ob_start();
        $result = $this->executeCode(
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            trim(trim($command), ';').';'
        );
        $output = ob_get_clean();

        if (empty($output) === false) {
            $this->line($output);
        }

        $this->getOutput()->write('=> ');
        switch (gettype($result)) {
            case 'object':
            case 'array':
                $this->line(var_export($result, true));
                break;
            case 'string':
                $this->comment($result);
                break;
            default:
                is_numeric($result) === true ? $this->info($result) : $this->line($result);
                break;
        }
    }

    protected function executeCode($code)
    {
        $result = null;
        if (strpos($code, 'echo') !== false || strpos($code, 'var_dump') !== false) {
            eval($code);

        } else {
            eval('$result = '.$code);

        }

        return $result;
    }

    /**
     * Get the console command options.
     *
     * @return array
     */
    protected function getOptions()
    {
        return [
            ['command', null, InputOption::VALUE_OPTIONAL],
        ];
    }
}


1		<?php
2
3		namespace Recca0120\Terminal\Console\Commands;
4
5		use Illuminate\Console\Command;
6		use Symfony\Component\Console\Input\InputOption;
7
8		class ArtisanTinker extends Command
9		{
10		/**
11		* The console command name.
12		*
13		* @var string
14		*/
15		protected $name = 'tinker';
16
17		/**
18		* The console command description.
19		*
20		* @var string
21		*/
22		protected $description = 'artisn tinker';
23
24		/**
25		* fire.
26		*/
27	6	public function fire()
28		{
29	6	$command = $this->option('command');
30
31	6	ob_start();
32	6	$result = $this->executeCode(
		0 ignored issues – show Bug introduced 2017-05-30 03:32 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$result` is correct as `$this->executeCode(trim(...($command), ';') . ';')` (which targets `Recca0120\Terminal\Conso...anTinker::executeCode()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
33	6	trim(trim($command), ';').';'
34	6	);
35	6	$output = ob_get_clean();
36
37	6	if (empty($output) === false) {
38	2	$this->line($output);
39	2	}
40
41	6	$this->getOutput()->write('=> ');
42	6	switch (gettype($result)) {
43	6	case 'object':
44	6	case 'array':
45	2	$this->line(var_export($result, true));
46	2	break;
47	4	case 'string':
48	1	$this->comment($result);
49	1	break;
50	3	default:
51	3	is_numeric($result) === true ? $this->info($result) : $this->line($result);
52	3	break;
53	6	}
54	6	}
55
56	6	protected function executeCode($code)
57		{
58	6	$result = null;
59	6	if (strpos($code, 'echo') !== false \|\| strpos($code, 'var_dump') !== false) {
60	2	eval($code);
		0 ignored issues – show Coding Style introduced 2017-05-30 03:32 UTC by Report Bug Copy Issue Report It is generally not recommended to use `eval` unless absolutely required. On one hand, `eval` might be exploited by malicious users if they somehow manage to inject dynamic content. On the other hand, with the emergence of faster PHP runtimes like the HHVM, `eval` prevents some optimization that they perform. Loading history...
61	2	} else {
62	4	eval('$result = '.$code);
		0 ignored issues – show Coding Style introduced 2017-05-30 03:32 UTC by Report Bug Copy Issue Report It is generally not recommended to use `eval` unless absolutely required. On one hand, `eval` might be exploited by malicious users if they somehow manage to inject dynamic content. On the other hand, with the emergence of faster PHP runtimes like the HHVM, `eval` prevents some optimization that they perform. Loading history...
63		}
64
65	6	return $result;
66		}
67
68		/**
69		* Get the console command options.
70		*
71		* @return array
72		*/
73	6	protected function getOptions()
74		{
75		return [
76	6	['command', null, InputOption::VALUE_OPTIONAL],
77	6	];
78		}
79		}
80

recca0120 / laravel-terminal

Push — master ( ecc98d...289748 )

ArtisanTinker::fire() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like