Issues in SqliteConnectionResolver.php (master) - Issues in master - recca0120/laravel-repository - Measure and Improve Code Quality continuously with Scrutinizer

Issues (20)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/SqliteConnectionResolver.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Recca0120\Repository;

use Illuminate\Container\Container;
use Illuminate\Database\ConnectionResolverInterface;
use Illuminate\Database\Connectors\ConnectionFactory;

class SqliteConnectionResolver implements ConnectionResolverInterface
{
    /**
     * All of the registered connections.
     *
     * @var array
     */
    protected $connections = [];

    /**
     * The default connection name.
     *
     * @var string
     */
    protected $default = 'default';
    /**
     * The current globally available container (if any).
     *
     * @var static
     */
    private static $instance;

    public function __construct(ConnectionFactory $factory = null)

    {
        $this->factory = $connectionFactory = new ConnectionFactory(
class MyClass { }

$x = new MyClass();
$x->foo = true;
            Container::getInstance() ?: new Container
        );
    }

    /**
     * Get a database connection instance.
     *
     * @param  string  $name
     * @return \Illuminate\Database\ConnectionInterface
     */
    public function connection($name = null)
    {
        if (is_null($name)) {
            $name = $this->getDefaultConnection();
        }

        if (isset($this->connections[$name]) === false) {
            $this->connections[$name] = $this->factory->make([
                'driver' => 'sqlite',
                'database' => ':memory:',
            ], $name);
        }

        return $this->connections[$name];
    }

    /**
     * Get the default connection name.
     *
     * @return string
     */
    public function getDefaultConnection()
    {
        return $this->default;
    }

    /**
     * Set the default connection name.
     *
     * @param  string  $name
     * @return void
     */
    public function setDefaultConnection($name)
    {
        $this->default = $name;
    }

    /**
     * Set the globally available instance of the SqliteConnectionResolver.
     *
     * @return static
     */
    public static function getInstance(ConnectionFactory $factory = null)
    {
        if (is_null(static::$instance)) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            static::$instance = new static($factory);
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        }

        return static::$instance;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }
}


1		<?php
2
3		namespace Recca0120\Repository;
4
5		use Illuminate\Container\Container;
6		use Illuminate\Database\ConnectionResolverInterface;
7		use Illuminate\Database\Connectors\ConnectionFactory;
8
9		class SqliteConnectionResolver implements ConnectionResolverInterface
10		{
11		/**
12		* All of the registered connections.
13		*
14		* @var array
15		*/
16		protected $connections = [];
17
18		/**
19		* The default connection name.
20		*
21		* @var string
22		*/
23		protected $default = 'default';
24		/**
25		* The current globally available container (if any).
26		*
27		* @var static
28		*/
29		private static $instance;
30
31	1	public function __construct(ConnectionFactory $factory = null)
		0 ignored issues – show Unused Code introduced 2017-12-22 04:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$factory` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
32		{
33	1	$this->factory = $connectionFactory = new ConnectionFactory(
		0 ignored issues – show Bug introduced 2017-12-22 04:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `factory` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Unused Code introduced 2017-12-22 04:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$connectionFactory` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
34	1	Container::getInstance() ?: new Container
35		);
36	1	}
37
38		/**
39		* Get a database connection instance.
40		*
41		* @param string $name
42		* @return \Illuminate\Database\ConnectionInterface
43		*/
44	31	public function connection($name = null)
45		{
46	31	if (is_null($name)) {
47	31	$name = $this->getDefaultConnection();
48		}
49
50	31	if (isset($this->connections[$name]) === false) {
51	1	$this->connections[$name] = $this->factory->make([
52	1	'driver' => 'sqlite',
53		'database' => ':memory:',
54	1	], $name);
55		}
56
57	31	return $this->connections[$name];
58		}
59
60		/**
61		* Get the default connection name.
62		*
63		* @return string
64		*/
65	31	public function getDefaultConnection()
66		{
67	31	return $this->default;
68		}
69
70		/**
71		* Set the default connection name.
72		*
73		* @param string $name
74		* @return void
75		*/
76		public function setDefaultConnection($name)
77		{
78		$this->default = $name;
79		}
80
81		/**
82		* Set the globally available instance of the SqliteConnectionResolver.
83		*
84		* @return static
85		*/
86	31	public static function getInstance(ConnectionFactory $factory = null)
87		{
88	31	if (is_null(static::$instance)) {
		0 ignored issues – show Bug introduced 2017-12-22 04:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
89	1	static::$instance = new static($factory);
		0 ignored issues – show Bug introduced 2017-12-22 04:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
90		}
91
92	31	return static::$instance;
		0 ignored issues – show Bug introduced 2017-12-22 04:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
93		}
94		}
95

recca0120 / laravel-repository

Issues (20)

Security Analysis no request data

src/SqliteConnectionResolver.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like