SqliteConnectionResolver - Code Metrics - Inspection of "fixed make model in repository, without __construc..." - recca0120/laravel-repository - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

unknown

created 2018-06-04 19:20 UTC

SqliteConnectionResolver A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	86
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	2

Test Coverage

Coverage

47.62%

Importance

Changes

Metric	Value
dl	0
loc	86
ccs	10
cts	21
cp	0.4762
rs	10
c	0
b	0
f	0
wmc	9
lcom	2
cbo	2

5 Methods

Rating	Name	Size	Complexity
A	getDefaultConnection()	4	1
A	setDefaultConnection()	4	1
A	__construct()	6	2
A	connection()	15	3
A	getInstance()	8	2

<?php

namespace Recca0120\Repository;

use Illuminate\Container\Container;
use Illuminate\Database\ConnectionResolverInterface;
use Illuminate\Database\Connectors\ConnectionFactory;

class SqliteConnectionResolver implements ConnectionResolverInterface
{
    /**
     * All of the registered connections.
     *
     * @var array
     */
    protected $connections = [];

    /**
     * The default connection name.
     *
     * @var string
     */
    protected $default = 'default';
    /**
     * The current globally available container (if any).
     *
     * @var static
     */
    private static $instance;

    public function __construct(ConnectionFactory $factory = null)

    {
        $this->factory = $connectionFactory = new ConnectionFactory(
class MyClass { }

$x = new MyClass();
$x->foo = true;
            Container::getInstance() ?: new Container
        );
    }

    /**
     * Get a database connection instance.
     *
     * @param  string  $name
     * @return \Illuminate\Database\ConnectionInterface
     */
    public function connection($name = null)
    {
        if (is_null($name)) {
            $name = $this->getDefaultConnection();
        }

        if (isset($this->connections[$name]) === false) {
            $this->connections[$name] = $this->factory->make([
                'driver' => 'sqlite',
                'database' => ':memory:',
            ], $name);
        }

        return $this->connections[$name];
    }

    /**
     * Get the default connection name.
     *
     * @return string
     */
    public function getDefaultConnection()
    {
        return $this->default;
    }

    /**
     * Set the default connection name.
     *
     * @param  string  $name
     * @return void
     */
    public function setDefaultConnection($name)
    {
        $this->default = $name;
    }

    /**
     * Set the globally available instance of the SqliteConnectionResolver.
     *
     * @return static
     */
    public static function getInstance(ConnectionFactory $factory = null)
    {
        if (is_null(static::$instance)) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            static::$instance = new static($factory);
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        }

        return static::$instance;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }
}


1		<?php
2
3		namespace Recca0120\Repository;
4
5		use Illuminate\Container\Container;
6		use Illuminate\Database\ConnectionResolverInterface;
7		use Illuminate\Database\Connectors\ConnectionFactory;
8
9		class SqliteConnectionResolver implements ConnectionResolverInterface
10		{
11		/**
12		* All of the registered connections.
13		*
14		* @var array
15		*/
16		protected $connections = [];
17
18		/**
19		* The default connection name.
20		*
21		* @var string
22		*/
23		protected $default = 'default';
24		/**
25		* The current globally available container (if any).
26		*
27		* @var static
28		*/
29		private static $instance;
30
31		public function __construct(ConnectionFactory $factory = null)
		0 ignored issues – show Unused Code introduced 2017-12-22 04:17 UTC by Report Bug Copy Issue Report The parameter `$factory` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
32		{
33		$this->factory = $connectionFactory = new ConnectionFactory(
		0 ignored issues – show Bug introduced 2017-12-22 04:17 UTC by Report Bug Copy Issue Report The property `factory` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Unused Code introduced 2017-12-22 04:17 UTC by Report Bug Copy Issue Report `$connectionFactory` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
34		Container::getInstance() ?: new Container
35		);
36		}
37
38		/**
39		* Get a database connection instance.
40		*
41		* @param string $name
42		* @return \Illuminate\Database\ConnectionInterface
43		*/
44	1	public function connection($name = null)
45		{
46	1	if (is_null($name)) {
47	1	$name = $this->getDefaultConnection();
48		}
49
50	1	if (isset($this->connections[$name]) === false) {
51		$this->connections[$name] = $this->factory->make([
52		'driver' => 'sqlite',
53		'database' => ':memory:',
54		], $name);
55		}
56
57	1	return $this->connections[$name];
58		}
59
60		/**
61		* Get the default connection name.
62		*
63		* @return string
64		*/
65	1	public function getDefaultConnection()
66		{
67	1	return $this->default;
68		}
69
70		/**
71		* Set the default connection name.
72		*
73		* @param string $name
74		* @return void
75		*/
76		public function setDefaultConnection($name)
77		{
78		$this->default = $name;
79		}
80
81		/**
82		* Set the globally available instance of the SqliteConnectionResolver.
83		*
84		* @return static
85		*/
86	1	public static function getInstance(ConnectionFactory $factory = null)
87		{
88	1	if (is_null(static::$instance)) {
		0 ignored issues – show Bug introduced 2017-12-22 04:17 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
89		static::$instance = new static($factory);
		0 ignored issues – show Bug introduced 2017-12-22 04:17 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
90		}
91
92	1	return static::$instance;
		0 ignored issues – show Bug introduced 2017-12-22 04:17 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
93		}
94		}
95

recca0120 / laravel-repository

Pull Request — master (#5)

SqliteConnectionResolver A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like