Issues in plugin.php (master) - Issues in master - recca0120/laravel-elfinder - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1107)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/plugins/Sanitizer/plugin.php (10 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * elFinder Plugin Sanitizer.
 *
 * Sanitizer of file-name and file-path etc.
 *
 * ex. binding, configure on connector options
 *	$opts = array(
 *		'bind' => array(
 *			'upload.pre mkdir.pre mkfile.pre rename.pre archive.pre ls.pre' => array(
 *				'Plugin.Sanitizer.cmdPreprocess'
 *			),
 *			'ls' => array(
 *				'Plugin.Sanitizer.cmdPostprocess'
 *			),
 *			'upload.presave' => array(
 *				'Plugin.Sanitizer.onUpLoadPreSave'
 *			)
 *		),
 *		// global configure (optional)
 *		'plugin' => array(
 *			'Sanitizer' => array(
 *				'enable' => true,
 *				'targets'  => array('\\','/',':','*','?','"','<','>','|'), // target chars
 *				'replace'  => '_'    // replace to this
 *			)
 *		),
 *		// each volume configure (optional)
 *		'roots' => array(
 *			array(
 *				'driver' => 'LocalFileSystem',
 *				'path'   => '/path/to/files/',
 *				'URL'    => 'http://localhost/to/files/'
 *				'plugin' => array(
 *					'Sanitizer' => array(
 *						'enable' => true,
 *						'targets'  => array('\\','/',':','*','?','"','<','>','|'), // target chars
 *						'replace'  => '_'    // replace to this
 *					)
 *				)
 *			)
 *		)
 *	);
 *
 * @author Naoki Sawada
 * @license New BSD
 */
class elFinderPluginSanitizer extends elFinderPlugin
namespace YourVendor;

class YourClass { }
{
    private $replaced = [];
    private $keyMap = [
        'ls' => 'intersect',
        'upload' => 'renames',
    ];

    public function __construct($opts)
    {
        $defaults = [
            'enable' => true,  // For control by volume driver
            'targets' => ['\\', '/', ':', '*', '?', '"', '<', '>', '|'], // target chars
            'replace' => '_',   // replace to this
            'pathAllows' => ['/'], // Characters allowed in path name of characters in `targets` array
        ];

        $this->opts = array_merge($defaults, $opts);
    }

    public function cmdPreprocess($cmd, &$args, $elfinder, $volume)

    {
        $opts = $this->getCurrentOpts($volume);
        if (! $opts['enable']) {
            return false;
        }
        $this->replaced[$cmd] = [];
        $key = (isset($this->keyMap[$cmd])) ? $this->keyMap[$cmd] : 'name';

        if (isset($args[$key])) {
            if (is_array($args[$key])) {
                foreach ($args[$key] as $i => $name) {
                    $this->replaced[$cmd][$name] = $args[$key][$i] = $this->sanitizeFileName($name, $opts);
                }
            } else {
                $name = $args[$key];
                $this->replaced[$cmd][$name] = $args[$key] = $this->sanitizeFileName($name, $opts);
            }
        }

        return true;
    }

    public function cmdPostprocess($cmd, &$result, $args, $elfinder)

    {
        if ($cmd === 'ls') {
            if (! empty($result['list']) && ! empty($this->replaced['ls'])) {
                foreach ($result['list'] as $hash => $name) {
                    if ($keys = array_keys($this->replaced['ls'], $name)) {
                        if (count($keys) === 1) {
                            $result['list'][$hash] = $keys[0];
                        } else {
                            $result['list'][$hash] = $keys;
                        }
                    }
                }
            }
        }
    }

    // NOTE: $thash is directory hash so it unneed to process at here
    public function onUpLoadPreSave(&$thash, &$name, $src, $elfinder, $volume)

    {
        $opts = $this->getCurrentOpts($volume);
        if (! $opts['enable']) {
            return false;
        }

        $name = $this->sanitizeFileName($name, $opts);

        return true;
    }

    private function sanitizeFileName($filename, $opts, $allows = [])
    {
        $targets = $allows ? array_diff($opts['targets'], $allows) : $opts['targets'];

        return str_replace($targets, $opts['replace'], $filename);
    }
}


1		<?php
2		/**
3		* elFinder Plugin Sanitizer.
4		*
5		* Sanitizer of file-name and file-path etc.
6		*
7		* ex. binding, configure on connector options
8		* $opts = array(
9		* 'bind' => array(
10		* 'upload.pre mkdir.pre mkfile.pre rename.pre archive.pre ls.pre' => array(
11		* 'Plugin.Sanitizer.cmdPreprocess'
12		* ),
13		* 'ls' => array(
14		* 'Plugin.Sanitizer.cmdPostprocess'
15		* ),
16		* 'upload.presave' => array(
17		* 'Plugin.Sanitizer.onUpLoadPreSave'
18		* )
19		* ),
20		* // global configure (optional)
21		* 'plugin' => array(
22		* 'Sanitizer' => array(
23		* 'enable' => true,
24		* 'targets' => array('\\','/',':','*','?','"','<','>','\|'), // target chars
25		* 'replace' => '_' // replace to this
26		* )
27		* ),
28		* // each volume configure (optional)
29		* 'roots' => array(
30		* array(
31		* 'driver' => 'LocalFileSystem',
32		* 'path' => '/path/to/files/',
33		* 'URL' => 'http://localhost/to/files/'
34		* 'plugin' => array(
35		* 'Sanitizer' => array(
36		* 'enable' => true,
37		* 'targets' => array('\\','/',':','*','?','"','<','>','\|'), // target chars
38		* 'replace' => '_' // replace to this
39		* )
40		* )
41		* )
42		* )
43		* );
44		*
45		* @author Naoki Sawada
46		* @license New BSD
47		*/
48		class elFinderPluginSanitizer extends elFinderPlugin
		0 ignored issues – show Coding Style Compatibility introduced 2017-06-16 18:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
49		{
50		private $replaced = [];
51		private $keyMap = [
52		'ls' => 'intersect',
53		'upload' => 'renames',
54		];
55
56		public function __construct($opts)
57		{
58		$defaults = [
59		'enable' => true, // For control by volume driver
60		'targets' => ['\\', '/', ':', '*', '?', '"', '<', '>', '\|'], // target chars
61		'replace' => '_', // replace to this
62		'pathAllows' => ['/'], // Characters allowed in path name of characters in `targets` array
63		];
64
65		$this->opts = array_merge($defaults, $opts);
66		}
67
68	View Code Duplication	public function cmdPreprocess($cmd, &$args, $elfinder, $volume)
		0 ignored issues – show Unused Code introduced 2017-08-18 02:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$elfinder` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2017-08-18 02:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69		{
70		$opts = $this->getCurrentOpts($volume);
71		if (! $opts['enable']) {
72		return false;
73		}
74		$this->replaced[$cmd] = [];
75		$key = (isset($this->keyMap[$cmd])) ? $this->keyMap[$cmd] : 'name';
76
77		if (isset($args[$key])) {
78		if (is_array($args[$key])) {
79		foreach ($args[$key] as $i => $name) {
80		$this->replaced[$cmd][$name] = $args[$key][$i] = $this->sanitizeFileName($name, $opts);
81		}
82		} else {
83		$name = $args[$key];
84		$this->replaced[$cmd][$name] = $args[$key] = $this->sanitizeFileName($name, $opts);
85		}
86		}
87
88		return true;
89		}
90
91	View Code Duplication	public function cmdPostprocess($cmd, &$result, $args, $elfinder)
		0 ignored issues – show Unused Code introduced 2017-08-18 02:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$args` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-18 02:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$elfinder` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2017-08-18 02:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
92		{
93		if ($cmd === 'ls') {
94		if (! empty($result['list']) && ! empty($this->replaced['ls'])) {
95		foreach ($result['list'] as $hash => $name) {
96		if ($keys = array_keys($this->replaced['ls'], $name)) {
97		if (count($keys) === 1) {
98		$result['list'][$hash] = $keys[0];
99		} else {
100		$result['list'][$hash] = $keys;
101		}
102		}
103		}
104		}
105		}
106		}
107
108		// NOTE: $thash is directory hash so it unneed to process at here
109	View Code Duplication	public function onUpLoadPreSave(&$thash, &$name, $src, $elfinder, $volume)
		0 ignored issues – show Unused Code introduced 2017-08-18 02:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$thash` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-18 02:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$src` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-18 02:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$elfinder` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2017-08-18 02:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
110		{
111		$opts = $this->getCurrentOpts($volume);
112		if (! $opts['enable']) {
113		return false;
114		}
115
116		$name = $this->sanitizeFileName($name, $opts);
117
118		return true;
119		}
120
121		private function sanitizeFileName($filename, $opts, $allows = [])
122		{
123		$targets = $allows ? array_diff($opts['targets'], $allows) : $opts['targets'];
124
125		return str_replace($targets, $opts['replace'], $filename);
126		}
127		}
128

recca0120 / laravel-elfinder

Issues (1107)

Security Analysis not enabled

lib/plugins/Sanitizer/plugin.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like