Recca0120\Elfinder\Options

Complexity

Total Complexity

13

Size/Duplication

Total Lines	150
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	4

Test Coverage

Coverage

86.36%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	1
A	createLocalFileSystemDriver()	0	4	1
A	createTrashDriver()	0	6	1
B	getRoots()	0	19	5
B	createDefaultDriver()	0	27	5

<?php

namespace Recca0120\Elfinder;

use Closure;
use ArrayObject;
use Illuminate\Support\Arr;
use Illuminate\Http\Request;
use Illuminate\Filesystem\Filesystem;
use Illuminate\Contracts\Routing\UrlGenerator;

class Options extends ArrayObject
{
    /**
     * $request.
     *
     * @var \Illuminate\Http\Request
     */
    protected $request;

    /**
     * $files.
     *
     * @var \Illuminate\Filesystem\Filesystem
     */
    protected $files;

    /**
     * $request.
     *
     * @var \Illuminate\Contracts\Routing\UrlGenerator
     */
    protected $urlGenerator;

    /**
     * $config.
     *
     * @var array
     */
    protected $config;

    /**
     * $options.
     *
     * @var array
     */
    protected $options;

    /**
     * __construct.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Illuminate\Filesystem\Filesystem $files
     * @param \Illuminate\Contracts\Routing\UrlGenerator $urlGenerator
     * @param \Recca0120\Elfinder\LaravelSession $session
     * @param array $config
     */
    public function __construct(Request $request, Filesystem $files, UrlGenerator $urlGenerator, LaravelSession $session, $config = [])

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
        $this->files = $files;
        $this->urlGenerator = $urlGenerator;
        $this->config = $config;
        $this->options = Arr::get($this->config, 'options', []);

It seems like \Illuminate\Support\Arr::get($this->config, 'options', array()) of type * is incompatible with the declared type array of property $options.

        parent::__construct(array_merge($this->options, [
            'roots' => $this->getRoots(),
            'session' => $session,
        ]));
    }

    /**
     * getRoots.
     *
     * @return array
     */
    protected function getRoots()
    {
        $accessControl = Arr::get($this->config, 'accessControl');
        $roots = Arr::get($this->options, 'roots', []);
        $user = $this->request->user();

        return array_filter(array_map(function ($disk) use ($user, $accessControl) {
            $disk['driver'] = empty($disk['driver']) === true ? 'LocalFileSystem' : $disk['driver'];
            $disk['autoload'] = true;

            if (empty($disk['path']) === false && ($disk['path'] instanceof Closure) === true) {
                $disk['path'] = call_user_func($disk['path']);
            }
            $method = 'create'.$disk['driver'].'Driver';
            $method = method_exists($this, $method) === true ? $method : 'createDefaultDriver';

            return call_user_func_array([$this, $method], [$disk, $user, $accessControl]);
        }, $roots));
    }

    /**
     * createDefaultDriver.
     *
     * @param array $disk
     * @param mixed $user
     * @param mixed $accessControl
     * @param bool $makeDirectory
     * @return array
     */
    protected function createDefaultDriver($disk, $user, $accessControl = null, $makeDirectory = false)
    {
        if (strpos($disk['path'], '{user_id}') !== -1) {
            if (is_null($user) === true) {
                return;
            }

            $userId = $user->id;
            $disk['path'] = str_replace('{user_id}', $userId, $disk['path']);
            $disk['URL'] = str_replace('{user_id}', $userId, $disk['URL']);
        }

        if ($makeDirectory === true && $this->files->exists($disk['path']) === false) {
            $this->files->makeDirectory($disk['path'], 0755, true);
        }

        $disk['URL'] = $this->urlGenerator->to($disk['URL']);

        return array_merge([
            'accessControl' => $accessControl,
            'autoload' => true,
            'mimeDetect' => 'internal',
            'tmbBgColor' => 'transparent',
            'tmbCrop' => false,
            'utf8fix' => true,
        ], $disk);
    }

    /**
     * createLocalFileSystemDriver.
     *
     * @param  array $disk
     * @param  mixed $user
     * @param  mixed $accessControl
     * @return array
     */
    protected function createLocalFileSystemDriver($disk, $user, $accessControl = null)
    {
        return $this->createDefaultDriver($disk, $user, $accessControl, true);
    }

    /**
     * createTrashDriver.
     *
     * @param  array $disk
     * @param  mixed $user
     * @param  mixed $accessControl
     * @return array
     */
    protected function createTrashDriver($disk, $user, $accessControl = null)
    {
        return $this->createDefaultDriver(array_merge([
            'id' => 1,
        ], $disk), $user, $accessControl, true);
    }
}