recca0120 /
laravel-elfinder
| Conditions | 30 |
| Paths | 3330 |
| Total Lines | 119 |
| Code Lines | 92 |
| Lines | 68 |
| Ratio | 57.14 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.
There are several approaches to avoid long parameter lists:
| 1 | <?php |
||
| 188 | private function watermarkPrint_gd($src, $watermark, $dest_x, $dest_y, $quality, $transparency, $watermarkImgInfo, $srcImgInfo) |
||
| 189 | { |
||
| 190 | $watermark_width = $watermarkImgInfo[0]; |
||
| 191 | $watermark_height = $watermarkImgInfo[1]; |
||
| 192 | |||
| 193 | $ermsg = ''; |
||
| 194 | View Code Duplication | switch ($watermarkImgInfo['mime']) { |
|
| 195 | case 'image/gif': |
||
| 196 | if (imagetypes() & IMG_GIF) { |
||
| 197 | $oWatermarkImg = imagecreatefromgif($watermark); |
||
| 198 | } else { |
||
| 199 | $ermsg = 'GIF images are not supported'; |
||
| 200 | } |
||
| 201 | break; |
||
| 202 | case 'image/jpeg': |
||
| 203 | if (imagetypes() & IMG_JPG) { |
||
| 204 | $oWatermarkImg = imagecreatefromjpeg($watermark); |
||
| 205 | } else { |
||
| 206 | $ermsg = 'JPEG images are not supported'; |
||
| 207 | } |
||
| 208 | break; |
||
| 209 | case 'image/png': |
||
| 210 | if (imagetypes() & IMG_PNG) { |
||
| 211 | $oWatermarkImg = imagecreatefrompng($watermark); |
||
| 212 | } else { |
||
| 213 | $ermsg = 'PNG images are not supported'; |
||
| 214 | } |
||
| 215 | break; |
||
| 216 | case 'image/wbmp': |
||
| 217 | if (imagetypes() & IMG_WBMP) { |
||
| 218 | $oWatermarkImg = imagecreatefromwbmp($watermark); |
||
| 219 | } else { |
||
| 220 | $ermsg = 'WBMP images are not supported'; |
||
| 221 | } |
||
| 222 | break; |
||
| 223 | default: |
||
| 224 | $oWatermarkImg = false; |
||
| 225 | $ermsg = $watermarkImgInfo['mime'].' images are not supported'; |
||
| 226 | break; |
||
| 227 | } |
||
| 228 | |||
| 229 | if (! $ermsg) { |
||
| 230 | View Code Duplication | switch ($srcImgInfo['mime']) { |
|
| 231 | case 'image/gif': |
||
| 232 | if (imagetypes() & IMG_GIF) { |
||
| 233 | $oSrcImg = imagecreatefromgif($src); |
||
| 234 | } else { |
||
| 235 | $ermsg = 'GIF images are not supported'; |
||
| 236 | } |
||
| 237 | break; |
||
| 238 | case 'image/jpeg': |
||
| 239 | if (imagetypes() & IMG_JPG) { |
||
| 240 | $oSrcImg = imagecreatefromjpeg($src); |
||
| 241 | } else { |
||
| 242 | $ermsg = 'JPEG images are not supported'; |
||
| 243 | } |
||
| 244 | break; |
||
| 245 | case 'image/png': |
||
| 246 | if (imagetypes() & IMG_PNG) { |
||
| 247 | $oSrcImg = imagecreatefrompng($src); |
||
| 248 | } else { |
||
| 249 | $ermsg = 'PNG images are not supported'; |
||
| 250 | } |
||
| 251 | break; |
||
| 252 | case 'image/wbmp': |
||
| 253 | if (imagetypes() & IMG_WBMP) { |
||
| 254 | $oSrcImg = imagecreatefromwbmp($src); |
||
| 255 | } else { |
||
| 256 | $ermsg = 'WBMP images are not supported'; |
||
| 257 | } |
||
| 258 | break; |
||
| 259 | default: |
||
| 260 | $oSrcImg = false; |
||
| 261 | $ermsg = $srcImgInfo['mime'].' images are not supported'; |
||
| 262 | break; |
||
| 263 | } |
||
| 264 | } |
||
| 265 | |||
| 266 | if ($ermsg || false === $oSrcImg || false === $oWatermarkImg) { |
||
| 267 | return false; |
||
| 268 | } |
||
| 269 | |||
| 270 | if ($srcImgInfo['mime'] === 'image/png') { |
||
| 271 | if (function_exists('imagecolorallocatealpha')) { |
||
| 272 | $bg = imagecolorallocatealpha($oSrcImg, 255, 255, 255, 127); |
||
| 273 | imagefill($oSrcImg, 0, 0, $bg); |
||
| 274 | } |
||
| 275 | } |
||
| 276 | |||
| 277 | if ($watermarkImgInfo['mime'] === 'image/png') { |
||
| 278 | imagecopy($oSrcImg, $oWatermarkImg, $dest_x, $dest_y, 0, 0, $watermark_width, $watermark_height); |
||
| 279 | } else { |
||
| 280 | imagecopymerge($oSrcImg, $oWatermarkImg, $dest_x, $dest_y, 0, 0, $watermark_width, $watermark_height, $transparency); |
||
| 281 | } |
||
| 282 | |||
| 283 | switch ($srcImgInfo['mime']) { |
||
| 284 | case 'image/gif': |
||
| 285 | imagegif($oSrcImg, $src); |
||
| 286 | break; |
||
| 287 | case 'image/jpeg': |
||
| 288 | imagejpeg($oSrcImg, $src, $quality); |
||
| 289 | break; |
||
| 290 | case 'image/png': |
||
| 291 | if (function_exists('imagesavealpha') && function_exists('imagealphablending')) { |
||
| 292 | imagealphablending($oSrcImg, false); |
||
| 293 | imagesavealpha($oSrcImg, true); |
||
| 294 | } |
||
| 295 | imagepng($oSrcImg, $src); |
||
| 296 | break; |
||
| 297 | case 'image/wbmp': |
||
| 298 | imagewbmp($oSrcImg, $src); |
||
| 299 | break; |
||
| 300 | } |
||
| 301 | |||
| 302 | imagedestroy($oSrcImg); |
||
| 303 | imagedestroy($oWatermarkImg); |
||
| 304 | |||
| 305 | return true; |
||
| 306 | } |
||
| 307 | } |
||
| 308 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.