Recca0120\Generator\Console\RepositoryMakeCommand

Complexity

Total Complexity

14

Size/Duplication

Total Lines	150
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

98%

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getStub()	0	4	1
A	getDefaultNamespace()	0	4	1
B	buildClass()	0	31	6
A	renderServiceProvider()	0	11	1
A	getPath()	0	4	1
A	parseModel()	0	14	3
A	getOptions()	0	8	1

<?php

namespace Recca0120\Generator\Console;

use Illuminate\Support\Str;
use InvalidArgumentException;
use Symfony\Component\Console\Input\InputOption;

class RepositoryMakeCommand extends GeneratorCommand
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'g:repository';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Create a new repository class';

    /**
     * The type of class being generated.
     *
     * @var string
     */
    protected $type = 'Repository';

    /**
     * Get the stub file for the generator.
     *
     * @return string
     */
    protected function getStub()
    {
        return __DIR__.'/../../resources/stubs/Repositories/Repository.stub';
    }

    /**
     * Get the default namespace for the class.
     *
     * @param string $rootNamespace
     *
     * @return string
     */
    protected function getDefaultNamespace($rootNamespace)
    {
        return $rootNamespace.'\Repositories';
    }

    /**
     * Build the class with the given name.
     *
     * @param string $name
     *
     * @return string
     */
    protected function buildClass($name)
    {
        $modelClass = $this->parseModel(

$modelClass is not used, you could remove the assignment.

            $this->option('model') ?: $this->rootNamespace().class_basename($name)

It seems like $this->option('model') ?: $this->rootNamespace() . class_basename($name) can also be of type array; however, Recca0120\Generator\Console\RepositoryMakeCommand::parseModel() does only seem to accept string, maybe add an additional type check?

        );

        $fullBaseClass = $this->option('extend') ?: 'Recca0120\Repository\EloquentRepository';

        $rootNamespace = trim($this->rootNamespace(), '\\');
        $namespace = $this->getNamespace($name);
        $baseClass = ltrim(str_replace($namespace, '', $name), '\\');
        $repositoryContractInterface = $namespace.'\Contracts\\'.$baseClass.'Repository';
        $modelClass = $rootNamespace.'\\'.$baseClass;

        if (interface_exists($repositoryContractInterface) === false) {
            $this->call('g:repository-contract', ['name' => $baseClass]);
        }

        if (is_null($this->option('without-generator-model')) === true && class_exists($modelClass) === false) {
            $this->call('g:model', ['name' => $baseClass]);
        }

        $render = $this->generator->setFullRepositoryClass($name.'Repository')
            ->setFullBaseClass($fullBaseClass)

It seems like $fullBaseClass defined by $this->option('extend') ?: 'Recca0120\\Repository\\EloquentRepository' on line 67 can also be of type array; however, Recca0120\Generator\Generator::setFullBaseClass() does only seem to accept string, maybe add an additional type check?

            ->setFullModelClass($modelClass)
            ->render($this->getStub());

        $this->renderServiceProvider('Providers/AppServiceProvider');

        return $render;
    }

    /**
     * renderServiceProvider.
     *
     * @param string $className
     * @return string
     */
    protected function renderServiceProvider($className)
    {
        $file = parent::getPath($className);

It seems like you call parent on a different method (getPath() instead of renderServiceProvider()). Are you sure this is correct? If so, you might want to change this to $this->getPath().

        $this->files->put(
            $file,
            $this->generator->renderServiceProvider(
                $this->files->get($file)
            )
        );
    }

    /**
     * Get the destination class path.
     *
     * @param string $name
     *
     * @return string
     */
    protected function getPath($name)
    {
        return str_replace('.php', 'Repository.php', parent::getPath($name));
    }

    /**
     * Get the fully-qualified model class name.
     *
     * @param string $model
     *
     * @return string
     */
    protected function parseModel($model)
    {
        if (preg_match('([^A-Za-z0-9_/\\\\])', $model)) {
            throw new InvalidArgumentException('Model name contains invalid characters.');
        }

        $model = trim(str_replace('/', '\\', $model), '\\');

        if (! Str::startsWith($model, $rootNamespace = $this->laravel->getNamespace())) {

The method getNamespace() does not seem to exist on object<Illuminate\Contracts\Foundation\Application>.

            $model = $rootNamespace.$model;
        }

        return $model;
    }

    /**
     * Get the console command options.
     *
     * @return array
     */
    protected function getOptions()
    {
        return [
            ['model', 'm', InputOption::VALUE_OPTIONAL, 'Generate a repository for the given model.'],
            ['extend', '', InputOption::VALUE_OPTIONAL, 'repository extend.'],
            ['without-generator-model', '', InputOption::VALUE_OPTIONAL, 'don\'t generate model.'],
        ];
    }
}