Issues in Every8dMessage.php - New Issues - Inspection of "add send time" - recca0120/every8d - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( f49eeb...84602b )

by recca

created 2018-01-19 03:24 UTC

src/Every8dMessage.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Recca0120\Every8d;

class Every8dMessage
{
    /**
     * The message subject.
     *
     * @var string
     */
    public $subject = null;

    /**
     * The message content.
     *
     * @var string
     */
    public $content;

    /**
     * The message send time.
     *
     * @var string
     */
    public $sendTime;

    /**
     * Create a new message instance.
     *
     * @param string $content
     */
    public function __construct($content = '')
    {
        $this->content = $content;
    }

    /**
     * Set the message subject.
     *
     * @param string $subject
     * @return $this
     */
    public function subject($subject)
    {
        $this->subject = $subject;

        return $this;
    }

    /**
     * Set the message subject.
     *
     * @param string $content
     * @return $this
     */
    public function content($content)
    {
        $this->content = $content;

        return $this;
    }

    /**
     * Set the message send time.
     *
     * @param \Carbon\Carbon|string $sendTime
     * @return $this
     */
    public function sendTime($sendTime)
    {
        $this->sendTime = $sendTime;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        return $this;
    }

    /**
     * Create a new message instance.
     *
     * @param string $content
     * @return static
     */
    public static function create($content)
    {
        return new static($content);
    }
}


1		<?php
2
3		namespace Recca0120\Every8d;
4
5		class Every8dMessage
6		{
7		/**
8		* The message subject.
9		*
10		* @var string
11		*/
12		public $subject = null;
13
14		/**
15		* The message content.
16		*
17		* @var string
18		*/
19		public $content;
20
21		/**
22		* The message send time.
23		*
24		* @var string
25		*/
26		public $sendTime;
27
28		/**
29		* Create a new message instance.
30		*
31		* @param string $content
32		*/
33	5	public function __construct($content = '')
34		{
35	5	$this->content = $content;
36	5	}
37
38		/**
39		* Set the message subject.
40		*
41		* @param string $subject
42		* @return $this
43		*/
44	1	public function subject($subject)
45		{
46	1	$this->subject = $subject;
47
48	1	return $this;
49		}
50
51		/**
52		* Set the message subject.
53		*
54		* @param string $content
55		* @return $this
56		*/
57	1	public function content($content)
58		{
59	1	$this->content = $content;
60
61	1	return $this;
62		}
63
64		/**
65		* Set the message send time.
66		*
67		* @param \Carbon\Carbon\|string $sendTime
68		* @return $this
69		*/
70	1	public function sendTime($sendTime)
71		{
72	1	$this->sendTime = $sendTime;
		0 ignored issues – show Documentation Bug introduced 2018-01-19 03:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$sendTime` can also be of type `object<Carbon\Carbon>`. However, the property `$sendTime` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
73
74	1	return $this;
75		}
76
77		/**
78		* Create a new message instance.
79		*
80		* @param string $content
81		* @return static
82		*/
83	1	public static function create($content)
84		{
85	1	return new static($content);
86		}
87		}
88

recca0120 / every8d

Push — master ( f49eeb...84602b )

src/Every8dMessage.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like