realshadow / satis-control-panel

app/Satis/BuildCommand.php

Doc Comments +1 added lines, -1 removed lines

@@ -104,7 +104,7 @@
 
     /**
      * @param CommandContextInterface $commandContext
-     * @return mixed
+     * @return integer|null
      */
     protected function exec(CommandContextInterface $commandContext) {
         $commandChunks = $this->compile($commandContext);

Spacing +18 added lines, -18 removed lines

@@ -54,21 +54,21 @@ 
      * @return Collection
      */
     protected function compile(CommandContextInterface $commandContext) {
-        $this->logFile = storage_path('logs/async/' . (string) round(microtime(true) * 1000) .
-            mt_rand(1, 10000) . '.log');
+        $this->logFile = storage_path('logs/async/'.(string) round(microtime(true) * 1000).
+            mt_rand(1, 10000).'.log');
 
         $memoryLimit = config('satis.memory_limit');
         $buildVerbosity = config('satis.build_verbosity');
 
         $chunks = new Collection([
-            'php' . ($memoryLimit !== null ? ' -dmemory_limit=' . $memoryLimit : ''),
+            'php'.($memoryLimit !== null ? ' -dmemory_limit='.$memoryLimit : ''),
             sprintf($this->executable, DIRECTORY_SEPARATOR),
-            $this->command . ($buildVerbosity !== null ? ' -' . $buildVerbosity : ''),
+            $this->command.($buildVerbosity !== null ? ' -'.$buildVerbosity : ''),
             $this->configPath,
             $this->buildDirectory
         ]);
 
-        if($this->item !== null) {
+        if ($this->item !== null) {
             $chunks->push($this->item);
         }
 
@@ -82,10 +82,10 @@ 
             $chunks->push($commandContext->getSendMailOnError($email, $message));
         }
 
-        foreach(['http', 'https'] as $protocol) {
+        foreach (['http', 'https'] as $protocol) {
             $proxy = $this->proxySettings->get($protocol);
-            if($proxy !== null) {
-                $chunks->prepend(strtoupper($protocol) . '_PROXY=' . $proxy);
+            if ($proxy !== null) {
+                $chunks->prepend(strtoupper($protocol).'_PROXY='.$proxy);
             }
         }
 
@@ -119,7 +119,7 @@ 
         $logger = $commandContext->getLogger();
 
         $logger->info(str_repeat('=', 30));
-        $logger->info('Running command => ' . PHP_EOL . $commandChunks->implode(' '));
+        $logger->info('Running command => '.PHP_EOL.$commandChunks->implode(' '));
 
         chdir($this->directory);
 
@@ -127,10 +127,10 @@ 
 
         chdir($this->currentDirectory);
 
-        if($commandContext instanceof SyncCommand) {
-            $logger->info('Command output => ' . implode(PHP_EOL, $output));
+        if ($commandContext instanceof SyncCommand) {
+            $logger->info('Command output => '.implode(PHP_EOL, $output));
         } else {
-            $logger->notice('Command output can be found in "' . $this->logFile . '".');
+            $logger->notice('Command output can be found in "'.$this->logFile.'".');
         }
 
         $this->setCommandOutput($output);
@@ -176,12 +176,12 @@ 
      * @param string $item
      */
     public function setItem($item) {
-        if($item === null) {
+        if ($item === null) {
             return;
         }
 
-        if(preg_match(Repository::REGEX, $item)) {
-            $this->item = '--repository-url ' . escapeshellarg($item);
+        if (preg_match(Repository::REGEX, $item)) {
+            $this->item = '--repository-url '.escapeshellarg($item);
         } else {
             $this->item = escapeshellarg($item);
         }
@@ -216,8 +216,8 @@ 
     public function run($asyncMode = true) {
         # -- force sync
         #if(true) {
-        if($asyncMode === false || $this->isWindows() === true) {
-            if($this->isWindows() === true) {
+        if ($asyncMode === false || $this->isWindows() === true) {
+            if ($this->isWindows() === true) {
                 $this->getLogger()
                     ->warn('OS does not support async mode, forcing sync.');
             }
@@ -239,7 +239,7 @@ 
 
         $result = $this->exec(new SyncCommand());
 
-        if($result !== 0) {
+        if ($result !== 0) {
             throw new PackageBuildFailedException('Package build failed. Check build log for details.');
         }
 

app/Satis/ConfigManager.php

Doc Comments +2 added lines, -2 removed lines

@@ -121,7 +121,7 @@ 
      * @param \App\Satis\Collections\PackageCollection $packageCollection
      * @param string $packageId
      * @param \Illuminate\Support\Collection $input
-     * @return \App\Satis\Collections\RepositoryCollection
+     * @return PackageCollection
      * @throws \App\Satis\Exceptions\PackageNotFoundException
      */
     protected function _addOrUpdatePackage(PackageCollection $packageCollection, $packageId,
@@ -179,7 +179,7 @@ 
     /**
      * @param \App\Satis\Collections\PackageCollection $packageCollection
      * @param string $packageId
-     * @return \App\Satis\Collections\RepositoryCollection
+     * @return PackageCollection
      * @throws \App\Satis\Exceptions\RepositoryNotFoundException
      */
     protected function _deletePackage(PackageCollection $packageCollection, $packageId) {

Spacing +31 added lines, -31 removed lines

@@ -89,19 +89,19 @@ 
         $repository->setUrl($input->get('url'));
         $repository->setType($input->get('type', config('satis.default_repository_type')));
 
-        if($input->has('async_mode')) {
+        if ($input->has('async_mode')) {
             $this->configBuilder->setAsyncMode(filter_var($input->get('async_mode'), FILTER_VALIDATE_BOOLEAN));
         }
 
-        if($input->has('disable_build')) {
+        if ($input->has('disable_build')) {
             $this->setDisableBuild(filter_var($input->get('disable_build'), FILTER_VALIDATE_BOOLEAN));
         }
 
-        if($repositoryId !== null) {
-            if($repositoryCollection->has($repositoryId)) {
+        if ($repositoryId !== null) {
+            if ($repositoryCollection->has($repositoryId)) {
                 $repositoryCollection->put($repositoryId, $repository);
             } else {
-                throw new RepositoryNotFoundException('Repository with ID "' . $repositoryId . '" does not exist.');
+                throw new RepositoryNotFoundException('Repository with ID "'.$repositoryId.'" does not exist.');
             }
         } else {
             $repositoryId = static::nameToId($repository->getUrl());
@@ -130,19 +130,19 @@ 
         $package = new Package();
         $package->setName($input->get('name'));
 
-        if($input->has('async_mode')) {
+        if ($input->has('async_mode')) {
             $this->configBuilder->setAsyncMode(filter_var($input->get('async_mode'), FILTER_VALIDATE_BOOLEAN));
         }
 
-        if($input->has('disable_build')) {
+        if ($input->has('disable_build')) {
             $this->setDisableBuild(filter_var($input->get('disable_build'), FILTER_VALIDATE_BOOLEAN));
         }
 
-        if($packageId !== null) {
-            if($packageCollection->has($packageId)) {
+        if ($packageId !== null) {
+            if ($packageCollection->has($packageId)) {
                 $packageCollection->put($packageId, $package);
             } else {
-                throw new PackageNotFoundException('Package with ID "' . $packageId . '" does not exist.');
+                throw new PackageNotFoundException('Package with ID "'.$packageId.'" does not exist.');
             }
         } else {
             $packageId = static::nameToId($package->getName());
@@ -165,10 +165,10 @@ 
      * @throws \App\Satis\Exceptions\RepositoryNotFoundException
      */
     protected function _deleteRepository(RepositoryCollection $repositoryCollection, $repositoryId) {
-        if($repositoryCollection->has($repositoryId)) {
+        if ($repositoryCollection->has($repositoryId)) {
             $repositoryCollection->forget($repositoryId);
         } else {
-            throw new RepositoryNotFoundException('Repository with ID "' . $repositoryId . '" does not exist.');
+            throw new RepositoryNotFoundException('Repository with ID "'.$repositoryId.'" does not exist.');
         }
 
         $this->setDisableBuild(true);
@@ -183,10 +183,10 @@ 
      * @throws \App\Satis\Exceptions\RepositoryNotFoundException
      */
     protected function _deletePackage(PackageCollection $packageCollection, $packageId) {
-        if($packageCollection->has($packageId)) {
+        if ($packageCollection->has($packageId)) {
             $packageCollection->forget($packageId);
         } else {
-            throw new RepositoryNotFoundException('Package with ID "' . $packageId . '" does not exist.');
+            throw new RepositoryNotFoundException('Package with ID "'.$packageId.'" does not exist.');
         }
 
         $this->setDisableBuild(true);
@@ -224,32 +224,32 @@ 
      * @throws \Exception
      */
     public function __call($method, array $arguments) {
-        $method = $this->hiddenEntityPrefix . $method;
+        $method = $this->hiddenEntityPrefix.$method;
 
-        if(method_exists($this, $method)) {
+        if (method_exists($this, $method)) {
             $logger = $this->getLogger();
 
             $logger->info(str_repeat('=', 30));
-            $logger->info('Request => ' . \Request::method() . ' (' . $method .') => '. json_encode($arguments));
+            $logger->info('Request => '.\Request::method().' ('.$method.') => '.json_encode($arguments));
 
             $type = str_plural(last(explode('_', snake_case($method))), 2);
 
-            array_unshift($arguments, $this->satis->{'get' . ucfirst($type)}());
+            array_unshift($arguments, $this->satis->{'get'.ucfirst($type)}());
 
             try {
                 $items = call_user_func_array([$this, $method], $arguments);
-            } catch(\Exception $e) {
-                $logger->info('Response => ' . $e->getMessage());
+            } catch (\Exception $e) {
+                $logger->info('Response => '.$e->getMessage());
                 $logger->info(str_repeat('=', 30));
 
                 throw $e;
             }
 
-            $this->satis->{'set' . $type}($items);
+            $this->satis->{'set'.$type}($items);
 
             return $this->save();
         } else {
-            throw new BadMethodCallException('Called method "' . $method . '" does not exist.');
+            throw new BadMethodCallException('Called method "'.$method.'" does not exist.');
         }
     }
 
@@ -260,7 +260,7 @@ 
     public function __get($property) {
         $property = $this->hiddenEntityPrefix.$property;
 
-        if(isset($this->lazyLoadedProperties[$property])) {
+        if (isset($this->lazyLoadedProperties[$property])) {
             $this->{$property} = $this->{$this->lazyLoadedProperties[$property]}();
             
             unset($this->lazyLoadedProperties[$property]);
@@ -287,9 +287,9 @@ 
     public function getRepositories($repositoryId = null) {
         $repositoryCollection = $this->satis->getRepositories();
 
-        if($repositoryId !== null) {
-            if(!$repositoryCollection->has($repositoryId)) {
-                throw new RepositoryNotFoundException('Repository with ID "' . $repositoryId . '" does not exist.');
+        if ($repositoryId !== null) {
+            if (!$repositoryCollection->has($repositoryId)) {
+                throw new RepositoryNotFoundException('Repository with ID "'.$repositoryId.'" does not exist.');
             }
 
             $output = $repositoryCollection->get($repositoryId);
@@ -308,9 +308,9 @@ 
     public function getPackages($packageId = null) {
         $packageCollection = $this->satis->getPackages();
 
-        if($packageId !== null) {
-            if(!$packageCollection->has($packageId)) {
-                throw new PackageNotFoundException('Package with ID "' . $packageId . '" does not exist.');
+        if ($packageId !== null) {
+            if (!$packageCollection->has($packageId)) {
+                throw new PackageNotFoundException('Package with ID "'.$packageId.'" does not exist.');
             }
 
             $output = $packageCollection->get($packageId);
@@ -325,7 +325,7 @@ 
      * @param \App\Satis\BuildContext $buildContext
      */
     public function forceBuild(BuildContext $buildContext) {
-        if($buildContext->getItemName() !== null) {
+        if ($buildContext->getItemName() !== null) {
             $buildContext->setItemId(self::nameToId($buildContext->getItemName()));
         }
 
@@ -356,7 +356,7 @@ 
 
         $this->configPersister->updateWith($satisConfig);
 
-        if($this->disableBuild === false) {
+        if ($this->disableBuild === false) {
             return $this->configBuilder->build();
         }
 

app/Exceptions/Handler.php

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
     {
         if ($e instanceof ModelNotFoundException) {
             $e = new NotFoundHttpException($e->getMessage(), $e);
-        } elseif($e instanceof HttpException && \App::isLocal() === false) {
+        } elseif ($e instanceof HttpException && \App::isLocal() === false) {
             Response::json(['result' => false, 'message' => $e->getMessage()])
                 ->setStatusCode($e->getStatusCode())
                 ->send();

app/Http/Controllers/Api/PackageController.php

Spacing +7 added lines, -7 removed lines

@@ -34,7 +34,7 @@ 
             ]
         );
 
-        if($validator->fails()) {
+        if ($validator->fails()) {
             Response::json($validator->errors()->first('name'))
                 ->setStatusCode(400)
                 ->send();
@@ -44,11 +44,11 @@ 
 
                 Response::json(['command_output' => $output])
                     ->send();
-            } catch(PackageBuildFailedException $e) {
+            } catch (PackageBuildFailedException $e) {
                 Response::json()
                     ->setStatusCode(500)
                     ->send();
-            } catch(RepositoryNotFoundException $e) {
+            } catch (RepositoryNotFoundException $e) {
                 Response::json()
                     ->setStatusCode(404)
                     ->send();
@@ -66,11 +66,11 @@ 
 
             Response::make($repositories)
               ->send();
-        } catch(RepositoryNotFoundException $e) {
+        } catch (RepositoryNotFoundException $e) {
             Response::json()
                 ->setStatusCode(404)
                 ->send();
-        } catch(PackageBuildFailedException $e) {
+        } catch (PackageBuildFailedException $e) {
             Response::json($e->getMessage())
                 ->setStatusCode(500)
                 ->send();
@@ -108,11 +108,11 @@ 
 
             Response::json()
                 ->send();
-        } catch(RepositoryNotFoundException $e) {
+        } catch (RepositoryNotFoundException $e) {
             Response::json()
                 ->setStatusCode(404)
                 ->send();
-        } catch(PackageBuildFailedException $e) {
+        } catch (PackageBuildFailedException $e) {
             Response::json($e->getMessage())
                 ->setStatusCode(500)
                 ->send();

app/Http/Controllers/Api/RepositoryController.php

Spacing +7 added lines, -7 removed lines

@@ -34,7 +34,7 @@ 
             ]
         );
 
-        if($validator->fails()) {
+        if ($validator->fails()) {
             Response::json($validator->errors()->first('url'))
                 ->setStatusCode(400)
                 ->send();
@@ -44,11 +44,11 @@ 
 
                 Response::json(['command_output' => $output])
                     ->send();
-            } catch(PackageBuildFailedException $e) {
+            } catch (PackageBuildFailedException $e) {
                 Response::json()
                     ->setStatusCode(500)
                     ->send();
-            } catch(RepositoryNotFoundException $e) {
+            } catch (RepositoryNotFoundException $e) {
                 Response::json()
                     ->setStatusCode(404)
                     ->send();
@@ -66,11 +66,11 @@ 
 
             Response::make($repositories)
               ->send();
-        } catch(RepositoryNotFoundException $e) {
+        } catch (RepositoryNotFoundException $e) {
             Response::json()
                 ->setStatusCode(404)
                 ->send();
-        } catch(PackageBuildFailedException $e) {
+        } catch (PackageBuildFailedException $e) {
             Response::json($e->getMessage())
                 ->setStatusCode(500)
                 ->send();
@@ -108,11 +108,11 @@ 
 
             Response::json()
                 ->send();
-        } catch(RepositoryNotFoundException $e) {
+        } catch (RepositoryNotFoundException $e) {
             Response::json()
                 ->setStatusCode(404)
                 ->send();
-        } catch(PackageBuildFailedException $e) {
+        } catch (PackageBuildFailedException $e) {
             Response::json($e->getMessage())
                 ->setStatusCode(500)
                 ->send();

app/Providers/RouteServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
      */
     public function map(Router $router)
     {
-        $router->group(['namespace' => $this->namespace], function ($router) {
+        $router->group(['namespace' => $this->namespace], function($router) {
             require app_path('Http/routes.php');
         });
     }

app/Satis/Collections/PackageCollection.php

Spacing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
      * @return $this
      */
     public function put($key, $value) {
-        if(!$value instanceof Package) {
+        if (!$value instanceof Package) {
             throw new InvalidArgumentException('PackageCollection accepts only elements of "Package" type.');
         }
 

app/Satis/Collections/RepositoryCollection.php

Spacing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
      * @return $this
      */
     public function put($key, $value) {
-        if(!$value instanceof Repository) {
+        if (!$value instanceof Repository) {
             throw new InvalidArgumentException('RepositoryCollection accepts only elements of "Repository" type.');
         }
 

app/Satis/ConfigPersister.php

Spacing +3 added lines, -3 removed lines

@@ -26,7 +26,7 @@ 
      * @throws \Illuminate\Contracts\Filesystem\FileNotFoundException
      */
     protected function getLockFile() {
-        if($this->filesystem->exists($this->lockFilename)) {
+        if ($this->filesystem->exists($this->lockFilename)) {
             $configLock = $this->serializer->deserialize(
                 $this->filesystem->get($this->lockFilename),
                 'App\Satis\Model\ConfigLock',
@@ -78,7 +78,7 @@ 
     public function lock($repositoryId) {
         $lockedRepositories = $this->getLockedRepositories();
 
-        if(!is_null($repositoryId) && !$lockedRepositories->contains($repositoryId)) {
+        if (!is_null($repositoryId) && !$lockedRepositories->contains($repositoryId)) {
             $lockedRepositories->push($repositoryId);
         }
 
@@ -99,7 +99,7 @@ 
     public function unlock($repositoryId = null) {
         $lockedRepositories = $this->getLockedRepositories();
 
-        if($repositoryId !== null && $lockedRepositories->contains($repositoryId)) {
+        if ($repositoryId !== null && $lockedRepositories->contains($repositoryId)) {
             $lockedRepositories = $lockedRepositories->filter(function($id) use($repositoryId) {
                 return $id !== $repositoryId;
             });