reallyli / laravel-ab-test

src/Commands/ExportCommand.php

<?php

namespace Reallyli\AB\Commands;

use League\Csv\Writer;
use SplTempFileObject;
use Reallyli\AB\Models\Goal;
use Illuminate\Console\Command;
use Reallyli\AB\Models\Experiment;
use Illuminate\Support\Facades\File;
use Symfony\Component\Console\Input\InputArgument;

class ExportCommand extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'ab:export';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Export the A/B testing repor to a CSV file.';

    /**
     * Create a new command instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $experiments = Experiment::active()->get();

The method active() does not exist on Reallyli\AB\Models\Experiment. Did you maybe mean scopeActive()?

        $goals = array_unique(Goal::active()->orderBy('name')->pluck('name')->toArray());

The method active() does not exist on Reallyli\AB\Models\Goal. Did you maybe mean scopeActive()?

        $columns = array_merge(['Experiment', 'Visitors', 'Engagement'], array_map('ucfirst', $goals));

        $writer = new Writer(new SplTempFileObject);
        $writer->insertOne($columns);

        foreach ($experiments as $experiment) {

This code seems to be duplicated across your project.

            $engagement = $experiment->visitors ? ($experiment->engagement / $experiment->visitors * 100) : 0;

            $row = [
                $experiment->name,
                $experiment->visitors,
                number_format($engagement, 2).' % ('.$experiment->engagement.')',
            ];

            $results = $experiment->goals()->pluck('count', 'name');

            foreach ($goals as $column) {
                $count = array_get($results, $column, 0);
                $percentage = $experiment->visitors ? ($count / $experiment->visitors * 100) : 0;

                $row[] = number_format($percentage, 2)." % ($count)";
            }

            $writer->insertOne($row);
        }

        $output = (string) $writer;

        if ($file = $this->argument('file')) {
            $this->info("Creating $file");

            File::put($file, $output);

It seems like $file defined by $this->argument('file') on line 77 can also be of type array; however, Illuminate\Support\Facades\File::put() does only seem to accept string, maybe add an additional type check?

        } else {
            $this->line($output);
        }
    }

    /**
     * Get the console command arguments.
     *
     * @return array
     */
    protected function getArguments()
    {
        return [
            ['file', InputArgument::OPTIONAL, 'The target CSV file to write the output to.'],
        ];
    }

    /**
     * Get the console command options.
     *
     * @return array
     */
    protected function getOptions()
    {
        return [];
    }
}