InstallCommand::handle() - Code Metrics - reallyli/laravel-ab-test - Measure and Improve Code Quality continuously with Scrutinizer

InstallCommand::handle() B
last analyzed 2018-09-29 06:43 UTC

↳ Parent: InstallCommand

Complexity

Conditions	9
Paths	20

Size

Total Lines

Duplication

Lines	18
Ratio	35.29 %

Importance

Changes

Metric	Value
dl	18
loc	51
rs	7.5135
c	0
b	0
f	0
cc	9
nc	20
nop	0

How to fix Long Method

<?php

namespace Reallyli\AB\Commands;

use Config;
use Schema;
use Reallyli\AB\Models\Goal;
use Illuminate\Console\Command;
use Reallyli\AB\Models\Experiment;

class InstallCommand extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'ab:install';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Prepare the A/B testing database.';

    /**
     * Create a new command instance.
     *
     * @return void

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $connection = Config::get('ab::connection');

        // Create experiments table.
        if (! Schema::connection($connection)->hasTable('experiments')) {

            Schema::connection($connection)->create('experiments', function ($table) {
                $table->increments('id');
                $table->string('name');
                $table->integer('visitors')->unsigned()->default(0);
                $table->integer('engagement')->unsigned()->default(0);
                $table->timestamps();
            });
        }

        // Create goals table.
        if (! Schema::connection($connection)->hasTable('goals')) {

            Schema::connection($connection)->create('goals', function ($table) {
                $table->increments('id');
                $table->string('name');
                $table->string('experiment');
                $table->integer('count')->unsigned()->default(0);
                $table->timestamps();
            });
        }

        $this->info('Database schema initialized.');

        $experiments = Config::get('ab')['experiments'];

        if (! $experiments or empty($experiments)) {
            return $this->error('No experiments configured.');
        }

        $goals = Config::get('ab')['goals'];

        if (! $goals or empty($goals)) {
            return $this->error('No goals configured.');
        }

        // Populate experiments and goals.
        foreach ($experiments as $experiment) {
            Experiment::firstOrCreate(['name' => $experiment]);

            foreach ($goals as $goal) {
                Goal::firstOrCreate(['name' => $goal, 'experiment' => $experiment]);
            }
        }

        $this->info('Added '.count($experiments).' experiments.');
    }

    /**
     * Get the console command arguments.
     *
     * @return array
     */
    protected function getArguments()
    {
        return [];
    }

    /**
     * Get the console command options.
     *
     * @return array
     */
    protected function getOptions()
    {
        return [];
    }
}


1		<?php
2
3		namespace Reallyli\AB\Commands;
4
5		use Config;
6		use Schema;
7		use Reallyli\AB\Models\Goal;
8		use Illuminate\Console\Command;
9		use Reallyli\AB\Models\Experiment;
10
11		class InstallCommand extends Command
12		{
13		/**
14		* The console command name.
15		*
16		* @var string
17		*/
18		protected $name = 'ab:install';
19
20		/**
21		* The console command description.
22		*
23		* @var string
24		*/
25		protected $description = 'Prepare the A/B testing database.';
26
27		/**
28		* Create a new command instance.
29		*
30		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2018-09-29 06:36 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
31		*/
32		public function __construct()
33		{
34		parent::__construct();
35		}
36
37		/**
38		* Execute the console command.
39		*
40		* @return mixed
41		*/
42		public function handle()
43		{
44		$connection = Config::get('ab::connection');
45
46		// Create experiments table.
47	View Code Duplication	if (! Schema::connection($connection)->hasTable('experiments')) {
		0 ignored issues – show Duplication introduced 2018-09-29 06:36 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
48		Schema::connection($connection)->create('experiments', function ($table) {
49		$table->increments('id');
50		$table->string('name');
51		$table->integer('visitors')->unsigned()->default(0);
52		$table->integer('engagement')->unsigned()->default(0);
53		$table->timestamps();
54		});
55		}
56
57		// Create goals table.
58	View Code Duplication	if (! Schema::connection($connection)->hasTable('goals')) {
		0 ignored issues – show Duplication introduced 2018-09-29 06:36 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		Schema::connection($connection)->create('goals', function ($table) {
60		$table->increments('id');
61		$table->string('name');
62		$table->string('experiment');
63		$table->integer('count')->unsigned()->default(0);
64		$table->timestamps();
65		});
66		}
67
68		$this->info('Database schema initialized.');
69
70		$experiments = Config::get('ab')['experiments'];
71
72		if (! $experiments or empty($experiments)) {
73		return $this->error('No experiments configured.');
74		}
75
76		$goals = Config::get('ab')['goals'];
77
78		if (! $goals or empty($goals)) {
79		return $this->error('No goals configured.');
80		}
81
82		// Populate experiments and goals.
83		foreach ($experiments as $experiment) {
84		Experiment::firstOrCreate(['name' => $experiment]);
85
86		foreach ($goals as $goal) {
87		Goal::firstOrCreate(['name' => $goal, 'experiment' => $experiment]);
88		}
89		}
90
91		$this->info('Added '.count($experiments).' experiments.');
92		}
93
94		/**
95		* Get the console command arguments.
96		*
97		* @return array
98		*/
99		protected function getArguments()
100		{
101		return [];
102		}
103
104		/**
105		* Get the console command options.
106		*
107		* @return array
108		*/
109		protected function getOptions()
110		{
111		return [];
112		}
113		}
114

reallyli / laravel-ab-test

InstallCommand::handle() B last analyzed 2018-09-29 06:43 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

InstallCommand::handle() B
last analyzed 2018-09-29 06:43 UTC