Reallyli\AB\Commands\ReportCommand

Complexity

Total Complexity

8

Size/Duplication

Total Lines	85
Duplicated Lines	23.53 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	handle()	20	33	5
A	getArguments()	0	4	1
A	getOptions()	0	4	1

<?php

namespace Reallyli\AB\Commands;

use Reallyli\AB\Models\Goal;
use Illuminate\Console\Command;
use Reallyli\AB\Models\Experiment;
use Symfony\Component\Console\Helper\Table;

class ReportCommand extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'ab:report';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Print the A/B testing report.';

    /**
     * Create a new command instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $experiments = Experiment::active()->get();

The method active() does not exist on Reallyli\AB\Models\Experiment. Did you maybe mean scopeActive()?

        $goals = array_unique(Goal::active()->orderBy('name')->pluck('name')->toArray());

The method active() does not exist on Reallyli\AB\Models\Goal. Did you maybe mean scopeActive()?

        $columns = array_merge(['Experiment', 'Visitors', 'Engagement'], array_map('ucfirst', $goals));

        $table = new Table($this->output);
        $table->setHeaders($columns);

        foreach ($experiments as $experiment) {

This code seems to be duplicated across your project.

            $engagement = $experiment->visitors ? ($experiment->engagement / $experiment->visitors * 100) : 0;

            $row = [
                $experiment->name,
                $experiment->visitors,
                number_format($engagement, 2).' % ('.$experiment->engagement.')',
            ];

            $results = $experiment->goals()->pluck('count', 'name');

            foreach ($goals as $column) {
                $count = array_get($results, $column, 0);
                $percentage = $experiment->visitors ? ($count / $experiment->visitors * 100) : 0;

                $row[] = number_format($percentage, 2)." % ($count)";
            }

            $table->addRow($row);
        }

        $table->render();
    }

    /**
     * Get the console command arguments.
     *
     * @return array
     */
    protected function getArguments()
    {
        return [];
    }

    /**
     * Get the console command options.
     *
     * @return array
     */
    protected function getOptions()
    {
        return [];
    }
}