Issues in Limited.php (master) - Issues in master - reactphp-parallel/limited-pool - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Limited.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php declare(strict_types=1);

namespace ReactParallel\Pool\Limited;

use Closure;
use React\EventLoop\LoopInterface;
use React\Promise\Promise;
use React\Promise\PromiseInterface;
use ReactParallel\Contracts\ClosedException;
use ReactParallel\Contracts\GroupInterface;
use ReactParallel\Contracts\LowLevelPoolInterface;
use ReactParallel\Contracts\PoolInterface;
use ReactParallel\Pool\Infinite\Infinite;
use SplQueue;
use WyriHaximus\PoolInfo\Info;
use function count;
use function React\Promise\reject;

final class Limited implements PoolInterface
{
    private PoolInterface $pool;


    private int $threadCount;

    private int $idleRuntimes;

    private SplQueue $queue;

    private ?GroupInterface $group = null;

    private bool $closed = false;

    public static function create(LoopInterface $loop, int $threadCount): self
    {
        return new self(new Infinite($loop, 1), $threadCount);
    }

    public static function createWithPool(PoolInterface $pool, int $threadCount): self
    {
        return new self($pool, $threadCount);
    }

    private function __construct(PoolInterface $pool, int $threadCount)
    {
        $this->pool         = $pool;
        $this->threadCount  = $threadCount;
        $this->idleRuntimes = $threadCount;
        $this->queue        = new SplQueue();

        if (! ($this->pool instanceof LowLevelPoolInterface)) {
            return;
        }

        $this->group = $this->pool->acquireGroup();
    }

    /**
     * @param mixed[] $args
     */
    public function run(Closure $callable, array $args = []): PromiseInterface
    {
        if ($this->closed === true) {
            return reject(ClosedException::create());
        }

        return (new Promise(function (callable $resolve): void {
            if ($this->idleRuntimes === 0) {
                $this->queue->enqueue($resolve);

                return;
            }

            $resolve();
        }))->then(function () use ($callable, $args): PromiseInterface {
            $this->idleRuntimes--;

            /** @psalm-suppress UndefinedInterfaceMethod */
            return $this->pool->run($callable, $args)->always(function (): void {
                $this->idleRuntimes++;
                $this->progressQueue();
            });
        });
    }

    public function close(): bool
    {
        $this->closed = true;

        if ($this->pool instanceof LowLevelPoolInterface && $this->group instanceof GroupInterface) {
            $this->pool->releaseGroup($this->group);
        }

         $this->pool->close();

        return true;
    }

    public function kill(): bool
    {
        $this->closed = true;

        if ($this->pool instanceof LowLevelPoolInterface && $this->group instanceof GroupInterface) {
            $this->pool->releaseGroup($this->group);
        }

        $this->pool->kill();

        return true;
    }

    /**
     * @return iterable<string, int>
     */
    public function info(): iterable
    {
        yield Info::TOTAL => $this->threadCount;
        yield Info::BUSY => $this->threadCount - $this->idleRuntimes;
        yield Info::CALLS => $this->queue->count();
        yield Info::IDLE  => $this->idleRuntimes;
        yield Info::SIZE  => $this->threadCount;
    }

    private function progressQueue(): void
    {
        if (count($this->queue) === 0) {
            return;
        }

        ($this->queue->dequeue())();
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ReactParallel\Pool\Limited;
4
5			use Closure;
6			use React\EventLoop\LoopInterface;
7			use React\Promise\Promise;
8			use React\Promise\PromiseInterface;
9			use ReactParallel\Contracts\ClosedException;
10			use ReactParallel\Contracts\GroupInterface;
11			use ReactParallel\Contracts\LowLevelPoolInterface;
12			use ReactParallel\Contracts\PoolInterface;
13			use ReactParallel\Pool\Infinite\Infinite;
14			use SplQueue;
15			use WyriHaximus\PoolInfo\Info;
16			use function count;
17			use function React\Promise\reject;
18
19			final class Limited implements PoolInterface
20			{
21			private PoolInterface $pool;
			0 ignored issues – show Bug introduced 2020-02-29 22:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING, expecting T_FUNCTION or T_CONST Loading history...
22
23			private int $threadCount;
24
25			private int $idleRuntimes;
26
27			private SplQueue $queue;
28
29			private ?GroupInterface $group = null;
30
31			private bool $closed = false;
32
33			public static function create(LoopInterface $loop, int $threadCount): self
34			{
35			return new self(new Infinite($loop, 1), $threadCount);
36			}
37
38			public static function createWithPool(PoolInterface $pool, int $threadCount): self
39			{
40			return new self($pool, $threadCount);
41			}
42
43			private function __construct(PoolInterface $pool, int $threadCount)
44			{
45			$this->pool = $pool;
46			$this->threadCount = $threadCount;
47			$this->idleRuntimes = $threadCount;
48			$this->queue = new SplQueue();
49
50			if (! ($this->pool instanceof LowLevelPoolInterface)) {
51			return;
52			}
53
54			$this->group = $this->pool->acquireGroup();
55			}
56
57			/**
58			* @param mixed[] $args
59			*/
60			public function run(Closure $callable, array $args = []): PromiseInterface
61			{
62			if ($this->closed === true) {
63			return reject(ClosedException::create());
64			}
65
66			return (new Promise(function (callable $resolve): void {
67			if ($this->idleRuntimes === 0) {
68			$this->queue->enqueue($resolve);
69
70			return;
71			}
72
73			$resolve();
74			}))->then(function () use ($callable, $args): PromiseInterface {
75			$this->idleRuntimes--;
76
77			/** @psalm-suppress UndefinedInterfaceMethod */
78			return $this->pool->run($callable, $args)->always(function (): void {
79			$this->idleRuntimes++;
80			$this->progressQueue();
81			});
82			});
83			}
84
85			public function close(): bool
86			{
87			$this->closed = true;
88
89			if ($this->pool instanceof LowLevelPoolInterface && $this->group instanceof GroupInterface) {
90			$this->pool->releaseGroup($this->group);
91			}
92
93			$this->pool->close();
94
95			return true;
96			}
97
98			public function kill(): bool
99			{
100			$this->closed = true;
101
102			if ($this->pool instanceof LowLevelPoolInterface && $this->group instanceof GroupInterface) {
103			$this->pool->releaseGroup($this->group);
104			}
105
106			$this->pool->kill();
107
108			return true;
109			}
110
111			/**
112			* @return iterable<string, int>
113			*/
114			public function info(): iterable
115			{
116			yield Info::TOTAL => $this->threadCount;
117			yield Info::BUSY => $this->threadCount - $this->idleRuntimes;
118			yield Info::CALLS => $this->queue->count();
119			yield Info::IDLE => $this->idleRuntimes;
120			yield Info::SIZE => $this->threadCount;
121			}
122
123			private function progressQueue(): void
124			{
125			if (count($this->queue) === 0) {
126			return;
127			}
128
129			($this->queue->dequeue())();
130			}
131			}
132

GitHub Access Token became invalid

Issues (1)

Security Analysis no request data

src/Limited.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

reactphp-parallel / limited-pool

GitHub Access Token became invalid

Issues (1)

Security Analysis no request data

src/Limited.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like