rdorado / site-analyzer

src/CategoricalDataset.php

<?php
/**
 *
 * (c) Ruben Dorado <ruben.dorados@google.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace SiteAnalyzer;
/**
 * class CategoricalDataset
 *
 * @package   SiteAnalyzer
 * @author    Ruben Dorado <ruben.dorados@gmail.com>
 * @copyright 2018 Ruben Dorado
 * @license   http://www.opensource.org/licenses/MIT The MIT License
 */
class CategoricalDataset
{
    
    /*
     * @param
     */        
    function __construct($data) 

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->data = $data;

The property data does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }
    
    /*
     * @param
     */    
    function setEncodedFeatures($array) 

It is generally recommended to explicitly declare the visibility for methods.

    {
        $array = sort($array);
        $this->encodedValues = [];

The property encodedValues does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->sortedEncodedFeatures = $array;

The property sortedEncodedFeatures does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->newEncodedSize = count($array);

$array of type boolean is incompatible with the type Countable|array expected by parameter $var of count().

The property newEncodedSize does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        foreach($this->sortedEncodedFeatures as $col){
            $vals = $this->getUniqueValues($col);
            $this->encodedValues[] = $vals;
            $this->featIndexMap[$col] = count($vals);

The property featIndexMap does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->featEncode[$col] = $this->encodeFeature(count($vals));

The property featEncode does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            //$this->featDecode[$col] = function($val, $arr){ return $this->getDecodedFeature($val, $arr, ); }
            //$this->newEncodedSize += count($vals)-1;
        }
        
        /*for ($i=0;$i<$this->newEncodedSize:$i++) {
            
        }*/
    }   
    
    /*
     * @param
     */
    function getUniqueValues($col) 

It is generally recommended to explicitly declare the visibility for methods.

    {
        $resp = [];
        $resp = Matrix::getColumn($data, $col);

The variable $data seems to be never defined.

        $resp = array_unique($resp);
        return $resp;
    }
    
    
    /*
     * @param
     */
    function encodeFeature($size) 

It is generally recommended to explicitly declare the visibility for methods.

    {
        $resp = [];
        for ($i=0;$i<$size;$i++) {
            $tmp = array_fill(0, $size, 0);
            $tmp[$i] = 1;  
            $resp[] = $tmp;
        }
        return $resp;
    }
    
    /*
     * @param
     */  
    function encode(){

It is generally recommended to explicitly declare the visibility for methods.

        $transformer  = [];
        $ndata = [];

The assignment to $ndata is dead and can be removed.

        for ($j=0; $j<$ndim; $j++) {

The variable $ndim seems to be never defined.

            $transformer[] = function($val){ return [$val]; };
        }
        foreach($this->sortedEncodedFeatures as $col) {
            $transformer[$col] = function($val) { return $this->featEncode[$col][$val]; };
        }
        $ndata = [];
        for ($i=0; $i<$npoints; $i++) {

The variable $npoints does not exist. Did you maybe mean $npoint?

            $npoint = [];
            for ($j=0; $j<$ndim; $j++) {
                $npoint += $transformer[$j]($data[$i][$j]);
            }
            $ndata[] = $npoint;
        }
        return $ndata;
    }
    
    /*
     * @param
     *
    function decode($ndata){
        $resp = [];
        foreach ($ndata as $row) {             
            $resp[] = $this->decodeRow($row);
        }
        return $resp;
    }

    /*
     * @param
     *     
    function decodeRow($row){
        $resp = [];
        $n = count($row);
        for ($i=0; $i<$n; $i++) {
            $resp[] = $this->decodeFeature($i, $row);
        }
        return $resp;
    }*/
    
}