DeleteAction::delete() - Code Metrics - Inspection of "Enable transaction in create/update/delete action" - razonyang/yii2-app-template - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d54c31...1808a2 )

by Razon

created 2019-08-23 04:08 UTC

DeleteAction::delete() A

↳ Parent: DeleteAction

Complexity

Conditions	3
Paths	4

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	6
c	0
b	0
f	0
dl	0
loc	13
rs	10
cc	3
nc	4
nop	1

<?php
namespace App\Http\Rest;

use App\Model\SoftDeleteInterface;
use Yii;
use yii\db\ActiveRecord;
use yii\rest\DeleteAction as Action;

class DeleteAction extends Action
{
    use SafeActionTrait {
        run as safeRun;
    }

    public function run($id)
    {
        return $this->safeRun($id, [$this, 'delete']);
    }

    public function delete($id)
    {
        $model = $this->findModel($id);

        if ($this->checkAccess) {
            call_user_func($this->checkAccess, $this->id, $model);
        }

        if ($this->deleteModel($model) === false) {

            throw new ServerErrorHttpException('Failed to delete the object for unknown reason.');
filter:
    dependency_paths: ["lib/*"]
        }

        Yii::$app->getResponse()->setStatusCode(204);
    }
    
    /**
     * @param ActiveRecord $model
     * @return int|false
     */
    private function deleteModel($model)
    {
        if ($model instanceof SoftDeleteInterface) {
            return $model->softDelete();
        }

        return $model->delete();
    }
}


1			<?php
2			namespace App\Http\Rest;
3
4			use App\Model\SoftDeleteInterface;
5			use Yii;
6			use yii\db\ActiveRecord;
7			use yii\rest\DeleteAction as Action;
8
9			class DeleteAction extends Action
10			{
11			use SafeActionTrait {
12			run as safeRun;
13			}
14
15			public function run($id)
16			{
17			return $this->safeRun($id, [$this, 'delete']);
18			}
19
20			public function delete($id)
21			{
22			$model = $this->findModel($id);
23
24			if ($this->checkAccess) {
25			call_user_func($this->checkAccess, $this->id, $model);
26			}
27
28			if ($this->deleteModel($model) === false) {
			0 ignored issues – show introduced 2019-08-06 07:06 UTC by Report Bug Copy Issue Report The condition `$this->deleteModel($model) === false` is always `false`. Loading history...
29			throw new ServerErrorHttpException('Failed to delete the object for unknown reason.');
			0 ignored issues – show Bug introduced 2019-08-06 07:06 UTC by Report Bug Copy Issue Report The type `App\Http\Rest\ServerErrorHttpException` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
30			}
31
32			Yii::$app->getResponse()->setStatusCode(204);
33			}
34
35			/**
36			* @param ActiveRecord $model
37			* @return int\|false
38			*/
39			private function deleteModel($model)
40			{
41			if ($model instanceof SoftDeleteInterface) {
42			return $model->softDelete();
43			}
44
45			return $model->delete();
46			}
47			}
48

razonyang / yii2-app-template

Push — master ( d54c31...1808a2 )

DeleteAction::delete() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like