m190725_110548_setting_init::safeUp() - Code Metrics - Inspection of "Remove mailer settings" - razonyang/yii2-app-template - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0ae00e...2c9684 )

by Razon

created 2019-08-21 05:55 UTC

m190725_110548_setting_init::safeUp() A

↳ Parent: m190725_110548_setting_init

Complexity

Conditions	2
Paths	2

Size

Total Lines	70
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	45
c	2
b	0
f	0
dl	0
loc	70
rs	9.2
cc	2
nc	2
nop	0

How to fix Long Method

<?php
use App\Db\Migration;
use function GuzzleHttp\json_encode;

/**
 * Class m190725_110548_setting_init
 */
class m190725_110548_setting_init extends Migration
{
    private $tableName = '{{%setting}}';
    
    public function safeUp()
    {
        $now = time();
        $columns = ['id', 'description', 'value', 'rules', 'create_time', 'update_time'];
        $items = [
            [
                'id' => 'upload.image.directory',
                'description' => 'Image Directory',
                'value' => 'images',
                'rules' => [
                    ['required'],
                ],
            ],
            [
                'id' => 'upload.image.maxSize',
                'description' => 'Image Maximum Size(bytes)',
                'value' => 1024 * 1024,
                'rules' => [
                    ['required'],
                    ['number'],
                ],
            ],
            [
                'id' => 'upload.image.extensions',
                'description' => 'Image Extensions',
                'value' => 'gif,jpeg,jpg,png',
                'rules' => [
                    ['required'],
                ],
            ],

            [
                'id' => 'upload.video.directory',
                'description' => 'Video Directory',
                'value' => 'videos',
                'rules' => [
                    ['required'],
                ],
            ],
            [
                'id' => 'upload.video.maxSize',
                'description' => 'Video Maximum Size(bytes)',
                'value' => 10 * 1024 * 1024,
                'rules' => [
                    ['required'],
                    ['number'],
                ],
            ],
            [
                'id' => 'upload.video.extensions',
                'description' => 'Video Extensions',
                'value' => 'mp4',
                'rules' => [
                    ['required'],
                ],
            ],
        ];

        $rows = [];
        foreach ($items as $item) {
            $rows[] = [
                $item['id'],
                $item['description'],
                $item['value'],
                json_encode($item['rules'] ?? []),
                $now,
                $now
            ];
        }
        $this->batchInsert($this->tableName, $columns, $rows);
    }

    public function safeDown()
    {
        $this->delete($this->tableName);

        return true;
    }
}


1			<?php
2			use App\Db\Migration;
3			use function GuzzleHttp\json_encode;
4
5			/**
6			* Class m190725_110548_setting_init
7			*/
8			class m190725_110548_setting_init extends Migration
9			{
10			private $tableName = '{{%setting}}';
11
12			public function safeUp()
13			{
14			$now = time();
15			$columns = ['id', 'description', 'value', 'rules', 'create_time', 'update_time'];
16			$items = [
17			[
18			'id' => 'upload.image.directory',
19			'description' => 'Image Directory',
20			'value' => 'images',
21			'rules' => [
22			['required'],
23			],
24			],
25			[
26			'id' => 'upload.image.maxSize',
27			'description' => 'Image Maximum Size(bytes)',
28			'value' => 1024 * 1024,
29			'rules' => [
30			['required'],
31			['number'],
32			],
33			],
34			[
35			'id' => 'upload.image.extensions',
36			'description' => 'Image Extensions',
37			'value' => 'gif,jpeg,jpg,png',
38			'rules' => [
39			['required'],
40			],
41			],
42
43			[
44			'id' => 'upload.video.directory',
45			'description' => 'Video Directory',
46			'value' => 'videos',
47			'rules' => [
48			['required'],
49			],
50			],
51			[
52			'id' => 'upload.video.maxSize',
53			'description' => 'Video Maximum Size(bytes)',
54			'value' => 10 * 1024 * 1024,
55			'rules' => [
56			['required'],
57			['number'],
58			],
59			],
60			[
61			'id' => 'upload.video.extensions',
62			'description' => 'Video Extensions',
63			'value' => 'mp4',
64			'rules' => [
65			['required'],
66			],
67			],
68			];
69
70			$rows = [];
71			foreach ($items as $item) {
72			$rows[] = [
73			$item['id'],
74			$item['description'],
75			$item['value'],
76			json_encode($item['rules'] ?? []),
77			$now,
78			$now
79			];
80			}
81			$this->batchInsert($this->tableName, $columns, $rows);
82			}
83
84			public function safeDown()
85			{
86			$this->delete($this->tableName);
87
88			return true;
89			}
90			}
91

razonyang / yii2-app-template

Push — master ( 0ae00e...2c9684 )

m190725_110548_setting_init::safeUp() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like