ArticleController::actionIndex() - Code Metrics - Inspection of "Update article migration" - razonyang/yii2-app-template - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 61134e...d54c31 )

by Razon

created 2019-08-23 02:49 UTC

ArticleController::actionIndex() A

↳ Parent: ArticleController

Complexity

Conditions	1
Paths	1

Size

Total Lines	22
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	16
c	1
b	0
f	0
dl	0
loc	22
rs	9.7333
cc	1
nc	1
nop	0

<?php
namespace App\Http\Controller;

use App\Model\Article;
use App\Model\StatusInterface;
use yii\data\Pagination;
use yii\web\NotFoundHttpException;

class ArticleController extends Controller
{
    public function afterAction($action, $result)
    {
        if ($action->id === 'view') {
            $this->model->updateCounters([
                'views' => 1
            ]);
        }

        return parent::afterAction($action, $result);
    }

    public function actionIndex()
    {
        $query = Article::find()
            ->alias('a')
            ->joinWith('category')
            ->where([
                'a.status' => StatusInterface::STATUS_ACTIVE,
                'a.is_deleted' => 0,
            ])
            ->andWhere(['<=', 'a.release_time', time()])
            ->orderBy(['a.release_time' => SORT_DESC]);

        $count = $query->count();
        $pagination = new Pagination(['totalCount' => $count]);

        $articles = $query->offset($pagination->offset)
            ->limit($pagination->limit)
            ->all();
        
        return $this->render('index', [
            'articles' => $articles,
            'pagination' => $pagination,
        ]);
    }

    public function actionView($id)
    {
        $model = $this->findModel($id);
        
        return $this->render('view', [
            'model' => $model,
        ]);
    }

    /**
     * @var Article $model
     */
    private $model;

    private function findModel($id)
    {
        $model = Article::findOne($id);
        if (!$model) {

            throw new NotFoundHttpException('Article does not exists');
        }

        $this->model = $model;
        return $this->model;
    }
}


1			<?php
2			namespace App\Http\Controller;
3
4			use App\Model\Article;
5			use App\Model\StatusInterface;
6			use yii\data\Pagination;
7			use yii\web\NotFoundHttpException;
8
9			class ArticleController extends Controller
10			{
11			public function afterAction($action, $result)
12			{
13			if ($action->id === 'view') {
14			$this->model->updateCounters([
15			'views' => 1
16			]);
17			}
18
19			return parent::afterAction($action, $result);
20			}
21
22			public function actionIndex()
23			{
24			$query = Article::find()
25			->alias('a')
26			->joinWith('category')
27			->where([
28			'a.status' => StatusInterface::STATUS_ACTIVE,
29			'a.is_deleted' => 0,
30			])
31			->andWhere(['<=', 'a.release_time', time()])
32			->orderBy(['a.release_time' => SORT_DESC]);
33
34			$count = $query->count();
35			$pagination = new Pagination(['totalCount' => $count]);
36
37			$articles = $query->offset($pagination->offset)
38			->limit($pagination->limit)
39			->all();
40
41			return $this->render('index', [
42			'articles' => $articles,
43			'pagination' => $pagination,
44			]);
45			}
46
47			public function actionView($id)
48			{
49			$model = $this->findModel($id);
50
51			return $this->render('view', [
52			'model' => $model,
53			]);
54			}
55
56			/**
57			* @var Article $model
58			*/
59			private $model;
60
61			private function findModel($id)
62			{
63			$model = Article::findOne($id);
64			if (!$model) {
			0 ignored issues – show introduced 2019-08-22 08:43 UTC by Report Bug Copy Issue Report `$model` is of type `yii\db\ActiveRecord`, thus it always evaluated to `true`. Loading history...
65			throw new NotFoundHttpException('Article does not exists');
66			}
67
68			$this->model = $model;
69			return $this->model;
70			}
71			}
72

razonyang / yii2-app-template

Push — master ( 61134e...d54c31 )

ArticleController::actionIndex() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like