PersistentSubscriptionInfoFeed::validateLink() - Code Metrics - Inspection of "[WIP] Add competing consumers support." - rayrutjes/php-geteventstore-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Raymond

created 2016-03-07 15:48 UTC

PersistentSubscriptionInfoFeed::validateLink() A

↳ Parent: PersistentSubscriptionInfoFeed

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	5

Duplication

Lines	9
Ratio	100 %

Metric	Value
dl	9
loc	9
rs	9.6666
cc	3
eloc	5
nc	3
nop	1

<?php

namespace RayRutjes\GetEventStore\Client\Http\Feed;

use RayRutjes\GetEventStore\PersistentSubscriptionInfo;

final class PersistentSubscriptionInfoFeed
{
    /**
     * @var array
     */
    private $links = [];

    /**
     * @var PersistentSubscriptionInfo
     */
    private $info;

    /**
     * @param array                      $links
     * @param PersistentSubscriptionInfo $info
     */
    public function __construct(array $links, PersistentSubscriptionInfo $info)
    {
        foreach ($links as $link) {
            $this->validateLink($link);
            $this->links[$link->getRelation()] = $link;
        }
        $this->info = $info;
    }

    /**
     * @param $link
     */
    private function validateLink($link)

    {
        if (!$link instanceof PersistentSubscriptionInfoFeedLink) {
            throw new \InvalidArgumentException('Invalid link type %s.', get_class($link));
        }
        if (isset($this->links[$link->getRelation()])) {
            throw new \InvalidArgumentException(sprintf('Link relation %s already there.', $link->getRelation()));
        }
    }

    /**
     * @return PersistentSubscriptionInfo
     */
    public function getPersistentSubscriptionInfo(): PersistentSubscriptionInfo
    {
        return $this->info;
    }
}


1		<?php
2
3		namespace RayRutjes\GetEventStore\Client\Http\Feed;
4
5		use RayRutjes\GetEventStore\PersistentSubscriptionInfo;
6
7		final class PersistentSubscriptionInfoFeed
8		{
9		/**
10		* @var array
11		*/
12		private $links = [];
13
14		/**
15		* @var PersistentSubscriptionInfo
16		*/
17		private $info;
18
19		/**
20		* @param array $links
21		* @param PersistentSubscriptionInfo $info
22		*/
23		public function __construct(array $links, PersistentSubscriptionInfo $info)
24		{
25		foreach ($links as $link) {
26		$this->validateLink($link);
27		$this->links[$link->getRelation()] = $link;
28		}
29		$this->info = $info;
30		}
31
32		/**
33		* @param $link
34		*/
35	View Code Duplication	private function validateLink($link)
		0 ignored issues – show Duplication introduced 2016-03-07 15:51 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		if (!$link instanceof PersistentSubscriptionInfoFeedLink) {
38		throw new \InvalidArgumentException('Invalid link type %s.', get_class($link));
39		}
40		if (isset($this->links[$link->getRelation()])) {
41		throw new \InvalidArgumentException(sprintf('Link relation %s already there.', $link->getRelation()));
42		}
43		}
44
45		/**
46		* @return PersistentSubscriptionInfo
47		*/
48		public function getPersistentSubscriptionInfo(): PersistentSubscriptionInfo
49		{
50		return $this->info;
51		}
52		}
53

rayrutjes / php-geteventstore-client

Pull Request — master (#1)

PersistentSubscriptionInfoFeed::validateLink() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like