Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | View Code Duplication | final class EventStreamViaPersistentSubscriptionFeedLink extends AbstractFeedLink |
|
|
|||
6 | { |
||
7 | const LINK_SELF = 'self'; |
||
8 | const LINK_FIRST = 'first'; |
||
9 | const LINK_LAST = 'last'; |
||
10 | const LINK_PREVIOUS = 'previous'; |
||
11 | const LINK_NEXT = 'next'; |
||
12 | const LINK_ACK_ALL = 'ackAll'; |
||
13 | const LINK_NACK_ALL = 'nackAll'; |
||
14 | |||
15 | /** |
||
16 | * @return array |
||
17 | */ |
||
18 | protected function getValidRelations(): array |
||
30 | } |
||
31 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.