Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | class ExpectedVersion |
||
6 | { |
||
7 | /** |
||
8 | * Ensures that the stream exists but contains no events. |
||
9 | */ |
||
10 | const EMPTY_STREAM = 0; |
||
11 | |||
12 | /** |
||
13 | * Ensures that the stream does not exist. |
||
14 | */ |
||
15 | const NO_STREAM = -1; |
||
16 | |||
17 | /** |
||
18 | * Will always succeed. This should not be used if you to keep your event store consistent. |
||
19 | */ |
||
20 | const ANY = -2; |
||
21 | |||
22 | /** |
||
23 | * @var int |
||
24 | */ |
||
25 | private $value; |
||
26 | |||
27 | /** |
||
28 | * @param int $value |
||
29 | */ |
||
30 | View Code Duplication | public function __construct(int $value) |
|
37 | |||
38 | /** |
||
39 | * @return int |
||
40 | */ |
||
41 | public function toInt(): int |
||
45 | } |
||
46 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.