Issues in VndErrorHandler.php (1.x) - Issues in 1.x - ray-di/Ray.WebFormModule - Measure and Improve Code Quality continuously with Scrutinizer

Issues (10)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/VndErrorHandler.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This file is part of the Ray.WebFormModule package.
 *
 * @license http://opensource.org/licenses/MIT MIT
 */
namespace Ray\WebFormModule;

use Doctrine\Common\Annotations\Reader;
use Ray\Aop\MethodInvocation;
use Ray\WebFormModule\Annotation\AbstractValidation;
use Ray\WebFormModule\Annotation\VndError;
use Ray\WebFormModule\Exception\ValidationException;

final class VndErrorHandler implements FailureHandlerInterface
{
    /**
     * @var Reader
     */
    private $reader;

    public function __construct(Reader $reader)
    {
        $this->reader = $reader;
    }

    /**
     * {@inheritdoc}
     */
    public function handle(AbstractValidation $formValidation, MethodInvocation $invocation, AbstractForm $form)
    {
        unset($formValidation);
        $vndError = $this->reader->getMethodAnnotation($invocation->getMethod(), VndError::class);
        $error = new FormValidationError($this->makeVndError($form, $vndError));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        throw new ValidationException('Validation failed.', 400, null, $error);
    }

    private function makeVndError(AbstractForm $form, VndError $vndError = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $body = ['message' => 'Validation failed'];
        $body['path'] = isset($_SERVER['PATH_INFO']) ? $_SERVER['PATH_INFO'] : '';
        $body['validation_messages'] = $form->getFailureMessages();
        $body = $vndError ? $this->optionalAttribute($vndError) + $body : $body;

        return $body;
    }

    private function optionalAttribute(VndError $vndError)
    {
        $body = [];
        if ($vndError->message) {
            $body['message'] = $vndError->message;
        }
        if ($vndError->path) {
            $body['path'] = $vndError->path;
        }
        if ($vndError->logref) {
            $body['logref'] = $vndError->logref;
        }

        return $body;
    }
}


1		<?php
2		/**
3		* This file is part of the Ray.WebFormModule package.
4		*
5		* @license http://opensource.org/licenses/MIT MIT
6		*/
7		namespace Ray\WebFormModule;
8
9		use Doctrine\Common\Annotations\Reader;
10		use Ray\Aop\MethodInvocation;
11		use Ray\WebFormModule\Annotation\AbstractValidation;
12		use Ray\WebFormModule\Annotation\VndError;
13		use Ray\WebFormModule\Exception\ValidationException;
14
15		final class VndErrorHandler implements FailureHandlerInterface
16		{
17		/**
18		* @var Reader
19		*/
20		private $reader;
21
22	5	public function __construct(Reader $reader)
23		{
24	5	$this->reader = $reader;
25	5	}
26
27		/**
28		* {@inheritdoc}
29		*/
30	4	public function handle(AbstractValidation $formValidation, MethodInvocation $invocation, AbstractForm $form)
31		{
32	4	unset($formValidation);
33	4	$vndError = $this->reader->getMethodAnnotation($invocation->getMethod(), VndError::class);
34	4	$error = new FormValidationError($this->makeVndError($form, $vndError));
		0 ignored issues – show Bug introduced 2017-05-22 03:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$vndError` defined by `$this->reader->getMethod...tation\VndError::class)` on line `33` can also be of type `object`; however, `Ray\WebFormModule\VndErrorHandler::makeVndError()` does only seem to accept `null\|object<Ray\WebFormM...le\Annotation\VndError>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
35
36	4	throw new ValidationException('Validation failed.', 400, null, $error);
37		}
38
39	4	private function makeVndError(AbstractForm $form, VndError $vndError = null)
		0 ignored issues – show Coding Style introduced 2017-12-08 05:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this `makeVndError` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
40		{
41	4	$body = ['message' => 'Validation failed'];
42	4	$body['path'] = isset($_SERVER['PATH_INFO']) ? $_SERVER['PATH_INFO'] : '';
43	4	$body['validation_messages'] = $form->getFailureMessages();
44	4	$body = $vndError ? $this->optionalAttribute($vndError) + $body : $body;
45
46	4	return $body;
47		}
48
49	1	private function optionalAttribute(VndError $vndError)
50		{
51	1	$body = [];
52	1	if ($vndError->message) {
53	1	$body['message'] = $vndError->message;
54		}
55	1	if ($vndError->path) {
56	1	$body['path'] = $vndError->path;
57		}
58	1	if ($vndError->logref) {
59	1	$body['logref'] = $vndError->logref;
60		}
61
62	1	return $body;
63		}
64		}
65

ray-di / Ray.WebFormModule

Issues (10)

Security Analysis not enabled

src/VndErrorHandler.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like