Issues (94)

src/di/SetterMethods.php (2 issues)

Labels
Severity
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Ray\Di;
6
7
use Exception;
0 ignored issues
show
This use statement conflicts with another class in this namespace, Ray\Di\Exception. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
8
9
/**
10
 * @psalm-import-type SetterMethodsList from Types
11
 */
12
final class SetterMethods implements AcceptInterface
13
{
14
    /**
15
     * @param SetterMethodsList $setterMethods
0 ignored issues
show
The type Ray\Di\SetterMethodsList was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
16
     */
17
    public function __construct(private array $setterMethods)
18
    {
19
    }
20
21
    /**
22
     * @throws Exception
23
     */
24
    public function __invoke(object $instance, Container $container): void
25
    {
26
        foreach ($this->setterMethods as $setterMethod) {
27
            ($setterMethod)($instance, $container);
28
        }
29
    }
30
31
    public function add(?SetterMethod $setterMethod = null): void
32
    {
33
        if (! $setterMethod instanceof SetterMethod) {
34
            return;
35
        }
36
37
        $this->setterMethods[] = $setterMethod;
38
    }
39
40
    /** @inheritDoc */
41
    public function accept(VisitorInterface $visitor): void
42
    {
43
        $visitor->visitSetterMethods($this->setterMethods);
44
    }
45
}
46