Issues in MethodInvocationProvider.php (feature/legacy-method-qualifier-inference) - Issues in feature/legacy-method-qualifier-inference - ray-di/Ray.Di - Measure and Improve Code Quality continuously with Scrutinizer

Issues (94)

src/di/MethodInvocationProvider.php (1 issue)

Labels

Severity

Major 1

<?php

declare(strict_types=1);

namespace Ray\Di;

use Ray\Aop\MethodInvocation;
use Ray\Di\Exception\MethodInvocationNotAvailable;

/**
 * @implements ProviderInterface<MethodInvocation>
 */
final class MethodInvocationProvider implements ProviderInterface
{
    /** @var ?MethodInvocation<object> */
    private ?MethodInvocation $invocation = null;

    /**
     * @param MethodInvocation<object> $invocation
     */
    public function set(MethodInvocation $invocation): void
    {
        $this->invocation = $invocation;
    }

    /**
     * @return MethodInvocation<object>
     */
    public function get(): MethodInvocation
    {
        if ($this->invocation === null) {
            throw new MethodInvocationNotAvailable();
        }

        return $this->invocation;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Ray\Di;
6
7			use Ray\Aop\MethodInvocation;
8			use Ray\Di\Exception\MethodInvocationNotAvailable;
9
10			/**
11			* @implements ProviderInterface<MethodInvocation>
12			*/
13			final class MethodInvocationProvider implements ProviderInterface
14			{
15			/** @var ?MethodInvocation<object> */
16			private ?MethodInvocation $invocation = null;
17
18			/**
19			* @param MethodInvocation<object> $invocation
20			*/
21			public function set(MethodInvocation $invocation): void
22			{
23			$this->invocation = $invocation;
24			}
25
26			/**
27			* @return MethodInvocation<object>
28			*/
29			public function get(): MethodInvocation
30			{
31			if ($this->invocation === null) {
32			throw new MethodInvocationNotAvailable();
33			}
34
35			return $this->invocation;
			0 ignored issues – show Bug Best Practice introduced 2022-03-04 21:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $this->invocation` returns the type `Ray\Aop\MethodInvocation` which is incompatible with the return type mandated by `Ray\Di\ProviderInterface::get()` of `Ray\Di\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
36			}
37			}
38

ray-di / Ray.Di

Issues (94)

src/di/MethodInvocationProvider.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like