Issues (101)

src/di/SetterMethods.php (4 issues)

1
<?php
2
3
declare(strict_types=1);
4
5
namespace Ray\Di;
6
7
use Exception;
0 ignored issues
show
This use statement conflicts with another class in this namespace, Ray\Di\Exception. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
8
9
/**
10
 * @psalm-import-type SetterMethodsList from Types
11
 */
12
final class SetterMethods implements AcceptInterface
13
{
14
    /** @var SetterMethodsList */
0 ignored issues
show
The type Ray\Di\SetterMethodsList was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
15
    private $setterMethods;
16
17
    /**
18
     * @param SetterMethodsList $setterMethods
19
     */
20
    public function __construct(array $setterMethods)
21
    {
22
        $this->setterMethods = $setterMethods;
0 ignored issues
show
Documentation Bug introduced by
It seems like $setterMethods of type array is incompatible with the declared type Ray\Di\SetterMethodsList of property $setterMethods.

Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.

Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..

Loading history...
23
    }
24
25
    /**
26
     * @throws Exception
27
     */
28
    public function __invoke(object $instance, Container $container): void
29
    {
30
        foreach ($this->setterMethods as $setterMethod) {
31
            ($setterMethod)($instance, $container);
32
        }
33
    }
34
35
    public function add(?SetterMethod $setterMethod = null): void
36
    {
37
        if (! $setterMethod) {
38
            return;
39
        }
40
41
        $this->setterMethods[] = $setterMethod;
42
    }
43
44
    /** @inheritDoc */
45
    public function accept(VisitorInterface $visitor)
46
    {
47
        $visitor->visitSetterMethods($this->setterMethods);
0 ignored issues
show
$this->setterMethods of type Ray\Di\SetterMethodsList is incompatible with the type array expected by parameter $setterMethods of Ray\Di\VisitorInterface::visitSetterMethods(). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

47
        $visitor->visitSetterMethods(/** @scrutinizer ignore-type */ $this->setterMethods);
Loading history...
48
    }
49
}
50