ParamInjectInterceptor::__construct() - Code Metrics - Inspection of "Install ParamInjectModule" - ray-di/Ray.Di - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — param-inject ( 83c5f6 )

by Akihito

created 2020-12-20 15:26 UTC

ParamInjectInterceptor::__construct() A

↳ Parent: ParamInjectInterceptor

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

declare(strict_types=1);

namespace Ray\Di;

use Ray\Aop\MethodInterceptor;
use Ray\Aop\MethodInvocation;
use Ray\Di\Di\Inject;
use Ray\Di\Di\Named;
use ReflectionParameter;

use function assert;
use function call_user_func_array;

final class ParamInjectInterceptor implements MethodInterceptor
{
    /** @var InjectorInterface */
    private $injector;

    /** @var MethodInvocationProvider */
    private $methodInvocationProvider;

    public function __construct(InjectorInterface $injector, MethodInvocationProvider $methodInvocationProvider)
    {
        $this->injector = $injector;
        $this->methodInvocationProvider = $methodInvocationProvider;
    }

    public function invoke(MethodInvocation $invocation)
    {
        $params = $invocation->getMethod()->getParameters();
        $namedArguments = $invocation->getNamedArguments()->getArrayCopy();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $injectedParams = [];
        foreach ($params as $param) {
            $attributes = $param->getAttributes(Inject::class);
            if (isset($attributes[0])) {
                $injectedParams[$param->getName()] = $this->getDependency($param);

            }
        }

        $args = $injectedParams + $params;

        return call_user_func_array([$invocation->getThis(), $invocation->getMethod()->getName()], $args);

    }

    private function getDependencies(array $params)

    {
        $params = [];
        foreach ($params as $param) {
            $dependecy = $this->getDependency($param);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
    }

    private function getDependency(ReflectionParameter $param)
    {
        $named = $this->getName($param);
        $interface = $param->getType()->getName();

        return $this->injector->getInstance($interface, $named);
    }

    private function getName(ReflectionParameter $param): string
    {
        $attributes = $param->getAttributes(Named::class);
        if (isset($attributes[0])) {
            $named = $attributes[0]->newInstance();
            assert($named instanceof Named);

            return $named->value;
        }

        return '';
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Ray\Di;
6
7			use Ray\Aop\MethodInterceptor;
8			use Ray\Aop\MethodInvocation;
9			use Ray\Di\Di\Inject;
10			use Ray\Di\Di\Named;
11			use ReflectionParameter;
12
13			use function assert;
14			use function call_user_func_array;
15
16			final class ParamInjectInterceptor implements MethodInterceptor
17			{
18			/** @var InjectorInterface */
19			private $injector;
20
21			/** @var MethodInvocationProvider */
22			private $methodInvocationProvider;
23
24			public function __construct(InjectorInterface $injector, MethodInvocationProvider $methodInvocationProvider)
25			{
26			$this->injector = $injector;
27			$this->methodInvocationProvider = $methodInvocationProvider;
28			}
29
30			public function invoke(MethodInvocation $invocation)
31			{
32			$params = $invocation->getMethod()->getParameters();
33			$namedArguments = $invocation->getNamedArguments()->getArrayCopy();
			0 ignored issues – show Unused Code introduced 2020-12-20 15:27 UTC by Report Bug Copy Issue Report `$namedArguments` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
34			$injectedParams = [];
35			foreach ($params as $param) {
36			$attributes = $param->getAttributes(Inject::class);
37			if (isset($attributes[0])) {
38			$injectedParams[$param->getName()] = $this->getDependency($param);
			0 ignored issues – show Bug introduced 2020-12-20 15:27 UTC by Report Bug Copy Issue Report Consider using `$param->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
39			}
40			}
41
42			$args = $injectedParams + $params;
43
44			return call_user_func_array([$invocation->getThis(), $invocation->getMethod()->getName()], $args);
			0 ignored issues – show Bug introduced 2020-12-20 15:27 UTC by Report Bug Copy Issue Report Consider using `$invocation->getMethod()->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
45			}
46
47			private function getDependencies(array $params)
			0 ignored issues – show Unused Code introduced 2020-12-20 15:27 UTC by Report Bug Copy Issue Report The parameter `$params` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
48			{
49			$params = [];
50			foreach ($params as $param) {
51			$dependecy = $this->getDependency($param);
			0 ignored issues – show Unused Code introduced 2020-12-20 15:27 UTC by Report Bug Copy Issue Report `$dependecy` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
52			}
53			}
54
55			private function getDependency(ReflectionParameter $param)
56			{
57			$named = $this->getName($param);
58			$interface = $param->getType()->getName();
59
60			return $this->injector->getInstance($interface, $named);
61			}
62
63			private function getName(ReflectionParameter $param): string
64			{
65			$attributes = $param->getAttributes(Named::class);
66			if (isset($attributes[0])) {
67			$named = $attributes[0]->newInstance();
68			assert($named instanceof Named);
69
70			return $named->value;
71			}
72
73			return '';
74			}
75			}
76

ray-di / Ray.Di

Push — param-inject ( 83c5f6 )

ParamInjectInterceptor::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like