Ray\Di\AnnotatedClassMethods

Complexity

Total Complexity

16

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes	10
Bugs	1	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getConstructorName()	0	18	4
A	getNamedKeyVarString()	0	18	4
A	getQualifierKeyVarString()	0	15	4
A	getSetterMethod()	0	16	3

<?php
/**
 * This file is part of the Ray.Di package.
 *
 * @license http://opensource.org/licenses/MIT MIT
 */
namespace Ray\Di;

use Doctrine\Common\Annotations\Reader;
use Ray\Di\Di\Named;

final class AnnotatedClassMethods
{
    /**
     * @var Reader
     */
    private $reader;

    public function __construct(Reader $reader)
    {
        $this->reader = $reader;
    }

    /**
     * @param \ReflectionClass $class
     *
     * @return Name
     */
    public function getConstructorName(\ReflectionClass $class)
    {
        $constructor = $class->getConstructor();
        if (! $constructor) {
            return new Name(Name::ANY);
        }
        $named = $this->reader->getMethodAnnotation($constructor, 'Ray\Di\Di\Named');
        if ($named) {
            /* @var $named Named */
            return new Name($named->value);
        }
        $name = $this->getNamedKeyVarString($constructor);
        if ($name) {

The expression $name of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            return new Name($name);
        }

        return new Name(Name::ANY);
    }

    /**
     * @param \ReflectionMethod $method
     *
     * @return SetterMethod
     */
    public function getSetterMethod(\ReflectionMethod $method)
    {
        $inject = $this->reader->getMethodAnnotation($method, 'Ray\Di\Di\InjectInterface');

        /* @var $inject \Ray\Di\Di\Inject */
        if (! $inject) {
            return null;
        }
        $nameValue = $this->getNamedKeyVarString($method);
        $setterMethod = new SetterMethod($method, new Name($nameValue));
        if ($inject->isOptional()) {
            $setterMethod->setOptional();
        }

        return $setterMethod;
    }

    /**
     * @param \ReflectionMethod $method
     *
     * @return string
     */
    private function getNamedKeyVarString(\ReflectionMethod $method)
    {
        $keyVal = [];
        /* @var $named Named */
        $named = $this->reader->getMethodAnnotation($method, 'Ray\Di\Di\Named');
        if ($named) {
            $keyVal[] = $named->value;
        }
        $qualifierNamed = $this->getQualifierKeyVarString($method);
        if ($qualifierNamed) {
            $keyVal[] = $qualifierNamed;
        }
        if ($keyVal) {

The expression $keyVal of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return implode(',', $keyVal); // var1=qualifier1,va2=qualifier2
        }

        return null;
    }

    /**
     * @param \ReflectionMethod $method
     *
     * @return string
     */
    private function getQualifierKeyVarString(\ReflectionMethod $method)
    {
        $annotations = $this->reader->getMethodAnnotations($method);
        $names = [];
        foreach ($annotations as $annotation) {
            /* @var $bindAnnotation object|null */
            $qualifier = $this->reader->getClassAnnotation(new \ReflectionClass($annotation), 'Ray\Di\Di\Qualifier');

Are you sure the assignment to $qualifier is correct as $this->reader->getClassAnnotation(new \ReflectionClass($annotation), 'Ray\\Di\\Di\\Qualifier') (which targets Doctrine\Common\Annotations\Reader::getClassAnnotation()) seems to always return null.

            if ($qualifier) {
                $value = isset($annotation->value) ? $annotation->value : Name::ANY;
                $names[] = sprintf('%s=%s', $value, get_class($annotation));
            }
        }

        return implode(',', $names);
    }
}