Ray\Di\Argument

Complexity

Total Complexity

16

Size/Duplication

Total Lines	136
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__toString()	0	4	1
A	get()	0	4	1
A	isDefaultAvailable()	0	4	1
A	getDefaultValue()	0	4	1
A	getMeta()	0	4	1
A	__construct()	0	20	3
A	serialize()	0	16	1
A	unserialize()	0	10	1
A	setDefaultValue()	0	12	3
A	getType()	0	9	3

<?php

declare(strict_types=1);
/**
 * This file is part of the Ray.Di package.
 *
 * @license http://opensource.org/licenses/MIT MIT
 */
namespace Ray\Di;

final class Argument implements \Serializable
{
    /**
     * @var string
     */
    private $index;

    /**
     * @var bool
     */
    private $isDefaultAvailable;

    /**
     * @var mixed
     */
    private $default;

    /**
     * @var string
     */
    private $meta;

    /**
     * @var \ReflectionParameter
     */
    private $reflection;

    public function __construct(\ReflectionParameter $parameter, string $name)
    {
        $type = $this->getType($parameter);
        $isOptional = $parameter->isOptional();
        $this->isDefaultAvailable = $parameter->isDefaultValueAvailable() || $isOptional;
        if ($isOptional) {
            $this->default = null;
        }
        $this->setDefaultValue($parameter);
        $this->index = $type . '-' . $name;
        $this->reflection = $parameter;
        $this->meta = sprintf(
            "dependency '%s' with name '%s' used in %s:%d ($%s)",
            $type,
            $name,
            $this->reflection->getDeclaringFunction()->getFileName(),
            $this->reflection->getDeclaringFunction()->getStartLine(),
            $parameter->getName()

Consider using $parameter->name. There is an issue with getName() and APC-enabled PHP versions.

        );
    }

    /**
     * @return string
     */
    public function __toString()
    {
        return $this->index;
    }

    /**
     * Return reflection
     */
    public function get() : \ReflectionParameter
    {
        return $this->reflection;
    }

    /**
     * @return bool
     */
    public function isDefaultAvailable() : bool
    {
        return $this->isDefaultAvailable;
    }

    /**
     * @return mixed
     */
    public function getDefaultValue()
    {
        return $this->default;
    }

    public function getMeta() : string
    {
        return $this->meta;
    }

    public function serialize() : string
    {
        $ref = [
            $this->reflection->getDeclaringFunction()->class,

The property class does not seem to exist in ReflectionFunction.

            $this->reflection->getDeclaringFunction()->name,
            $this->reflection->getName()

Consider using $this->reflection->name. There is an issue with getName() and APC-enabled PHP versions.

        ];

        return \serialize([
            $this->index,
            $this->isDefaultAvailable,
            $this->default,
            $this->meta,
            $ref
        ]);
    }

    public function unserialize($serialized)
    {
        list($this->index,
            $this->isDefaultAvailable,
            $this->default,
            $this->meta,
            $ref
        ) = unserialize($serialized);
        $this->reflection = new \ReflectionParameter([$ref[0], $ref[1]], $ref[2]);
    }

    private function setDefaultValue(\ReflectionParameter $parameter)
    {
        if (! $this->isDefaultAvailable) {
            return;
        }
        try {
            $this->default = $parameter->getDefaultValue();
        } /* @noinspection PhpRedundantCatchClauseInspection */ catch (\ReflectionException $e) {
            // probably it is internal class like \PDO
            $this->default = null;
        }
    }

    private function getType(\ReflectionParameter $parameter) : string
    {
        $type = $parameter->getType();
        if ($type instanceof \ReflectionType && \in_array((string) $type, ['bool', 'int', 'string', 'array', 'resource', 'callable'], true)) {

The class ReflectionType does not exist. Did you forget a USE statement, or did you not list all dependencies?

            return '';
        }

        return (string) $type;
    }
}