ray-di / Ray.Compiler

src/FilePutContents.php

<?php

declare(strict_types=1);

namespace Ray\Compiler;

use Ray\Compiler\Exception\FileNotWritable;

use function dirname;
use function file_put_contents;
use function is_dir;
use function is_int;
use function is_string;
use function mkdir;
use function rename;
use function tempnam;
use function unlink;

final class FilePutContents
{
    public function __invoke(string $filename, string $content): void
    {
        $dir = dirname($filename);
        if (! is_dir($dir)) {
            mkdir($dir, 0777, true);
        }

        $tmpFile = tempnam(dirname($filename), 'swap');
        if (is_string($tmpFile) && is_int(file_put_contents($tmpFile, $content)) && @rename($tmpFile, $filename)) {

The condition is_int(file_put_contents($tmpFile, $content)) is always true.

            return;
        }

        // @codeCoverageIgnoreStart
        @unlink((string) $tmpFile);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        throw new FileNotWritable($filename);
        // @codeCoverageIgnoreEnd
    }
}