Code::save() - Code Metrics - Inspection of "Merge pull request #138 from koriym/refactor" - ray-di/Ray.Aop - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — aop-class-name ( dbcade )

by Akihito

created 2020-05-19 15:01 UTC

Code::save() A

↳ Parent: Code

Complexity

Conditions	4
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0
cc	4
nc	2
nop	2

<?php

declare(strict_types=1);

namespace Ray\Aop;

use PhpParser\Node;
use PhpParser\PrettyPrinter\Standard;
use Ray\Aop\Exception\NotWritableException;

final class Code
{
    /**
     * @var string
     */
    public $code;

    /**
     * @param array<Node> $stmt
     */
    public function __construct(array $stmt)
    {
        $this->code = (new Standard(['shortArraySyntax' => true]))->prettyPrintFile($stmt) . PHP_EOL;
    }

    public function save(string $classDir, string $aopClassName) : string
    {
        class_exists($aopClassName);
        $flatName = str_replace('\\', '_', $aopClassName);
        $filename = sprintf('%s/%s.php', $classDir, $flatName);
        $tmpFile = tempnam(dirname($filename), 'swap');
        if (is_string($tmpFile) && file_put_contents($tmpFile, $this->code) && rename($tmpFile, $filename)) {
            return $filename;
        }
        @unlink((string) $tmpFile);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        throw new NotWritableException(sprintf('swap: %s, file: %s', $tmpFile, $filename));
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Ray\Aop;
6
7			use PhpParser\Node;
8			use PhpParser\PrettyPrinter\Standard;
9			use Ray\Aop\Exception\NotWritableException;
10
11			final class Code
12			{
13			/**
14			* @var string
15			*/
16			public $code;
17
18			/**
19			* @param array<Node> $stmt
20			*/
21			public function __construct(array $stmt)
22			{
23			$this->code = (new Standard(['shortArraySyntax' => true]))->prettyPrintFile($stmt) . PHP_EOL;
24			}
25
26			public function save(string $classDir, string $aopClassName) : string
27			{
28			class_exists($aopClassName);
29			$flatName = str_replace('\\', '_', $aopClassName);
30			$filename = sprintf('%s/%s.php', $classDir, $flatName);
31			$tmpFile = tempnam(dirname($filename), 'swap');
32			if (is_string($tmpFile) && file_put_contents($tmpFile, $this->code) && rename($tmpFile, $filename)) {
33			return $filename;
34			}
35			@unlink((string) $tmpFile);
			0 ignored issues – show Security Best Practice introduced 2020-05-13 05:38 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
36
37			throw new NotWritableException(sprintf('swap: %s, file: %s', $tmpFile, $filename));
38			}
39			}
40

ray-di / Ray.Aop

Push — aop-class-name ( dbcade )

Code::save() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like