Rawaby88\OpenWeatherMap\Traits\CWSingleResultTrait

Complexity

Total Complexity

1

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Importance

Changes	2
Bugs	1	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	get()	0	3	1

<?php

namespace Rawaby88\OpenWeatherMap\Traits;

use Rawaby88\OpenWeatherMap\Services\Support\CurrentWeather;

/**
 * Trait CWSingleResultTrait.
 */
trait CWSingleResultTrait
{
    /**
     * @var array Hold query parameters for api call.
     */
    protected $params;

    /**
     * @var string Part of the api link.
     */
    protected $apiCall;

    /**
     * Return APi call result as CurrentWeather object.
     * @return CurrentWeather
     */
    public function get(): CurrentWeather
    {
        return new CurrentWeather($this->queryOrFail($this->apiCall, $this->params));

It seems like queryOrFail() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}