Issues in actions.php (master) - Issues in master - ravinderk/Give - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4335)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/gateways/actions.php (10 issues)

Labels

Unused Code 1

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Gateway Actions
 *
 * @package     Give
 * @subpackage  Gateways
 * @copyright   Copyright (c) 2016, GiveWP
 * @license     https://opensource.org/licenses/gpl-license GNU Public License
 * @since       1.0
 */

// Exit if accessed directly.
if ( ! defined( 'ABSPATH' ) ) {
	exit;
}

/**
 * Processes gateway select on checkout. Only for users without ajax / javascript
 *
 * @since 1.0
 *
 * @param $data
 */
function give_process_gateway_select( $data ) {

	if ( isset( $_POST['gateway_submit'] ) ) {

		wp_redirect( esc_url( add_query_arg( 'payment-mode', $_POST['payment-mode'] ) ) );

		exit;
	}
}

add_action( 'give_gateway_select', 'give_process_gateway_select' );

/**
 * Loads a payment gateway via AJAX.
 *
 * @since 1.0
 *
 * @return void
 */
function give_load_ajax_gateway() {

	$post_data = give_clean( $_POST ); // WPCS: input var ok, CSRF ok.


	if (
		! isset( $post_data['nonce'] )
		|| ! give_verify_donation_form_nonce( $post_data['nonce'], $post_data['give_form_id'] )
	) {
		Give_Notices::print_frontend_notice( __( 'Nonce verification has failed.', 'give' ), true, 'error' );
		exit();

	}elseif ( isset( $post_data['give_payment_mode'] ) ) {

		$form_id_prefix = ! empty( $post_data['give_form_id_prefix'] ) ? $post_data['give_form_id_prefix'] : '';

		$args = array(
			'id_prefix' => $form_id_prefix,
		);

		/**
		 * Fire to render donation form.
		 *
		 * @since 1.7
		 */
		do_action( 'give_donation_form', $post_data['give_form_id'], $args );

		exit();
	}
}

add_action( 'wp_ajax_give_load_gateway', 'give_load_ajax_gateway' );
add_action( 'wp_ajax_nopriv_give_load_gateway', 'give_load_ajax_gateway' );

/**
 * Create wp nonce using Ajax call.
 *
 * Use give_donation_form_nonce() js fn to create nonce.
 *
 * @since 2.0
 *
 * @return void
 */
function give_donation_form_nonce() {
	if ( isset( $_POST['give_form_id'] ) ) {

		// Get donation form id.
		$form_id = is_numeric( $_POST['give_form_id'] ) ? absint( $_POST['give_form_id'] ) : 0;


		// Send nonce json data.
		wp_send_json_success( wp_create_nonce( "give_donation_form_nonce_{$form_id}" ) );
	}
}

add_action( 'wp_ajax_give_donation_form_nonce', 'give_donation_form_nonce' );
add_action( 'wp_ajax_nopriv_give_donation_form_nonce', 'give_donation_form_nonce' );


/**
 * Create all nonce of donation form using Ajax call.
 * Note: only for internal use
 *
 * @since 2.2.0
 *
 * @return void
 */
function __give_donation_form_reset_all_nonce() {
	if ( isset( $_POST['give_form_id'] ) ) {

		// Get donation form id.
		$form_id = is_numeric( $_POST['give_form_id'] ) ? absint( $_POST['give_form_id'] ) : 0;


		$data = array(
			'give_form_hash'               => wp_create_nonce( "give_donation_form_nonce_{$form_id}" ),
			'give_form_user_register_hash' => wp_create_nonce( "give_form_create_user_nonce_{$form_id}" )
		);

		/**
		 * Filter the ajax request data
		 *
		 * @since  2.2.0
		 *
		 */
		$data = apply_filters( 'give_donation_form_reset_all_nonce_data', $data );

		// Send nonce json data.
		wp_send_json_success( $data );
	}

	wp_send_json_error();
}

add_action( 'wp_ajax_give_donation_form_reset_all_nonce', '__give_donation_form_reset_all_nonce' );
add_action( 'wp_ajax_nopriv_give_donation_form_reset_all_nonce', '__give_donation_form_reset_all_nonce' );

/**
 * Sets an error within the donation form if no gateways are enabled.
 * @todo: we can deprecate this function in future because gateways will not empty if get via Give API.
 *
 * @since 1.0
 *
 * @return void
 */
function give_no_gateway_error() {
	$gateways = give_get_enabled_payment_gateways();

	if ( empty( $gateways ) ) {
		give_set_error( 'no_gateways', esc_html__( 'You must enable a payment gateway to use Give.', 'give' ) );
	} else {
		give_unset_error( 'no_gateways' );
	}
}

add_action( 'init', 'give_no_gateway_error' );


1			<?php
2			/**
3			* Gateway Actions
4			*
5			* @package Give
6			* @subpackage Gateways
7			* @copyright Copyright (c) 2016, GiveWP
8			* @license https://opensource.org/licenses/gpl-license GNU Public License
9			* @since 1.0
10			*/
11
12			// Exit if accessed directly.
13			if ( ! defined( 'ABSPATH' ) ) {
14			exit;
15			}
16
17			/**
18			* Processes gateway select on checkout. Only for users without ajax / javascript
19			*
20			* @since 1.0
21			*
22			* @param $data
23			*/
24			function give_process_gateway_select( $data ) {
			0 ignored issues – show Unused Code introduced 2016-12-08 11:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$data` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
25			if ( isset( $_POST['gateway_submit'] ) ) {
			0 ignored issues – show introduced 2017-07-29 03:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Detected access of super global var $_POST, probably need manual inspection. Loading history...
26			wp_redirect( esc_url( add_query_arg( 'payment-mode', $_POST['payment-mode'] ) ) );
			0 ignored issues – show introduced 2017-07-29 03:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Detected access of super global var $_POST, probably need manual inspection. Loading history... introduced 2017-07-29 03:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Detected usage of a non-validated input variable: $_POST Loading history... introduced 2017-07-29 03:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this Detected usage of a non-sanitized input variable: $_POST Loading history...
27			exit;
28			}
29			}
30
31			add_action( 'give_gateway_select', 'give_process_gateway_select' );
32
33			/**
34			* Loads a payment gateway via AJAX.
35			*
36			* @since 1.0
37			*
38			* @return void
39			*/
40			function give_load_ajax_gateway() {
41
42			$post_data = give_clean( $_POST ); // WPCS: input var ok, CSRF ok.
			0 ignored issues – show introduced 2018-05-22 04:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this Detected access of super global var $_POST, probably need manual inspection. Loading history...
43
44			if (
45			! isset( $post_data['nonce'] )
46			\|\| ! give_verify_donation_form_nonce( $post_data['nonce'], $post_data['give_form_id'] )
47			) {
48			Give_Notices::print_frontend_notice( __( 'Nonce verification has failed.', 'give' ), true, 'error' );
49			exit();
50
51			}elseif ( isset( $post_data['give_payment_mode'] ) ) {
52
53			$form_id_prefix = ! empty( $post_data['give_form_id_prefix'] ) ? $post_data['give_form_id_prefix'] : '';
54
55			$args = array(
56			'id_prefix' => $form_id_prefix,
57			);
58
59			/**
60			* Fire to render donation form.
61			*
62			* @since 1.7
63			*/
64			do_action( 'give_donation_form', $post_data['give_form_id'], $args );
65
66			exit();
67			}
68			}
69
70			add_action( 'wp_ajax_give_load_gateway', 'give_load_ajax_gateway' );
71			add_action( 'wp_ajax_nopriv_give_load_gateway', 'give_load_ajax_gateway' );
72
73			/**
74			* Create wp nonce using Ajax call.
75			*
76			* Use give_donation_form_nonce() js fn to create nonce.
77			*
78			* @since 2.0
79			*
80			* @return void
81			*/
82			function give_donation_form_nonce() {
83			if ( isset( $_POST['give_form_id'] ) ) {
84
85			// Get donation form id.
86			$form_id = is_numeric( $_POST['give_form_id'] ) ? absint( $_POST['give_form_id'] ) : 0;
			0 ignored issues – show introduced 2018-01-05 08:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Detected access of super global var $_POST, probably need manual inspection. Loading history... introduced 2018-01-05 08:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Detected usage of a non-sanitized input variable: $_POST Loading history...
87
88			// Send nonce json data.
89			wp_send_json_success( wp_create_nonce( "give_donation_form_nonce_{$form_id}" ) );
90			}
91			}
92
93			add_action( 'wp_ajax_give_donation_form_nonce', 'give_donation_form_nonce' );
94			add_action( 'wp_ajax_nopriv_give_donation_form_nonce', 'give_donation_form_nonce' );
95
96
97			/**
98			* Create all nonce of donation form using Ajax call.
99			* Note: only for internal use
100			*
101			* @since 2.2.0
102			*
103			* @return void
104			*/
105			function __give_donation_form_reset_all_nonce() {
106			if ( isset( $_POST['give_form_id'] ) ) {
107
108			// Get donation form id.
109			$form_id = is_numeric( $_POST['give_form_id'] ) ? absint( $_POST['give_form_id'] ) : 0;
			0 ignored issues – show introduced 2018-01-05 08:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Detected access of super global var $_POST, probably need manual inspection. Loading history... introduced 2018-07-10 18:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this Detected usage of a non-sanitized input variable: $_POST Loading history...
110
111			$data = array(
112			'give_form_hash' => wp_create_nonce( "give_donation_form_nonce_{$form_id}" ),
113			'give_form_user_register_hash' => wp_create_nonce( "give_form_create_user_nonce_{$form_id}" )
114			);
115
116			/**
117			* Filter the ajax request data
118			*
119			* @since 2.2.0
120			*
121			*/
122			$data = apply_filters( 'give_donation_form_reset_all_nonce_data', $data );
123
124			// Send nonce json data.
125			wp_send_json_success( $data );
126			}
127
128			wp_send_json_error();
129			}
130
131			add_action( 'wp_ajax_give_donation_form_reset_all_nonce', '__give_donation_form_reset_all_nonce' );
132			add_action( 'wp_ajax_nopriv_give_donation_form_reset_all_nonce', '__give_donation_form_reset_all_nonce' );
133
134			/**
135			* Sets an error within the donation form if no gateways are enabled.
136			* @todo: we can deprecate this function in future because gateways will not empty if get via Give API.
137			*
138			* @since 1.0
139			*
140			* @return void
141			*/
142			function give_no_gateway_error() {
143			$gateways = give_get_enabled_payment_gateways();
144
145			if ( empty( $gateways ) ) {
146			give_set_error( 'no_gateways', esc_html__( 'You must enable a payment gateway to use Give.', 'give' ) );
147			} else {
148			give_unset_error( 'no_gateways' );
149			}
150			}
151
152			add_action( 'init', 'give_no_gateway_error' );
153

ravinderk / Give

Issues (4335)

Security Analysis not enabled

includes/gateways/actions.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like