includes/admin/donors/donor-actions.php ➔ give_edit_donor()

Complexity

Conditions	14
Paths	66

Size

Total Lines	90
Code Lines	47

Duplication

Lines	10
Ratio	11.11 %

Importance

Changes

0

<?php
function give_edit_donor( $args ) {

	$donor_edit_role = apply_filters( 'give_edit_donors_role', 'edit_give_payments' );

	if ( ! is_admin() || ! current_user_can( $donor_edit_role ) ) {

This code seems to be duplicated across your project.

		wp_die( __( 'You do not have permission to edit this donor.', 'give' ), __( 'Error', 'give' ), array(
			'response' => 403,
		) );
	}

	if ( empty( $args ) ) {
		return false;
	}

	$donor_info = $args['customerinfo'];
	$donor_id   = (int) $args['customerinfo']['id'];
	$nonce      = $args['_wpnonce'];

	if ( ! wp_verify_nonce( $nonce, 'edit-donor' ) ) {
		wp_die( __( 'Cheatin’ uh?', 'give' ), __( 'Error', 'give' ), array(
			'response' => 400,
		) );
	}

	$donor = new Give_Donor( $donor_id );

$donor_id is of type integer, but the function expects a boolean.

	if ( empty( $donor->id ) ) {
		return false;
	}

	$defaults = array(
		'name'    => '',
		'user_id' => 0,
		'line1'   => '',
		'line2'   => '',
		'city'    => '',
		'zip'     => '',
		'state'   => '',
		'country' => '',
	);

	$donor_info = wp_parse_args( $donor_info, $defaults );

	if ( (int) $donor_info['user_id'] !== (int) $donor->user_id ) {

		// Make sure we don't already have this user attached to a donor.
		if ( ! empty( $donor_info['user_id'] ) && false !== Give()->donors->get_donor_by( 'user_id', $donor_info['user_id'] ) ) {
			give_set_error( 'give-invalid-donor-user_id', sprintf( __( 'The User ID #%d is already associated with a different donor.', 'give' ), $donor_info['user_id'] ) );
		}

		// Make sure it's actually a user.
		$user = get_user_by( 'id', $donor_info['user_id'] );
		if ( ! empty( $donor_info['user_id'] ) && false === $user ) {
			give_set_error( 'give-invalid-user_id', sprintf( __( 'The User ID #%d does not exist. Please assign an existing user.', 'give' ), $donor_info['user_id'] ) );
		}
	}

	if ( give_get_errors() ) {
		return false;
	}

	// Sanitize the inputs.
	$donor_data            = array();
	$donor_data['name']    = strip_tags( stripslashes( $donor_info['name'] ) );
	$donor_data['user_id'] = $donor_info['user_id'];

	$donor_data             = apply_filters( 'give_edit_donor_info', $donor_data, $donor_id );

	/**
	 * Filter the address
	 * @todo unnecessary filter because we are not storing donor address to user.
	 *
	 * @since 1.0
	 */
	$address                = apply_filters( 'give_edit_donor_address', array(), $donor_id );

	$donor_data             = give_clean( $donor_data );
	$address                = give_clean( $address );

	$output = give_connect_user_donor_profile( $donor, $donor_data, $address );

It seems like $donor_data defined by give_clean($donor_data) on line 102 can also be of type string; however, give_connect_user_donor_profile() does only seem to accept array, maybe add an additional type check?

It seems like $address defined by give_clean($address) on line 103 can also be of type string; however, give_connect_user_donor_profile() does only seem to accept array, maybe add an additional type check?

	if ( defined( 'DOING_AJAX' ) && DOING_AJAX ) {

This code seems to be duplicated across your project.

		header( 'Content-Type: application/json' );
		echo json_encode( $output );
		wp_die();
	}

	return $output;

}