Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 18 | class Give_Cache_Setting { |
||
|
|
|||
| 19 | /** |
||
| 20 | * Instance. |
||
| 21 | * |
||
| 22 | * @since 2.4.0 |
||
| 23 | * @access private |
||
| 24 | * @var Give_Cache_Setting |
||
| 25 | */ |
||
| 26 | static private $instance; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * Instance. |
||
| 30 | * |
||
| 31 | * @since 2.4.0 |
||
| 32 | * @access private |
||
| 33 | * @var string |
||
| 34 | */ |
||
| 35 | static private $cache_key = 'giveAllOptions'; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * Array of cached settings |
||
| 39 | * |
||
| 40 | * @since 2.4.0 |
||
| 41 | * @access private |
||
| 42 | * @var array |
||
| 43 | */ |
||
| 44 | static private $settings = array( |
||
| 45 | 'give_settings' => array(), |
||
| 46 | 'give_version' => '', |
||
| 47 | 'give_completed_upgrades' => array(), |
||
| 48 | 'currencies' => array(), |
||
| 49 | 'gateways' => array(), |
||
| 50 | ); |
||
| 51 | |||
| 52 | /** |
||
| 53 | * Array of cached setting db option names |
||
| 54 | * |
||
| 55 | * @since 2.4.0 |
||
| 56 | * @access private |
||
| 57 | * @var array |
||
| 58 | */ |
||
| 59 | static private $db_option_ids = array( |
||
| 60 | 'give_settings', |
||
| 61 | 'give_version', |
||
| 62 | 'give_completed_upgrades', |
||
| 63 | ); |
||
| 64 | |||
| 65 | /** |
||
| 66 | * Array of cached setting option names |
||
| 67 | * |
||
| 68 | * @since 2.4.0 |
||
| 69 | * @access private |
||
| 70 | * @var array |
||
| 71 | */ |
||
| 72 | static private $all_option_ids; |
||
| 73 | |||
| 74 | /** |
||
| 75 | * Singleton pattern. |
||
| 76 | * |
||
| 77 | * @since 2.4.0 |
||
| 78 | * @access private |
||
| 79 | */ |
||
| 80 | private function __construct() { |
||
| 82 | |||
| 83 | |||
| 84 | /** |
||
| 85 | * Get instance. |
||
| 86 | * |
||
| 87 | * @since 2.4.0 |
||
| 88 | * @access public |
||
| 89 | * @return Give_Cache_Setting |
||
| 90 | */ |
||
| 91 | View Code Duplication | public static function get_instance() { |
|
| 100 | |||
| 101 | /** |
||
| 102 | * Setup |
||
| 103 | * |
||
| 104 | * @since 2.4.0 |
||
| 105 | * @access private |
||
| 106 | */ |
||
| 107 | private function setup() { |
||
| 119 | |||
| 120 | /** |
||
| 121 | * Load plugin settings |
||
| 122 | * |
||
| 123 | * @since 2.4.0 |
||
| 124 | * @access private |
||
| 125 | */ |
||
| 126 | private function load_plugin_settings() { |
||
| 154 | |||
| 155 | /** |
||
| 156 | * Reload option when add, update or delete |
||
| 157 | * Note: only for internal logic |
||
| 158 | * |
||
| 159 | * @since 2.4.0 |
||
| 160 | * |
||
| 161 | * @param $option_name |
||
| 162 | */ |
||
| 163 | public function __reload_plugin_settings( $option_name ) { |
||
| 172 | |||
| 173 | /** |
||
| 174 | * Setup currencies list |
||
| 175 | * |
||
| 176 | * @since 2.4.0 |
||
| 177 | */ |
||
| 178 | public function __setup_currencies_list() { |
||
| 190 | |||
| 191 | |||
| 192 | /** |
||
| 193 | * Setup gateway list |
||
| 194 | * |
||
| 195 | * @since 2.4.0 |
||
| 196 | */ |
||
| 197 | public function __setup_gateways_list() { |
||
| 223 | |||
| 224 | |||
| 225 | /** |
||
| 226 | * Get option |
||
| 227 | * |
||
| 228 | * @since 2.4.0 |
||
| 229 | * @access public |
||
| 230 | * |
||
| 231 | * @param $option_name |
||
| 232 | * @param bool $default |
||
| 233 | * |
||
| 234 | * @return mixed |
||
| 235 | */ |
||
| 236 | public static function get_option( $option_name, $default = false ) { |
||
| 247 | |||
| 248 | /** |
||
| 249 | * Get plugin settings |
||
| 250 | * |
||
| 251 | * @since 2.4.0 |
||
| 252 | * @access public |
||
| 253 | */ |
||
| 254 | public static function get_settings() { |
||
| 261 | } |
||
| 262 | |||
| 264 |