| Conditions | 208 |
| Paths | 4864 |
| Total Lines | 243 |
| Code Lines | 190 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 98 | function give_is_admin_page( $passed_page = '', $passed_view = '' ) { |
||
| 99 | |||
| 100 | global $pagenow, $typenow; |
||
| 101 | |||
| 102 | $found = false; |
||
| 103 | $post_type = isset( $_GET['post_type'] ) ? strtolower( $_GET['post_type'] ) : false; |
||
| 104 | $action = isset( $_GET['action'] ) ? strtolower( $_GET['action'] ) : false; |
||
| 105 | $taxonomy = isset( $_GET['taxonomy'] ) ? strtolower( $_GET['taxonomy'] ) : false; |
||
| 106 | $page = isset( $_GET['page'] ) ? strtolower( $_GET['page'] ) : false; |
||
| 107 | $view = isset( $_GET['view'] ) ? strtolower( $_GET['view'] ) : false; |
||
| 108 | $tab = isset( $_GET['tab'] ) ? strtolower( $_GET['tab'] ) : false; |
||
| 109 | |||
| 110 | switch ( $passed_page ) { |
||
| 111 | case 'give_forms': |
||
| 112 | switch ( $passed_view ) { |
||
| 113 | case 'list-table': |
||
| 114 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' ) { |
||
| 115 | $found = true; |
||
| 116 | } |
||
| 117 | break; |
||
| 118 | case 'edit': |
||
| 119 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'post.php' ) { |
||
| 120 | $found = true; |
||
| 121 | } |
||
| 122 | break; |
||
| 123 | case 'new': |
||
| 124 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'post-new.php' ) { |
||
| 125 | $found = true; |
||
| 126 | } |
||
| 127 | break; |
||
| 128 | default: |
||
| 129 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) || 'give_forms' === $post_type || ( 'post-new.php' == $pagenow && 'give_forms' === $post_type ) ) { |
||
| 130 | $found = true; |
||
| 131 | } |
||
| 132 | break; |
||
| 133 | } |
||
| 134 | break; |
||
| 135 | case 'categories': |
||
| 136 | switch ( $passed_view ) { |
||
| 137 | case 'list-table': |
||
| 138 | case 'new': |
||
| 139 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit-tags.php' && 'edit' !== $action && 'give_forms_category' === $taxonomy ) { |
||
| 140 | $found = true; |
||
| 141 | } |
||
| 142 | break; |
||
| 143 | case 'edit': |
||
| 144 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit-tags.php' && 'edit' === $action && 'give_forms_category' === $taxonomy ) { |
||
| 145 | $found = true; |
||
| 146 | } |
||
| 147 | break; |
||
| 148 | default: |
||
| 149 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit-tags.php' && 'give_forms_category' === $taxonomy ) { |
||
| 150 | $found = true; |
||
| 151 | } |
||
| 152 | break; |
||
| 153 | } |
||
| 154 | break; |
||
| 155 | case 'tags': |
||
| 156 | switch ( $passed_view ) { |
||
| 157 | case 'list-table': |
||
| 158 | case 'new': |
||
| 159 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit-tags.php' && 'edit' !== $action && 'give_forms_tag' === $taxonomy ) { |
||
| 160 | $found = true; |
||
| 161 | } |
||
| 162 | break; |
||
| 163 | case 'edit': |
||
| 164 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit-tags.php' && 'edit' === $action && 'give_forms_tag' === $taxonomy ) { |
||
| 165 | $found = true; |
||
| 166 | } |
||
| 167 | break; |
||
| 168 | default: |
||
| 169 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit-tags.php' && 'give_forms_tag' === $taxonomy ) { |
||
| 170 | $found = true; |
||
| 171 | } |
||
| 172 | break; |
||
| 173 | } |
||
| 174 | break; |
||
| 175 | case 'payments': |
||
| 176 | switch ( $passed_view ) { |
||
| 177 | case 'list-table': |
||
| 178 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-payment-history' === $page && false === $view ) { |
||
| 179 | $found = true; |
||
| 180 | } |
||
| 181 | break; |
||
| 182 | case 'edit': |
||
| 183 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-payment-history' === $page && 'view-order-details' === $view ) { |
||
| 184 | $found = true; |
||
| 185 | } |
||
| 186 | break; |
||
| 187 | default: |
||
| 188 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-payment-history' === $page ) { |
||
| 189 | $found = true; |
||
| 190 | } |
||
| 191 | break; |
||
| 192 | } |
||
| 193 | break; |
||
| 194 | case 'reports': |
||
| 195 | switch ( $passed_view ) { |
||
| 196 | // If you want to do something like enqueue a script on a particular report's duration, look at $_GET[ 'range' ] |
||
| 197 | case 'earnings': |
||
| 198 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-reports' === $page && ( 'earnings' === $view || '-1' === $view || false === $view ) ) { |
||
| 199 | $found = true; |
||
| 200 | } |
||
| 201 | break; |
||
| 202 | case 'donors': |
||
| 203 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-reports' === $page && 'customers' === $view ) { |
||
| 204 | $found = true; |
||
| 205 | } |
||
| 206 | break; |
||
| 207 | case 'gateways': |
||
| 208 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-reports' === $page && 'gateways' === $view ) { |
||
| 209 | $found = true; |
||
| 210 | } |
||
| 211 | break; |
||
| 212 | case 'export': |
||
| 213 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-reports' === $page && 'export' === $view ) { |
||
| 214 | $found = true; |
||
| 215 | } |
||
| 216 | break; |
||
| 217 | case 'logs': |
||
| 218 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-reports' === $page && 'logs' === $view ) { |
||
| 219 | $found = true; |
||
| 220 | } |
||
| 221 | break; |
||
| 222 | default: |
||
| 223 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-reports' === $page ) { |
||
| 224 | $found = true; |
||
| 225 | } |
||
| 226 | break; |
||
| 227 | } |
||
| 228 | break; |
||
| 229 | case 'settings': |
||
| 230 | switch ( $passed_view ) { |
||
| 231 | case 'general': |
||
| 232 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-settings' === $page && ( 'general' === $tab || false === $tab ) ) { |
||
| 233 | $found = true; |
||
| 234 | } |
||
| 235 | break; |
||
| 236 | case 'gateways': |
||
| 237 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-settings' === $page && 'gateways' === $tab ) { |
||
| 238 | $found = true; |
||
| 239 | } |
||
| 240 | break; |
||
| 241 | case 'emails': |
||
| 242 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-settings' === $page && 'emails' === $tab ) { |
||
| 243 | $found = true; |
||
| 244 | } |
||
| 245 | break; |
||
| 246 | case 'display': |
||
| 247 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-settings' === $page && 'display' === $tab ) { |
||
| 248 | $found = true; |
||
| 249 | } |
||
| 250 | break; |
||
| 251 | case 'licenses': |
||
| 252 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-settings' === $page && 'licenses' === $tab ) { |
||
| 253 | $found = true; |
||
| 254 | } |
||
| 255 | break; |
||
| 256 | case 'api': |
||
| 257 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-settings' === $page && 'api' === $tab ) { |
||
| 258 | $found = true; |
||
| 259 | } |
||
| 260 | break; |
||
| 261 | case 'advanced': |
||
| 262 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-settings' === $page && 'advanced' === $tab ) { |
||
| 263 | $found = true; |
||
| 264 | } |
||
| 265 | break; |
||
| 266 | case 'system_info': |
||
| 267 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-settings' === $page && 'system_info' === $tab ) { |
||
| 268 | $found = true; |
||
| 269 | } |
||
| 270 | break; |
||
| 271 | default: |
||
| 272 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-settings' === $page ) { |
||
| 273 | $found = true; |
||
| 274 | } |
||
| 275 | break; |
||
| 276 | } |
||
| 277 | break; |
||
| 278 | case 'addons': |
||
| 279 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-addons' === $page ) { |
||
| 280 | $found = true; |
||
| 281 | } |
||
| 282 | break; |
||
| 283 | case 'donors': |
||
| 284 | switch ( $passed_view ) { |
||
| 285 | case 'list-table': |
||
| 286 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-donors' === $page && false === $view ) { |
||
| 287 | $found = true; |
||
| 288 | } |
||
| 289 | break; |
||
| 290 | case 'overview': |
||
| 291 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-donors' === $page && 'overview' === $view ) { |
||
| 292 | $found = true; |
||
| 293 | } |
||
| 294 | break; |
||
| 295 | case 'notes': |
||
| 296 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-donors' === $page && 'notes' === $view ) { |
||
| 297 | $found = true; |
||
| 298 | } |
||
| 299 | break; |
||
| 300 | default: |
||
| 301 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-donors' === $page ) { |
||
| 302 | $found = true; |
||
| 303 | } |
||
| 304 | break; |
||
| 305 | } |
||
| 306 | break; |
||
| 307 | case 'reports': |
||
| 308 | if ( ( 'give_forms' == $typenow || 'give_forms' === $post_type ) && $pagenow == 'edit.php' && 'give-reports' === $page ) { |
||
| 309 | $found = true; |
||
| 310 | } |
||
| 311 | break; |
||
| 312 | default: |
||
| 313 | global $give_payments_page, $give_settings_page, $give_reports_page, $give_system_info_page, $give_add_ons_page, $give_settings_export, $give_upgrades_screen, $give_customers_page, $give_tools_page; |
||
| 314 | |||
| 315 | $admin_pages = apply_filters( 'give_admin_pages', array( |
||
| 316 | $give_payments_page, |
||
| 317 | $give_settings_page, |
||
| 318 | $give_reports_page, |
||
| 319 | $give_system_info_page, |
||
| 320 | $give_add_ons_page, |
||
| 321 | $give_upgrades_screen, |
||
| 322 | $give_settings_export, |
||
| 323 | $give_customers_page, |
||
| 324 | $give_tools_page, |
||
| 325 | 'widgets.php' |
||
| 326 | ) ); |
||
| 327 | if ( 'give_forms' == $typenow || 'index.php' == $pagenow || 'post-new.php' == $pagenow || 'post.php' == $pagenow ) { |
||
| 328 | $found = true; |
||
| 329 | if ( 'give-upgrades' === $page ) { |
||
| 330 | $found = false; |
||
| 331 | } |
||
| 332 | } elseif ( in_array( $pagenow, $admin_pages ) ) { |
||
| 333 | $found = true; |
||
| 334 | } |
||
| 335 | break; |
||
| 336 | } |
||
| 337 | |||
| 338 | return (bool) apply_filters( 'give_is_admin_page', $found, $page, $view, $passed_page, $passed_view ); |
||
| 339 | |||
| 340 | } |
||
| 341 | |||
| 467 | add_filter( 'give_default_setting_tab_give-reports', 'give_set_default_tab_form_reports_page', 10, 1 ); |
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.