| Conditions | 2 |
| Paths | 2 |
| Total Lines | 89 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 45 | public function get_settings() { |
||
| 46 | $settings = array(); |
||
| 47 | $current_section = give_get_current_setting_section(); |
||
| 48 | |||
| 49 | switch ( $current_section ) { |
||
| 50 | case 'email-settings' : |
||
| 51 | $settings = array( |
||
| 52 | |||
| 53 | // Section 1: Email Notification Listing. |
||
| 54 | array( |
||
| 55 | 'desc' => __( 'Email notifications sent from Give are listed below. Click on an email to configure it.', 'give' ), |
||
| 56 | 'type' => 'title', |
||
| 57 | 'id' => 'give_email_notification_settings', |
||
| 58 | 'table_html' => false, |
||
| 59 | ), |
||
| 60 | array( |
||
| 61 | 'type' => 'email_notification', |
||
| 62 | ), |
||
| 63 | array( |
||
| 64 | 'type' => 'sectionend', |
||
| 65 | 'id' => 'give_email_notification_settings', |
||
| 66 | ), |
||
| 67 | |||
| 68 | // Section 2: Email Sender Setting |
||
| 69 | array( |
||
| 70 | 'title' => __( 'Email Sender Options', 'give' ), |
||
| 71 | 'id' => 'give_title_email_settings_1', |
||
| 72 | 'type' => 'title', |
||
| 73 | ), |
||
| 74 | array( |
||
| 75 | 'id' => 'email_template', |
||
| 76 | 'name' => esc_html__( 'Email Template', 'give' ), |
||
| 77 | 'desc' => esc_html__( 'Choose your template from the available registered template types.', 'give' ), |
||
| 78 | 'type' => 'select', |
||
| 79 | 'options' => give_get_email_templates(), |
||
| 80 | ), |
||
| 81 | array( |
||
| 82 | 'id' => 'email_logo', |
||
| 83 | 'name' => esc_html__( 'Logo', 'give' ), |
||
| 84 | 'desc' => esc_html__( 'Upload or choose a logo to be displayed at the top of the donation receipt emails. Displayed on HTML emails only.', 'give' ), |
||
| 85 | 'type' => 'file', |
||
| 86 | ), |
||
| 87 | array( |
||
| 88 | 'id' => 'from_name', |
||
| 89 | 'name' => esc_html__( 'From Name', 'give' ), |
||
| 90 | 'desc' => esc_html__( 'The name which appears in the "From" field in all Give donation emails.', 'give' ), |
||
| 91 | 'default' => get_bloginfo( 'name' ), |
||
| 92 | 'type' => 'text', |
||
| 93 | ), |
||
| 94 | array( |
||
| 95 | 'id' => 'from_email', |
||
| 96 | 'name' => esc_html__( 'From Email', 'give' ), |
||
| 97 | 'desc' => esc_html__( 'Email address from which all Give emails are sent from. This will act as the "from" and "reply-to" email address.', 'give' ), |
||
| 98 | 'default' => get_bloginfo( 'admin_email' ), |
||
| 99 | 'type' => 'text', |
||
| 100 | ), |
||
| 101 | array( |
||
| 102 | 'name' => esc_html__( 'Donation Notification Settings Docs Link', 'give' ), |
||
| 103 | 'id' => 'donation_notification_settings_docs_link', |
||
| 104 | 'url' => esc_url( 'http://docs.givewp.com/settings-donation-notification' ), |
||
| 105 | 'title' => __( 'Donation Notification Settings', 'give' ), |
||
| 106 | 'type' => 'give_docs_link', |
||
| 107 | ), |
||
| 108 | array( |
||
| 109 | 'id' => 'give_title_email_settings_3', |
||
| 110 | 'type' => 'sectionend', |
||
| 111 | ), |
||
| 112 | ); |
||
| 113 | break; |
||
| 114 | }// End switch(). |
||
| 115 | |||
| 116 | /** |
||
| 117 | * Filter the emails settings. |
||
| 118 | * Backward compatibility: Please do not use this filter. This filter is deprecated in 1.8 |
||
| 119 | */ |
||
| 120 | $settings = apply_filters( 'give_settings_emails', $settings ); |
||
| 121 | |||
| 122 | /** |
||
| 123 | * Filter the settings. |
||
| 124 | * |
||
| 125 | * @since 1.8 |
||
| 126 | * |
||
| 127 | * @param array $settings |
||
| 128 | */ |
||
| 129 | $settings = apply_filters( 'give_get_settings_' . $this->id, $settings ); |
||
| 130 | |||
| 131 | // Output. |
||
| 132 | return $settings; |
||
| 133 | } |
||
| 134 | |||
| 189 |