Issues in class-settings-system-info.php - New Issues - Inspection of "Merge pull request #1940 from WordImpress/issue/18..." - ravinderk/Give - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — release/1.8.12 ( b58a2f...d255b1 )

by Ravinder

created 2018-08-27 05:28 UTC

admin/tools/class-settings-system-info.php (3 issues)

Labels

Severity

Informational 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Give Settings Page/Tab
 *
 * @package     Give
 * @subpackage  Classes/Give_Settings_System_Info
 * @copyright   Copyright (c) 2016, WordImpress
 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
 * @since       1.8
 */

if ( ! defined( 'ABSPATH' ) ) {
	exit; // Exit if accessed directly
}

if ( ! class_exists( 'Give_Settings_System_Info' ) ) :

	/**
	 * Give_Settings_System_Info.
	 *
	 * @sine 1.8
	 */
	class Give_Settings_System_Info {

		/**
		 * Setting page id.
		 *
		 * @since 1.8
		 * @var   string
		 */
		protected $id = '';

		/**
		 * Setting page label.
		 *
		 * @since 1.8
		 * @var   string
		 */
		protected $label = '';

		/**
		 * Constructor.
		 */
		public function __construct() {

			$this->id    = 'system-info';
			$this->label = esc_html__( 'System Info', 'give' );

			add_filter( 'give-tools_tabs_array', array( $this, 'add_settings_page' ), 20 );
			add_action( "give-tools_settings_{$this->id}_page", array( $this, 'output' ) );

			// Do not use main form for this tab.
			if ( give_get_current_setting_tab() === $this->id ) {
				add_action( "give-tools_open_form", '__return_empty_string' );
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
				add_action( "give-tools_close_form", '__return_empty_string' );
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			}
		}

		/**
		 * Add this page to settings.
		 *
		 * @since  1.8
		 *
		 * @param  array $pages Lst of pages.
		 *
		 * @return array
		 */
		public function add_settings_page( $pages ) {
			$pages[ $this->id ] = $this->label;

			return $pages;
		}

		/**
		 * Output the settings.
		 *
		 * @since  1.8
		 * @return void
		 */
		public function output() {
			$GLOBALS['give_hide_save_button'] = true;
			include_once( 'views/html-admin-page-system-info.php' );
		}
	}

endif;

return new Give_Settings_System_Info();


1		<?php
2		/**
3		* Give Settings Page/Tab
4		*
5		* @package Give
6		* @subpackage Classes/Give_Settings_System_Info
7		* @copyright Copyright (c) 2016, WordImpress
8		* @license http://opensource.org/licenses/gpl-2.0.php GNU Public License
9		* @since 1.8
10		*/
11
12		if ( ! defined( 'ABSPATH' ) ) {
13		exit; // Exit if accessed directly
14		}
15
16		if ( ! class_exists( 'Give_Settings_System_Info' ) ) :
17
18		/**
19		* Give_Settings_System_Info.
20		*
21		* @sine 1.8
22		*/
23		class Give_Settings_System_Info {
24
25		/**
26		* Setting page id.
27		*
28		* @since 1.8
29		* @var string
30		*/
31		protected $id = '';
32
33		/**
34		* Setting page label.
35		*
36		* @since 1.8
37		* @var string
38		*/
39		protected $label = '';
40
41		/**
42		* Constructor.
43		*/
44	View Code Duplication	public function __construct() {
		0 ignored issues – show Duplication introduced 2017-08-01 08:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		$this->id = 'system-info';
46		$this->label = esc_html__( 'System Info', 'give' );
47
48		add_filter( 'give-tools_tabs_array', array( $this, 'add_settings_page' ), 20 );
49		add_action( "give-tools_settings_{$this->id}_page", array( $this, 'output' ) );
50
51		// Do not use main form for this tab.
52		if ( give_get_current_setting_tab() === $this->id ) {
53		add_action( "give-tools_open_form", '__return_empty_string' );
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-08-01 08:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `give-tools_open_form` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
54		add_action( "give-tools_close_form", '__return_empty_string' );
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-08-01 08:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `give-tools_close_form` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
55		}
56		}
57
58		/**
59		* Add this page to settings.
60		*
61		* @since 1.8
62		*
63		* @param array $pages Lst of pages.
64		*
65		* @return array
66		*/
67		public function add_settings_page( $pages ) {
68		$pages[ $this->id ] = $this->label;
69
70		return $pages;
71		}
72
73		/**
74		* Output the settings.
75		*
76		* @since 1.8
77		* @return void
78		*/
79		public function output() {
80		$GLOBALS['give_hide_save_button'] = true;
81		include_once( 'views/html-admin-page-system-info.php' );
82		}
83		}
84
85		endif;
86
87		return new Give_Settings_System_Info();
88

ravinderk / Give

Push — release/1.8.12 ( b58a2f...d255b1 )

admin/tools/class-settings-system-info.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like