Issues in give.php - All Issues - Inspection of "Merge pull request #1403 from mathetos/release/1.8" - ravinderk/Give - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0af146...28843d )

by Ravinder

created 2017-01-19 08:39 UTC

give.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Plugin Name: Give - Donation Plugin
 * Plugin URI: https://givewp.com
 * Description: The most robust, flexible, and intuitive way to accept donations on WordPress.
 * Author: WordImpress
 * Author URI: https://wordimpress.com
 * Version: 1.8
 * Text Domain: give
 * Domain Path: /languages
 * GitHub Plugin URI: https://github.com/WordImpress/Give
 *
 * Give is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * any later version.
 *
 * Give is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with Give. If not, see <https://www.gnu.org/licenses/>.
 *
 * A Tribute to Open Source:
 *
 * "Open source software is software that can be freely used, changed, and shared (in modified or unmodified form) by anyone. Open
 * source software is made by many people, and distributed under licenses that comply with the Open Source Definition."
 *
 * -- The Open Source Initiative
 *
 * Give is a tribute to the spirit and philosophy of Open Source. We at WordImpress gladly embrace the Open Source philosophy both
 * in how Give itself was developed, and how we hope to see others build more from our code base.
 *
 * Give would not have been possible without the tireless efforts of WordPress and the surrounding Open Source projects and their talented developers. Thank you all for your contribution to WordPress.
 *
 * - The WordImpress Team
 *
 */

// Exit if accessed directly.
if ( ! defined( 'ABSPATH' ) ) {
	exit;
}

if ( ! class_exists( 'Give' ) ) :

	/**
	 * Main Give Class
	 *
	 * @since 1.0
	 */
	final class Give {
		/** Singleton *************************************************************/

		/**
		 * Give Instance
		 *
		 * @since  1.0
		 * @access private
		 *
		 * @var    Give The one true Give
		 */
		private static $instance;

		/**
		 * Give Roles Object
		 *
		 * @since  1.0
		 * @access public
		 *
		 * @var    Give_Roles object
		 */
		public $roles;

		/**
		 * Give Settings Object
		 *
		 * @since  1.0
		 * @access public
		 *
		 * @var    Give_Plugin_Settings object
		 */
		public $give_settings;

		/**
		 * Give Session Object
		 *
		 * This holds donation data for user's session.
		 *
		 * @since  1.0
		 * @access public
		 *
		 * @var    Give_Session object
		 */
		public $session;

		/**
		 * Give HTML Element Helper Object
		 *
		 * @since  1.0
		 * @access public
		 *
		 * @var    Give_HTML_Elements object
		 */
		public $html;

		/**
		 * Give Emails Object
		 *
		 * @since  1.0
		 * @access public
		 *
		 * @var    Give_Emails object
		 */
		public $emails;

		/**
		 * Give Email Template Tags Object
		 *
		 * @since  1.0
		 * @access public
		 *
		 * @var    Give_Email_Template_Tags object
		 */
		public $email_tags;

		/**
		 * Give Customers DB Object
		 *
		 * @since  1.0
		 * @access public
		 *
		 * @var    Give_DB_Customers object
		 */
		public $customers;

		/**
		 * Give Customer meta DB Object
		 *
		 * @since  1.6
		 * @access public
		 *
		 * @var    Give_DB_Customer_Meta object
		 */
		public $customer_meta;

		/**
		 * Give API Object
		 *
		 * @since  1.0
		 * @access public
		 *
		 * @var    Give_API object
		 */
		public $api;

		/**
		 * Give Template Loader Object
		 *
		 * @since  1.0
		 * @access public
		 *
		 * @var    Give_Template_Loader object
		 */
		public $template_loader;

		/**
		 * Give No Login Object
		 *
		 * @since  1.0
		 * @access public
		 *
		 * @var    Give_Email_Access object
		 */
		public $email_access;

		/**
		 * Main Give Instance
		 *
		 * Insures that only one instance of Give exists in memory at any one
		 * time. Also prevents needing to define globals all over the place.
		 *
		 * @since     1.0
		 * @access    public
		 *
		 * @static
		 * @staticvar array $instance
		 * @uses      Give::setup_constants() Setup the constants needed.
		 * @uses      Give::includes() Include the required files.
		 * @uses      Give::load_textdomain() load the language files.
		 * @see       Give()
		 *
		 * @return    Give
		 */
		public static function instance() {
			if ( ! isset( self::$instance ) && ! ( self::$instance instanceof Give ) ) {
				self::$instance = new Give;
				self::$instance->setup_constants();

				add_action( 'plugins_loaded', array( self::$instance, 'load_textdomain' ) );

				self::$instance->includes();
				self::$instance->roles           = new Give_Roles();
				self::$instance->api             = new Give_API();
				self::$instance->give_settings   = new Give_Admin_Settings();
				self::$instance->session         = new Give_Session();
				self::$instance->html            = new Give_HTML_Elements();
				self::$instance->emails          = new Give_Emails();
				self::$instance->email_tags      = new Give_Email_Template_Tags();
				self::$instance->customers       = new Give_DB_Customers();
				self::$instance->customer_meta   = new Give_DB_Customer_Meta();
				self::$instance->template_loader = new Give_Template_Loader();
				self::$instance->email_access    = new Give_Email_Access();

			}

			return self::$instance;
		}

		/**
		 * Throw error on object clone
		 *
		 * The whole idea of the singleton design pattern is that there is a single
		 * object, therefore we don't want the object to be cloned.
		 *
		 * @since  1.0
		 * @access protected
		 *
		 * @return void
		 */
		public function __clone() {
			// Cloning instances of the class is forbidden
			_doing_it_wrong( __FUNCTION__, __( 'Cheatin&#8217; huh?', 'give' ), '1.0' );
		}

		/**
		 * Disable unserializing of the class
		 *
		 * @since  1.0
		 * @access protected
		 *
		 * @return void
		 */
		public function __wakeup() {
			// Unserializing instances of the class is forbidden.
			_doing_it_wrong( __FUNCTION__, __( 'Cheatin&#8217; huh?', 'give' ), '1.0' );
		}

		/**
		 * Setup plugin constants
		 *
		 * @since  1.0
		 * @access private
		 *
		 * @return void
		 */
		private function setup_constants() {

			// Plugin version
			if ( ! defined( 'GIVE_VERSION' ) ) {
				define( 'GIVE_VERSION', '1.8' );
			}

			// Plugin Folder Path
			if ( ! defined( 'GIVE_PLUGIN_DIR' ) ) {
				define( 'GIVE_PLUGIN_DIR', plugin_dir_path( __FILE__ ) );
			}

			// Plugin Folder URL
			if ( ! defined( 'GIVE_PLUGIN_URL' ) ) {
				define( 'GIVE_PLUGIN_URL', plugin_dir_url( __FILE__ ) );
			}

			// Plugin Basename aka: "give/give.php"
			if ( ! defined( 'GIVE_PLUGIN_BASENAME' ) ) {
				define( 'GIVE_PLUGIN_BASENAME', plugin_basename( __FILE__ ) );
			}

			// Plugin Root File
			if ( ! defined( 'GIVE_PLUGIN_FILE' ) ) {
				define( 'GIVE_PLUGIN_FILE', __FILE__ );
			}

			// Make sure CAL_GREGORIAN is defined
			if ( ! defined( 'CAL_GREGORIAN' ) ) {
				define( 'CAL_GREGORIAN', 1 );
			}
		}

		/**
		 * Include required files
		 *
		 * @since  1.0
		 * @access private
		 *
		 * @return void
		 */
		private function includes() {
			global $give_options;
function myFunction($a, $b) {
    // Do something
}

			require_once GIVE_PLUGIN_DIR . 'includes/admin/class-admin-settings.php';
			require_once GIVE_PLUGIN_DIR . 'includes/admin/class-give-settings.php';
			$give_options = give_get_settings();

			require_once GIVE_PLUGIN_DIR . 'includes/admin/give-metabox-functions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/post-types.php';
			require_once GIVE_PLUGIN_DIR . 'includes/scripts.php';
			require_once GIVE_PLUGIN_DIR . 'includes/ajax-functions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/actions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/filters.php';
			require_once GIVE_PLUGIN_DIR . 'includes/api/class-give-api.php';

			require_once GIVE_PLUGIN_DIR . 'includes/class-give-roles.php';
			require_once GIVE_PLUGIN_DIR . 'includes/class-give-template-loader.php';
			require_once GIVE_PLUGIN_DIR . 'includes/class-give-donate-form.php';
			require_once GIVE_PLUGIN_DIR . 'includes/class-give-db.php';
			require_once GIVE_PLUGIN_DIR . 'includes/class-give-db-customers.php';
			require_once GIVE_PLUGIN_DIR . 'includes/class-give-db-customer-meta.php';
			require_once GIVE_PLUGIN_DIR . 'includes/class-give-customer.php';
			require_once GIVE_PLUGIN_DIR . 'includes/class-give-stats.php';
			require_once GIVE_PLUGIN_DIR . 'includes/class-give-session.php';
			require_once GIVE_PLUGIN_DIR . 'includes/class-give-html-elements.php';
			require_once GIVE_PLUGIN_DIR . 'includes/class-give-logging.php';
			require_once GIVE_PLUGIN_DIR . 'includes/class-give-license-handler.php';
			require_once GIVE_PLUGIN_DIR . 'includes/class-give-cron.php';
			require_once GIVE_PLUGIN_DIR . 'includes/class-give-email-access.php';

			require_once GIVE_PLUGIN_DIR . 'includes/country-functions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/template-functions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/misc-functions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/forms/functions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/forms/template.php';
			require_once GIVE_PLUGIN_DIR . 'includes/forms/widget.php';
			require_once GIVE_PLUGIN_DIR . 'includes/shortcodes.php';
			require_once GIVE_PLUGIN_DIR . 'includes/formatting.php';
			require_once GIVE_PLUGIN_DIR . 'includes/price-functions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/error-tracking.php';
			require_once GIVE_PLUGIN_DIR . 'includes/process-donation.php';
			require_once GIVE_PLUGIN_DIR . 'includes/login-register.php';
			require_once GIVE_PLUGIN_DIR . 'includes/user-functions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/plugin-compatibility.php';
			require_once GIVE_PLUGIN_DIR . 'includes/deprecated/deprecated-functions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/deprecated/deprecated-actions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/deprecated/deprecated-filters.php';

			require_once GIVE_PLUGIN_DIR . 'includes/payments/functions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/payments/actions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/payments/class-payment-stats.php';
			require_once GIVE_PLUGIN_DIR . 'includes/payments/class-payments-query.php';
			require_once GIVE_PLUGIN_DIR . 'includes/payments/class-give-payment.php';

			require_once GIVE_PLUGIN_DIR . 'includes/gateways/functions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/gateways/actions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/gateways/paypal-standard.php';
			require_once GIVE_PLUGIN_DIR . 'includes/gateways/offline-donations.php';
			require_once GIVE_PLUGIN_DIR . 'includes/gateways/manual.php';

			require_once GIVE_PLUGIN_DIR . 'includes/emails/class-give-emails.php';
			require_once GIVE_PLUGIN_DIR . 'includes/emails/class-give-email-tags.php';
			require_once GIVE_PLUGIN_DIR . 'includes/emails/functions.php';
			require_once GIVE_PLUGIN_DIR . 'includes/emails/template.php';
			require_once GIVE_PLUGIN_DIR . 'includes/emails/actions.php';

            if( defined( 'WP_CLI' ) && WP_CLI ) {
                require_once GIVE_PLUGIN_DIR . 'includes/class-give-cli-commands.php';
            }

			if ( is_admin() || ( defined( 'WP_CLI' ) && WP_CLI ) ) {

				require_once GIVE_PLUGIN_DIR . 'includes/admin/admin-footer.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/welcome.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/admin-pages.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/class-admin-notices.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/class-api-keys-table.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/class-i18n-module.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/admin-actions.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/admin-filters.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/system-info.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/add-ons.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/plugins.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/dashboard-widgets.php';

				require_once GIVE_PLUGIN_DIR . 'includes/admin/payments/actions.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/payments/payments-history.php';

				require_once GIVE_PLUGIN_DIR . 'includes/admin/customers/customers.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/customers/customer-functions.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/customers/customer-actions.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/forms/metabox.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/forms/class-metabox-form-data.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/forms/dashboard-columns.php';

				require_once GIVE_PLUGIN_DIR . 'includes/admin/reporting/export/export-functions.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/reporting/reports.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/reporting/tools.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/reporting/tools/tools-actions.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/reporting/pdf-reports.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/reporting/class-give-graph.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/reporting/graphing.php';

				require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/abstract-shortcode-generator.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/class-shortcode-button.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/shortcode-give-form.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/shortcode-give-goal.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/shortcode-give-login.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/shortcode-give-register.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/shortcode-give-profile-editor.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/shortcode-give-donation-history.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/shortcode-give-receipt.php';

				require_once GIVE_PLUGIN_DIR . 'includes/admin/upgrades/upgrade-functions.php';
				require_once GIVE_PLUGIN_DIR . 'includes/admin/upgrades/upgrades.php';

			}

			require_once GIVE_PLUGIN_DIR . 'includes/install.php';

		}

		/**
		 * Loads the plugin language files
		 *
		 * @since  1.0
		 * @access public
		 *
		 * @return void
		 */
		public function load_textdomain() {
			// Set filter for Give's languages directory
			$give_lang_dir = dirname( plugin_basename( GIVE_PLUGIN_FILE ) ) . '/languages/';
			$give_lang_dir = apply_filters( 'give_languages_directory', $give_lang_dir );

			// Traditional WordPress plugin locale filter
			$locale = apply_filters( 'plugin_locale', get_locale(), 'give' );
			$mofile = sprintf( '%1$s-%2$s.mo', 'give', $locale );

			// Setup paths to current locale file
			$mofile_local  = $give_lang_dir . $mofile;
			$mofile_global = WP_LANG_DIR . '/give/' . $mofile;

			if ( file_exists( $mofile_global ) ) {
				// Look in global /wp-content/languages/give folder
				load_textdomain( 'give', $mofile_global );
			} elseif ( file_exists( $mofile_local ) ) {
				// Look in local location from filter `give_languages_directory`
				load_textdomain( 'give', $mofile_local );
			} else {
				// Load the default language files packaged up w/ Give
				load_plugin_textdomain( 'give', false, $give_lang_dir );
			}
		}

	}

endif; // End if class_exists check


/**
 * Start Give 
 * 
 * The main function responsible for returning the one true Give instance to functions everywhere.
 *
 * Use this function like you would a global variable, except without needing
 * to declare the global.
 *
 * Example: <?php $give = Give(); ?>
 *
 * @since 1.0
 * @return object|Give 
 */
function Give() {
	return Give::instance();
}

// Get Give Running
Give();


Push — master ( 0af146...28843d )

give.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-12-08 11:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 54 and the first side effect is on line 44. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* Plugin Name: Give - Donation Plugin
4			* Plugin URI: https://givewp.com
5			* Description: The most robust, flexible, and intuitive way to accept donations on WordPress.
6			* Author: WordImpress
7			* Author URI: https://wordimpress.com
8			* Version: 1.8
9			* Text Domain: give
10			* Domain Path: /languages
11			* GitHub Plugin URI: https://github.com/WordImpress/Give
12			*
13			* Give is free software: you can redistribute it and/or modify
14			* it under the terms of the GNU General Public License as published by
15			* the Free Software Foundation, either version 3 of the License, or
16			* any later version.
17			*
18			* Give is distributed in the hope that it will be useful,
19			* but WITHOUT ANY WARRANTY; without even the implied warranty of
20			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21			* GNU General Public License for more details.
22			*
23			* You should have received a copy of the GNU General Public License
24			* along with Give. If not, see <https://www.gnu.org/licenses/>.
25			*
26			* A Tribute to Open Source:
27			*
28			* "Open source software is software that can be freely used, changed, and shared (in modified or unmodified form) by anyone. Open
29			* source software is made by many people, and distributed under licenses that comply with the Open Source Definition."
30			*
31			* -- The Open Source Initiative
32			*
33			* Give is a tribute to the spirit and philosophy of Open Source. We at WordImpress gladly embrace the Open Source philosophy both
34			* in how Give itself was developed, and how we hope to see others build more from our code base.
35			*
36			* Give would not have been possible without the tireless efforts of WordPress and the surrounding Open Source projects and their talented developers. Thank you all for your contribution to WordPress.
37			*
38			* - The WordImpress Team
39			*
40			*/
41
42			// Exit if accessed directly.
43			if ( ! defined( 'ABSPATH' ) ) {
44			exit;
45			}
46
47			if ( ! class_exists( 'Give' ) ) :
48
49			/**
50			* Main Give Class
51			*
52			* @since 1.0
53			*/
54			final class Give {
55			/ Singleton ***********************************************************/
56
57			/**
58			* Give Instance
59			*
60			* @since 1.0
61			* @access private
62			*
63			* @var Give The one true Give
64			*/
65			private static $instance;
66
67			/**
68			* Give Roles Object
69			*
70			* @since 1.0
71			* @access public
72			*
73			* @var Give_Roles object
74			*/
75			public $roles;
76
77			/**
78			* Give Settings Object
79			*
80			* @since 1.0
81			* @access public
82			*
83			* @var Give_Plugin_Settings object
84			*/
85			public $give_settings;
86
87			/**
88			* Give Session Object
89			*
90			* This holds donation data for user's session.
91			*
92			* @since 1.0
93			* @access public
94			*
95			* @var Give_Session object
96			*/
97			public $session;
98
99			/**
100			* Give HTML Element Helper Object
101			*
102			* @since 1.0
103			* @access public
104			*
105			* @var Give_HTML_Elements object
106			*/
107			public $html;
108
109			/**
110			* Give Emails Object
111			*
112			* @since 1.0
113			* @access public
114			*
115			* @var Give_Emails object
116			*/
117			public $emails;
118
119			/**
120			* Give Email Template Tags Object
121			*
122			* @since 1.0
123			* @access public
124			*
125			* @var Give_Email_Template_Tags object
126			*/
127			public $email_tags;
128
129			/**
130			* Give Customers DB Object
131			*
132			* @since 1.0
133			* @access public
134			*
135			* @var Give_DB_Customers object
136			*/
137			public $customers;
138
139			/**
140			* Give Customer meta DB Object
141			*
142			* @since 1.6
143			* @access public
144			*
145			* @var Give_DB_Customer_Meta object
146			*/
147			public $customer_meta;
148
149			/**
150			* Give API Object
151			*
152			* @since 1.0
153			* @access public
154			*
155			* @var Give_API object
156			*/
157			public $api;
158
159			/**
160			* Give Template Loader Object
161			*
162			* @since 1.0
163			* @access public
164			*
165			* @var Give_Template_Loader object
166			*/
167			public $template_loader;
168
169			/**
170			* Give No Login Object
171			*
172			* @since 1.0
173			* @access public
174			*
175			* @var Give_Email_Access object
176			*/
177			public $email_access;
178
179			/**
180			* Main Give Instance
181			*
182			* Insures that only one instance of Give exists in memory at any one
183			* time. Also prevents needing to define globals all over the place.
184			*
185			* @since 1.0
186			* @access public
187			*
188			* @static
189			* @staticvar array $instance
190			* @uses Give::setup_constants() Setup the constants needed.
191			* @uses Give::includes() Include the required files.
192			* @uses Give::load_textdomain() load the language files.
193			* @see Give()
194			*
195			* @return Give
196			*/
197			public static function instance() {
198			if ( ! isset( self::$instance ) && ! ( self::$instance instanceof Give ) ) {
199			self::$instance = new Give;
200			self::$instance->setup_constants();
201
202			add_action( 'plugins_loaded', array( self::$instance, 'load_textdomain' ) );
203
204			self::$instance->includes();
205			self::$instance->roles = new Give_Roles();
206			self::$instance->api = new Give_API();
207			self::$instance->give_settings = new Give_Admin_Settings();
208			self::$instance->session = new Give_Session();
209			self::$instance->html = new Give_HTML_Elements();
210			self::$instance->emails = new Give_Emails();
211			self::$instance->email_tags = new Give_Email_Template_Tags();
212			self::$instance->customers = new Give_DB_Customers();
213			self::$instance->customer_meta = new Give_DB_Customer_Meta();
214			self::$instance->template_loader = new Give_Template_Loader();
215			self::$instance->email_access = new Give_Email_Access();
216
217			}
218
219			return self::$instance;
220			}
221
222			/**
223			* Throw error on object clone
224			*
225			* The whole idea of the singleton design pattern is that there is a single
226			* object, therefore we don't want the object to be cloned.
227			*
228			* @since 1.0
229			* @access protected
230			*
231			* @return void
232			*/
233			public function __clone() {
234			// Cloning instances of the class is forbidden
235			_doing_it_wrong( __FUNCTION__, __( 'Cheatin’ huh?', 'give' ), '1.0' );
236			}
237
238			/**
239			* Disable unserializing of the class
240			*
241			* @since 1.0
242			* @access protected
243			*
244			* @return void
245			*/
246			public function __wakeup() {
247			// Unserializing instances of the class is forbidden.
248			_doing_it_wrong( __FUNCTION__, __( 'Cheatin’ huh?', 'give' ), '1.0' );
249			}
250
251			/**
252			* Setup plugin constants
253			*
254			* @since 1.0
255			* @access private
256			*
257			* @return void
258			*/
259			private function setup_constants() {
260
261			// Plugin version
262			if ( ! defined( 'GIVE_VERSION' ) ) {
263			define( 'GIVE_VERSION', '1.8' );
264			}
265
266			// Plugin Folder Path
267			if ( ! defined( 'GIVE_PLUGIN_DIR' ) ) {
268			define( 'GIVE_PLUGIN_DIR', plugin_dir_path( __FILE__ ) );
269			}
270
271			// Plugin Folder URL
272			if ( ! defined( 'GIVE_PLUGIN_URL' ) ) {
273			define( 'GIVE_PLUGIN_URL', plugin_dir_url( __FILE__ ) );
274			}
275
276			// Plugin Basename aka: "give/give.php"
277			if ( ! defined( 'GIVE_PLUGIN_BASENAME' ) ) {
278			define( 'GIVE_PLUGIN_BASENAME', plugin_basename( __FILE__ ) );
279			}
280
281			// Plugin Root File
282			if ( ! defined( 'GIVE_PLUGIN_FILE' ) ) {
283			define( 'GIVE_PLUGIN_FILE', __FILE__ );
284			}
285
286			// Make sure CAL_GREGORIAN is defined
287			if ( ! defined( 'CAL_GREGORIAN' ) ) {
288			define( 'CAL_GREGORIAN', 1 );
289			}
290			}
291
292			/**
293			* Include required files
294			*
295			* @since 1.0
296			* @access private
297			*
298			* @return void
299			*/
300			private function includes() {
301			global $give_options;
			0 ignored issues – show Compatibility Best Practice introduced 2016-12-08 11:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
302
303			require_once GIVE_PLUGIN_DIR . 'includes/admin/class-admin-settings.php';
304			require_once GIVE_PLUGIN_DIR . 'includes/admin/class-give-settings.php';
305			$give_options = give_get_settings();
306
307			require_once GIVE_PLUGIN_DIR . 'includes/admin/give-metabox-functions.php';
308			require_once GIVE_PLUGIN_DIR . 'includes/post-types.php';
309			require_once GIVE_PLUGIN_DIR . 'includes/scripts.php';
310			require_once GIVE_PLUGIN_DIR . 'includes/ajax-functions.php';
311			require_once GIVE_PLUGIN_DIR . 'includes/actions.php';
312			require_once GIVE_PLUGIN_DIR . 'includes/filters.php';
313			require_once GIVE_PLUGIN_DIR . 'includes/api/class-give-api.php';
314
315			require_once GIVE_PLUGIN_DIR . 'includes/class-give-roles.php';
316			require_once GIVE_PLUGIN_DIR . 'includes/class-give-template-loader.php';
317			require_once GIVE_PLUGIN_DIR . 'includes/class-give-donate-form.php';
318			require_once GIVE_PLUGIN_DIR . 'includes/class-give-db.php';
319			require_once GIVE_PLUGIN_DIR . 'includes/class-give-db-customers.php';
320			require_once GIVE_PLUGIN_DIR . 'includes/class-give-db-customer-meta.php';
321			require_once GIVE_PLUGIN_DIR . 'includes/class-give-customer.php';
322			require_once GIVE_PLUGIN_DIR . 'includes/class-give-stats.php';
323			require_once GIVE_PLUGIN_DIR . 'includes/class-give-session.php';
324			require_once GIVE_PLUGIN_DIR . 'includes/class-give-html-elements.php';
325			require_once GIVE_PLUGIN_DIR . 'includes/class-give-logging.php';
326			require_once GIVE_PLUGIN_DIR . 'includes/class-give-license-handler.php';
327			require_once GIVE_PLUGIN_DIR . 'includes/class-give-cron.php';
328			require_once GIVE_PLUGIN_DIR . 'includes/class-give-email-access.php';
329
330			require_once GIVE_PLUGIN_DIR . 'includes/country-functions.php';
331			require_once GIVE_PLUGIN_DIR . 'includes/template-functions.php';
332			require_once GIVE_PLUGIN_DIR . 'includes/misc-functions.php';
333			require_once GIVE_PLUGIN_DIR . 'includes/forms/functions.php';
334			require_once GIVE_PLUGIN_DIR . 'includes/forms/template.php';
335			require_once GIVE_PLUGIN_DIR . 'includes/forms/widget.php';
336			require_once GIVE_PLUGIN_DIR . 'includes/shortcodes.php';
337			require_once GIVE_PLUGIN_DIR . 'includes/formatting.php';
338			require_once GIVE_PLUGIN_DIR . 'includes/price-functions.php';
339			require_once GIVE_PLUGIN_DIR . 'includes/error-tracking.php';
340			require_once GIVE_PLUGIN_DIR . 'includes/process-donation.php';
341			require_once GIVE_PLUGIN_DIR . 'includes/login-register.php';
342			require_once GIVE_PLUGIN_DIR . 'includes/user-functions.php';
343			require_once GIVE_PLUGIN_DIR . 'includes/plugin-compatibility.php';
344			require_once GIVE_PLUGIN_DIR . 'includes/deprecated/deprecated-functions.php';
345			require_once GIVE_PLUGIN_DIR . 'includes/deprecated/deprecated-actions.php';
346			require_once GIVE_PLUGIN_DIR . 'includes/deprecated/deprecated-filters.php';
347
348			require_once GIVE_PLUGIN_DIR . 'includes/payments/functions.php';
349			require_once GIVE_PLUGIN_DIR . 'includes/payments/actions.php';
350			require_once GIVE_PLUGIN_DIR . 'includes/payments/class-payment-stats.php';
351			require_once GIVE_PLUGIN_DIR . 'includes/payments/class-payments-query.php';
352			require_once GIVE_PLUGIN_DIR . 'includes/payments/class-give-payment.php';
353
354			require_once GIVE_PLUGIN_DIR . 'includes/gateways/functions.php';
355			require_once GIVE_PLUGIN_DIR . 'includes/gateways/actions.php';
356			require_once GIVE_PLUGIN_DIR . 'includes/gateways/paypal-standard.php';
357			require_once GIVE_PLUGIN_DIR . 'includes/gateways/offline-donations.php';
358			require_once GIVE_PLUGIN_DIR . 'includes/gateways/manual.php';
359
360			require_once GIVE_PLUGIN_DIR . 'includes/emails/class-give-emails.php';
361			require_once GIVE_PLUGIN_DIR . 'includes/emails/class-give-email-tags.php';
362			require_once GIVE_PLUGIN_DIR . 'includes/emails/functions.php';
363			require_once GIVE_PLUGIN_DIR . 'includes/emails/template.php';
364			require_once GIVE_PLUGIN_DIR . 'includes/emails/actions.php';
365
366			if( defined( 'WP_CLI' ) && WP_CLI ) {
367			require_once GIVE_PLUGIN_DIR . 'includes/class-give-cli-commands.php';
368			}
369
370			if ( is_admin() \|\| ( defined( 'WP_CLI' ) && WP_CLI ) ) {
371
372			require_once GIVE_PLUGIN_DIR . 'includes/admin/admin-footer.php';
373			require_once GIVE_PLUGIN_DIR . 'includes/admin/welcome.php';
374			require_once GIVE_PLUGIN_DIR . 'includes/admin/admin-pages.php';
375			require_once GIVE_PLUGIN_DIR . 'includes/admin/class-admin-notices.php';
376			require_once GIVE_PLUGIN_DIR . 'includes/admin/class-api-keys-table.php';
377			require_once GIVE_PLUGIN_DIR . 'includes/admin/class-i18n-module.php';
378			require_once GIVE_PLUGIN_DIR . 'includes/admin/admin-actions.php';
379			require_once GIVE_PLUGIN_DIR . 'includes/admin/admin-filters.php';
380			require_once GIVE_PLUGIN_DIR . 'includes/admin/system-info.php';
381			require_once GIVE_PLUGIN_DIR . 'includes/admin/add-ons.php';
382			require_once GIVE_PLUGIN_DIR . 'includes/admin/plugins.php';
383			require_once GIVE_PLUGIN_DIR . 'includes/admin/dashboard-widgets.php';
384
385			require_once GIVE_PLUGIN_DIR . 'includes/admin/payments/actions.php';
386			require_once GIVE_PLUGIN_DIR . 'includes/admin/payments/payments-history.php';
387
388			require_once GIVE_PLUGIN_DIR . 'includes/admin/customers/customers.php';
389			require_once GIVE_PLUGIN_DIR . 'includes/admin/customers/customer-functions.php';
390			require_once GIVE_PLUGIN_DIR . 'includes/admin/customers/customer-actions.php';
391			require_once GIVE_PLUGIN_DIR . 'includes/admin/forms/metabox.php';
392			require_once GIVE_PLUGIN_DIR . 'includes/admin/forms/class-metabox-form-data.php';
393			require_once GIVE_PLUGIN_DIR . 'includes/admin/forms/dashboard-columns.php';
394
395			require_once GIVE_PLUGIN_DIR . 'includes/admin/reporting/export/export-functions.php';
396			require_once GIVE_PLUGIN_DIR . 'includes/admin/reporting/reports.php';
397			require_once GIVE_PLUGIN_DIR . 'includes/admin/reporting/tools.php';
398			require_once GIVE_PLUGIN_DIR . 'includes/admin/reporting/tools/tools-actions.php';
399			require_once GIVE_PLUGIN_DIR . 'includes/admin/reporting/pdf-reports.php';
400			require_once GIVE_PLUGIN_DIR . 'includes/admin/reporting/class-give-graph.php';
401			require_once GIVE_PLUGIN_DIR . 'includes/admin/reporting/graphing.php';
402
403			require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/abstract-shortcode-generator.php';
404			require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/class-shortcode-button.php';
405			require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/shortcode-give-form.php';
406			require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/shortcode-give-goal.php';
407			require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/shortcode-give-login.php';
408			require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/shortcode-give-register.php';
409			require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/shortcode-give-profile-editor.php';
410			require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/shortcode-give-donation-history.php';
411			require_once GIVE_PLUGIN_DIR . 'includes/admin/shortcodes/shortcode-give-receipt.php';
412
413			require_once GIVE_PLUGIN_DIR . 'includes/admin/upgrades/upgrade-functions.php';
414			require_once GIVE_PLUGIN_DIR . 'includes/admin/upgrades/upgrades.php';
415
416			}
417
418			require_once GIVE_PLUGIN_DIR . 'includes/install.php';
419
420			}
421
422			/**
423			* Loads the plugin language files
424			*
425			* @since 1.0
426			* @access public
427			*
428			* @return void
429			*/
430			public function load_textdomain() {
431			// Set filter for Give's languages directory
432			$give_lang_dir = dirname( plugin_basename( GIVE_PLUGIN_FILE ) ) . '/languages/';
433			$give_lang_dir = apply_filters( 'give_languages_directory', $give_lang_dir );
434
435			// Traditional WordPress plugin locale filter
436			$locale = apply_filters( 'plugin_locale', get_locale(), 'give' );
437			$mofile = sprintf( '%1$s-%2$s.mo', 'give', $locale );
438
439			// Setup paths to current locale file
440			$mofile_local = $give_lang_dir . $mofile;
441			$mofile_global = WP_LANG_DIR . '/give/' . $mofile;
442
443			if ( file_exists( $mofile_global ) ) {
444			// Look in global /wp-content/languages/give folder
445			load_textdomain( 'give', $mofile_global );
446			} elseif ( file_exists( $mofile_local ) ) {
447			// Look in local location from filter `give_languages_directory`
448			load_textdomain( 'give', $mofile_local );
449			} else {
450			// Load the default language files packaged up w/ Give
451			load_plugin_textdomain( 'give', false, $give_lang_dir );
452			}
453			}
454
455			}
456
457			endif; // End if class_exists check
458
459
460			/**
461			* Start Give
462			*
463			* The main function responsible for returning the one true Give instance to functions everywhere.
464			*
465			* Use this function like you would a global variable, except without needing
466			* to declare the global.
467			*
468			* Example: <?php $give = Give(); ?>
469			*
470			* @since 1.0
471			* @return object\|Give
472			*/
473			function Give() {
474			return Give::instance();
475			}
476
477			// Get Give Running
478			Give();
479

ravinderk / Give

Push — master ( 0af146...28843d )

give.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like