Conditions | 5 |
Paths | 5 |
Total Lines | 145 |
Lines | 40 |
Ratio | 27.59 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
45 | public function get_settings() { |
||
46 | $settings = array(); |
||
47 | $current_section = give_get_current_setting_section(); |
||
48 | |||
49 | switch ( $current_section ) { |
||
50 | case 'email-settings' : |
||
51 | $settings = array( |
||
52 | |||
53 | // Section 1: Email Sender Setting |
||
54 | array( |
||
55 | 'id' => 'give_title_email_settings_1', |
||
56 | 'type' => 'title', |
||
57 | ), |
||
58 | array( |
||
59 | 'id' => 'email_template', |
||
60 | 'name' => esc_html__( 'Email Template', 'give' ), |
||
61 | 'desc' => esc_html__( 'Choose your template from the available registered template types.', 'give' ), |
||
62 | 'type' => 'select', |
||
63 | 'options' => give_get_email_templates(), |
||
64 | ), |
||
65 | array( |
||
66 | 'id' => 'email_logo', |
||
67 | 'name' => esc_html__( 'Logo', 'give' ), |
||
68 | 'desc' => esc_html__( 'Upload or choose a logo to be displayed at the top of the donation receipt emails. Displayed on HTML emails only.', 'give' ), |
||
69 | 'type' => 'file', |
||
70 | ), |
||
71 | array( |
||
72 | 'id' => 'from_name', |
||
73 | 'name' => esc_html__( 'From Name', 'give' ), |
||
74 | 'desc' => esc_html__( 'The name which appears in the "From" field in all Give donation emails.', 'give' ), |
||
75 | 'default' => get_bloginfo( 'name' ), |
||
76 | 'type' => 'text', |
||
77 | ), |
||
78 | array( |
||
79 | 'id' => 'from_email', |
||
80 | 'name' => esc_html__( 'From Email', 'give' ), |
||
81 | 'desc' => esc_html__( 'Email address from which all Give emails are sent from. This will act as the "from" and "reply-to" email address.', 'give' ), |
||
82 | 'default' => get_bloginfo( 'admin_email' ), |
||
83 | 'type' => 'text', |
||
84 | ), |
||
85 | array( |
||
86 | 'name' => esc_html__( 'Donation Notification Settings Docs Link', 'give' ), |
||
87 | 'id' => 'donation_notification_settings_docs_link', |
||
88 | 'url' => esc_url( 'http://docs.givewp.com/settings-donation-notification' ), |
||
89 | 'title' => __( 'Donation Notification Settings', 'give' ), |
||
90 | 'type' => 'give_docs_link', |
||
91 | ), |
||
92 | array( |
||
93 | 'id' => 'give_title_email_settings_3', |
||
94 | 'type' => 'sectionend', |
||
95 | ), |
||
96 | ); |
||
97 | break; |
||
98 | |||
99 | View Code Duplication | case 'donor-email' : |
|
|
|||
100 | $settings = array( |
||
101 | |||
102 | // Section 1: Donor Email Notification Listing. |
||
103 | array( |
||
104 | 'desc' => __( 'Email notifications sent from Give for donor are listed below. Click on an email to configure it.', 'give' ), |
||
105 | 'type' => 'title', |
||
106 | 'id' => 'give_donor_email_notification_settings', |
||
107 | 'table_html' => false, |
||
108 | ), |
||
109 | array( |
||
110 | 'type' => 'email_notification', |
||
111 | ), |
||
112 | array( |
||
113 | 'type' => 'sectionend', |
||
114 | 'id' => 'give_donor_email_notification_settings', |
||
115 | ), |
||
116 | |||
117 | ); |
||
118 | break; |
||
119 | |||
120 | View Code Duplication | case 'admin-email' : |
|
121 | $settings = array( |
||
122 | |||
123 | // Section 1: Admin Email Notification Listing. |
||
124 | array( |
||
125 | 'desc' => __( 'Email notifications sent from Give for admin are listed below. Click on an email to configure it.', 'give' ), |
||
126 | 'type' => 'title', |
||
127 | 'id' => 'give_admin_email_notification_settings', |
||
128 | 'table_html' => false, |
||
129 | ), |
||
130 | array( |
||
131 | 'type' => 'email_notification', |
||
132 | ), |
||
133 | array( |
||
134 | 'type' => 'sectionend', |
||
135 | 'id' => 'give_admin_email_notification_settings', |
||
136 | ), |
||
137 | |||
138 | ); |
||
139 | break; |
||
140 | |||
141 | case 'contact': |
||
142 | $settings = array( |
||
143 | |||
144 | array( |
||
145 | 'id' => 'give_title_general_settings_5', |
||
146 | 'type' => 'title' |
||
147 | ), |
||
148 | array( |
||
149 | 'name' => __( 'Admin Email Address', 'give' ), |
||
150 | 'id' => "contact_admin_email", |
||
151 | 'desc' => sprintf( '%1$s <code>{admin_email}</code> %2$s', __( 'By default, the', 'give' ), __( 'tag will use your WordPress admin email. If you would like to customize this address you can do so in the field above.', 'give' ) ), |
||
152 | 'type' => 'text', |
||
153 | 'default' => give_email_admin_email(), |
||
154 | |||
155 | ), |
||
156 | array( |
||
157 | 'name' => __( 'Offline Mailing Address', 'give' ), |
||
158 | 'id' => "contact_offline_mailing_address", |
||
159 | 'desc' => sprintf( '%1$s <code>{offline_mailing_address}</code> %2$s', __( 'Set the mailing address to where you would like your donors to send their offline donations. This will customize the', 'give' ), __( 'email tag for the Offline Donations payment gateway.', 'give' ) ), |
||
160 | 'type' => 'wysiwyg', |
||
161 | 'default' => ' <em>' . get_bloginfo( 'sitename' ) . '</em><br> <em>111 Not A Real St.</em><br> <em>Anytown, CA 12345 </em><br>', |
||
162 | ), |
||
163 | array( |
||
164 | 'id' => 'give_title_general_settings_4', |
||
165 | 'type' => 'sectionend' |
||
166 | ) |
||
167 | ); |
||
168 | |||
169 | break; |
||
170 | }// End switch(). |
||
171 | |||
172 | /** |
||
173 | * Filter the emails settings. |
||
174 | * Backward compatibility: Please do not use this filter. This filter is deprecated in 1.8 |
||
175 | */ |
||
176 | $settings = apply_filters( 'give_settings_emails', $settings ); |
||
177 | |||
178 | /** |
||
179 | * Filter the settings. |
||
180 | * |
||
181 | * @since 1.8 |
||
182 | * |
||
183 | * @param array $settings |
||
184 | */ |
||
185 | $settings = apply_filters( 'give_get_settings_' . $this->id, $settings ); |
||
186 | |||
187 | // Output. |
||
188 | return $settings; |
||
189 | } |
||
190 | |||
248 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.