Conditions | 4 |
Paths | 6 |
Total Lines | 139 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
48 | public function get_settings() { |
||
49 | $settings = array(); |
||
50 | |||
51 | $current_section = give_get_current_setting_section(); |
||
52 | |||
53 | switch ( $current_section ) { |
||
54 | case 'advanced-options': |
||
55 | $settings = array( |
||
56 | array( |
||
57 | 'id' => 'give_title_data_control_2', |
||
58 | 'type' => 'title', |
||
59 | ), |
||
60 | array( |
||
61 | 'name' => __( 'Remove Data on Uninstall', 'give' ), |
||
62 | 'desc' => __( 'When the plugin is deleted, completely remove all Give data. This includes all Give settings, forms, form meta, donor, donor data, donations. Everything.', 'give' ), |
||
63 | 'id' => 'uninstall_on_delete', |
||
64 | 'type' => 'radio_inline', |
||
65 | 'default' => 'disabled', |
||
66 | 'options' => array( |
||
67 | 'enabled' => __( 'Yes, Remove all data', 'give' ), |
||
68 | 'disabled' => __( 'No, keep my Give settings and donation data', 'give' ), |
||
69 | ), |
||
70 | ), |
||
71 | array( |
||
72 | 'name' => __( 'Default User Role', 'give' ), |
||
73 | 'desc' => __( 'Assign default user roles for donors when donors opt to register as a WP User.', 'give' ), |
||
74 | 'id' => 'donor_default_user_role', |
||
75 | 'type' => 'select', |
||
76 | 'default' => 'give_donor', |
||
77 | 'options' => give_get_user_roles(), |
||
78 | ), |
||
79 | array( |
||
80 | /* translators: %s: the_content */ |
||
81 | 'name' => sprintf( __( '%s filter', 'give' ), '<code>the_content</code>' ), |
||
82 | /* translators: 1: https://codex.wordpress.org/Plugin_API/Filter_Reference/the_content 2: the_content */ |
||
83 | 'desc' => sprintf( __( 'If you are seeing extra social buttons, related posts, or other unwanted elements appearing within your forms then you can disable WordPress\' content filter. <a href="%1$s" target="_blank">Learn more</a> about %2$s filter.', 'give' ), esc_url( 'https://codex.wordpress.org/Plugin_API/Filter_Reference/the_content' ), '<code>the_content</code>' ), |
||
84 | 'id' => 'the_content_filter', |
||
85 | 'default' => 'enabled', |
||
86 | 'type' => 'radio_inline', |
||
87 | 'options' => array( |
||
88 | 'enabled' => __( 'Enabled', 'give' ), |
||
89 | 'disabled' => __( 'Disabled', 'give' ), |
||
90 | ), |
||
91 | ), |
||
92 | array( |
||
93 | 'name' => __( 'Script Loading Location', 'give' ), |
||
94 | 'desc' => __( 'This allows you to load your Give scripts either in the <code><head></code> or footer of your website.', 'give' ), |
||
95 | 'id' => 'scripts_footer', |
||
96 | 'type' => 'radio_inline', |
||
97 | 'default' => 'disabled', |
||
98 | 'options' => array( |
||
99 | 'disabled' => __( 'Head', 'give' ), |
||
100 | 'enabled' => __( 'Footer', 'give' ), |
||
101 | ), |
||
102 | ), |
||
103 | array( |
||
104 | 'name' => __( 'Babel Polyfill Script', 'give' ), |
||
105 | 'desc' => __( 'Decide whether to load the Babel polyfill, which provides backwards compatibility for older browsers such as IE 11. The polyfill may be disabled to avoid conflicts with other themes or plugins that load the same script.', 'give' ), |
||
106 | 'id' => 'babel_polyfill_script', |
||
107 | 'type' => 'radio_inline', |
||
108 | 'default' => 'enabled', |
||
109 | 'options' => array( |
||
110 | 'enabled' => __( 'Enabled', 'give' ), |
||
111 | 'disabled' => __( 'Disabled', 'give' ), |
||
112 | ), |
||
113 | ), |
||
114 | array( |
||
115 | 'name' => __( 'Akismet SPAM Protection', 'give' ), |
||
116 | 'desc' => __( 'Add a layer of SPAM protection to your donation submissions with Akismet. When enabled, donation submissions will be first sent to Akismet\'s API if you have the plugin activated and configured.', 'give' ), |
||
117 | 'id' => 'akismet_spam_protection', |
||
118 | 'type' => 'radio_inline', |
||
119 | 'default' => ( give_check_akismet_key() ) ? 'enabled' : 'disabled', |
||
120 | 'options' => array( |
||
121 | 'enabled' => __( 'Enabled', 'give' ), |
||
122 | 'disabled' => __( 'Disabled', 'give' ), |
||
123 | ), |
||
124 | ), |
||
125 | array( |
||
126 | 'name' => 'Give Cache', |
||
127 | 'id' => 'give-clear-cache', |
||
128 | 'buttonTitle' => __( 'Clear Cache', 'give' ), |
||
129 | 'desc' => __( 'Click this button if you want to clear Give\'s cache. The plugin stores common settings and queries in cache to optimize performance. Clearing cache will remove and begin rebuilding these saved queries.', 'give' ), |
||
130 | 'type' => 'remove_cache_button' |
||
131 | ), |
||
132 | array( |
||
133 | 'name' => __( 'Advanced Settings Docs Link', 'give' ), |
||
134 | 'id' => 'advanced_settings_docs_link', |
||
135 | 'url' => esc_url( 'http://docs.givewp.com/settings-advanced' ), |
||
136 | 'title' => __( 'Advanced Settings', 'give' ), |
||
137 | 'type' => 'give_docs_link', |
||
138 | ), |
||
139 | array( |
||
140 | 'id' => 'give_title_data_control_2', |
||
141 | 'type' => 'sectionend', |
||
142 | ), |
||
143 | ); |
||
144 | break; |
||
145 | } |
||
146 | |||
147 | /** |
||
148 | * Hide caching setting by default. |
||
149 | * |
||
150 | * @since 2.0 |
||
151 | */ |
||
152 | if ( apply_filters( 'give_settings_advanced_show_cache_setting', false ) ) { |
||
153 | array_splice( $settings, 1, 0, array( |
||
154 | array( |
||
155 | 'name' => __( 'Cache', 'give' ), |
||
156 | 'desc' => __( 'If caching is enabled the plugin will start caching custom post type related queries and reduce the overall load time.', 'give' ), |
||
157 | 'id' => 'cache', |
||
158 | 'type' => 'radio_inline', |
||
159 | 'default' => 'enabled', |
||
160 | 'options' => array( |
||
161 | 'enabled' => __( 'Enabled', 'give' ), |
||
162 | 'disabled' => __( 'Disabled', 'give' ), |
||
163 | ), |
||
164 | ) |
||
165 | ) ); |
||
166 | } |
||
167 | |||
168 | |||
169 | /** |
||
170 | * Filter the advanced settings. |
||
171 | * Backward compatibility: Please do not use this filter. This filter is deprecated in 1.8 |
||
172 | */ |
||
173 | $settings = apply_filters( 'give_settings_advanced', $settings ); |
||
174 | |||
175 | /** |
||
176 | * Filter the settings. |
||
177 | * |
||
178 | * @since 1.8 |
||
179 | * |
||
180 | * @param array $settings |
||
181 | */ |
||
182 | $settings = apply_filters( 'give_get_settings_' . $this->id, $settings ); |
||
183 | |||
184 | // Output. |
||
185 | return $settings; |
||
186 | } |
||
187 | |||
260 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.