Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Give_Import_Donations often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Give_Import_Donations, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
25 | final class Give_Import_Donations { |
||
26 | |||
27 | /** |
||
28 | * Importer type |
||
29 | * |
||
30 | * @since 1.8.13 |
||
31 | * @var string |
||
32 | */ |
||
33 | private $importer_type = 'import_donations'; |
||
34 | |||
35 | /** |
||
36 | * Instance. |
||
37 | * |
||
38 | * @since |
||
39 | * @access private |
||
40 | * @var |
||
41 | */ |
||
42 | static private $instance; |
||
43 | |||
44 | /** |
||
45 | * Importing donation per page. |
||
46 | * |
||
47 | * @since 1.8.14 |
||
48 | * |
||
49 | * @var int |
||
50 | */ |
||
51 | public static $per_page = 25; |
||
52 | |||
53 | /** |
||
54 | * Importing donation per page. |
||
55 | * |
||
56 | * @since 2.1 |
||
57 | * |
||
58 | * @var int |
||
59 | */ |
||
60 | public $is_csv_valid = false; |
||
61 | |||
62 | /** |
||
63 | * Singleton pattern. |
||
64 | * |
||
65 | * @since |
||
66 | * @access private |
||
67 | */ |
||
68 | private function __construct() { |
||
71 | |||
72 | /** |
||
73 | * Get instance. |
||
74 | * |
||
75 | * @since |
||
76 | * @access public |
||
77 | * |
||
78 | * @return static |
||
79 | */ |
||
80 | public static function get_instance() { |
||
87 | |||
88 | /** |
||
89 | * Setup |
||
90 | * |
||
91 | * @since 1.8.14 |
||
92 | * |
||
93 | * @return void |
||
94 | */ |
||
95 | public function setup() { |
||
98 | |||
99 | |||
100 | /** |
||
101 | * Setup Hooks. |
||
102 | * |
||
103 | * @since 1.8.14 |
||
104 | * |
||
105 | * @return void |
||
106 | */ |
||
107 | View Code Duplication | private function setup_hooks() { |
|
130 | |||
131 | /** |
||
132 | * Update notice |
||
133 | * |
||
134 | * @since 1.8.14 |
||
135 | * |
||
136 | * @param $messages |
||
137 | * |
||
138 | * @return mixed |
||
139 | */ |
||
140 | View Code Duplication | public function update_notices( $messages ) { |
|
147 | |||
148 | /** |
||
149 | * Print submit and nonce button. |
||
150 | * |
||
151 | * @since 1.8.14 |
||
152 | */ |
||
153 | public function submit() { |
||
161 | |||
162 | /** |
||
163 | * Print the HTML for importer. |
||
164 | * |
||
165 | * @since 1.8.14 |
||
166 | */ |
||
167 | public function html() { |
||
232 | |||
233 | /** |
||
234 | * Show success notice |
||
235 | * |
||
236 | * @since 1.8.14 |
||
237 | */ |
||
238 | public function import_success() { |
||
361 | |||
362 | /** |
||
363 | * Will start Import |
||
364 | * |
||
365 | * @since 1.8.14 |
||
366 | */ |
||
367 | public function start_import() { |
||
368 | // Reset the donation form report. |
||
369 | give_import_donation_report_reset(); |
||
370 | |||
371 | $csv = absint( $_REQUEST['csv'] ); |
||
372 | $delimiter = ( ! empty( $_REQUEST['delimiter'] ) ? give_clean( $_REQUEST['delimiter'] ) : 'csv' ); |
||
373 | $index_start = 1; |
||
374 | $next = true; |
||
375 | $total = self::get_csv_total( $csv ); |
||
376 | if ( self::$per_page < $total ) { |
||
377 | $total_ajax = ceil( $total / self::$per_page ); |
||
378 | $index_end = self::$per_page; |
||
379 | } else { |
||
380 | $total_ajax = 1; |
||
381 | $index_end = $total; |
||
382 | $next = false; |
||
383 | } |
||
384 | $current_percentage = 100 / ( $total_ajax + 1 ); |
||
385 | |||
386 | ?> |
||
387 | <tr valign="top" class="give-import-dropdown"> |
||
388 | <th colspan="2"> |
||
389 | <h2 id="give-import-title"><?php _e( 'Importing', 'give' ) ?></h2> |
||
390 | <p class="give-field-description"><?php _e( 'Your donations are now being imported...', 'give' ) ?></p> |
||
391 | </th> |
||
392 | </tr> |
||
393 | |||
394 | <tr valign="top" class="give-import-dropdown"> |
||
395 | <th colspan="2"> |
||
396 | <span class="spinner is-active"></span> |
||
397 | <div class="give-progress" |
||
398 | data-current="1" |
||
399 | data-total_ajax="<?php echo absint( $total_ajax ); ?>" |
||
400 | data-start="<?php echo absint( $index_start ); ?>" |
||
401 | data-end="<?php echo absint( $index_end ); ?>" |
||
402 | data-next="<?php echo absint( $next ); ?>" |
||
403 | data-total="<?php echo absint( $total ); ?>" |
||
404 | data-per_page="<?php echo absint( self::$per_page ); ?>"> |
||
405 | |||
406 | <div style="width: <?php echo (float) $current_percentage; ?>%"></div> |
||
407 | </div> |
||
408 | <input type="hidden" value="3" name="step"> |
||
409 | <input type="hidden" value='<?php echo esc_attr( maybe_serialize( $_REQUEST['mapto'] ) ); ?>' name="mapto" class="mapto"> |
||
410 | <input type="hidden" value="<?php echo $csv; ?>" name="csv" class="csv"> |
||
411 | <input type="hidden" value="<?php echo esc_attr( $_REQUEST['mode'] ); ?>" name="mode" class="mode"> |
||
412 | <input type="hidden" value="<?php echo esc_attr( $_REQUEST['create_user'] ); ?>" name="create_user" class="create_user"> |
||
413 | <input type="hidden" value="<?php echo esc_attr( $_REQUEST['delete_csv'] ); ?>" name="delete_csv" class="delete_csv"> |
||
414 | <input type="hidden" value="<?php echo esc_attr( $delimiter ); ?>" name="delimiter"> |
||
415 | <input type="hidden" value="<?php echo absint( $_REQUEST['dry_run'] ); ?>" name="dry_run"> |
||
416 | <input type="hidden" value='<?php echo esc_attr( maybe_serialize( self::get_importer( $csv, 0, $delimiter ) ) ); ?>' name="main_key" class="main_key"> |
||
417 | </th> |
||
418 | </tr> |
||
419 | <?php |
||
420 | } |
||
421 | |||
422 | /** |
||
423 | * Will return true if importing can be started or not else false. |
||
424 | * |
||
425 | * @since 1.8.14 |
||
426 | */ |
||
427 | public function check_for_dropdown_or_import() { |
||
428 | $return = true; |
||
429 | if ( isset( $_REQUEST['mapto'] ) ) { |
||
430 | $mapto = (array) $_REQUEST['mapto']; |
||
431 | if ( false === in_array( 'form_title', $mapto ) && false === in_array( 'form_id', $mapto ) ) { |
||
432 | Give_Admin_Settings::add_error( 'give-import-csv-form', __( 'In order to import donations, a column must be mapped to either the "Donation Form Title" or "Donation Form ID" field. Please map a column to one of those fields.', 'give' ) ); |
||
433 | $return = false; |
||
434 | } |
||
435 | |||
436 | if ( false === in_array( 'amount', $mapto ) ) { |
||
437 | Give_Admin_Settings::add_error( 'give-import-csv-amount', __( 'In order to import donations, a column must be mapped to the "Amount" field. Please map a column to that field.', 'give' ) ); |
||
438 | $return = false; |
||
439 | } |
||
440 | |||
441 | if ( false === in_array( 'email', $mapto ) && false === in_array( 'donor_id', $mapto ) ) { |
||
442 | Give_Admin_Settings::add_error( 'give-import-csv-donor', __( 'In order to import donations, a column must be mapped to either the "Donor Email" or "Donor ID" field. Please map a column to that field.', 'give' ) ); |
||
443 | $return = false; |
||
444 | } |
||
445 | } else { |
||
446 | $return = false; |
||
447 | } |
||
448 | |||
449 | return $return; |
||
450 | } |
||
451 | |||
452 | /** |
||
453 | * Print the Dropdown option for CSV. |
||
454 | * |
||
455 | * @since 1.8.14 |
||
456 | */ |
||
457 | public function render_dropdown() { |
||
458 | $csv = (int) $_GET['csv']; |
||
459 | $delimiter = ( ! empty( $_GET['delimiter'] ) ? give_clean( $_GET['delimiter'] ) : 'csv' ); |
||
460 | |||
461 | // TO check if the CSV files that is being add is valid or not if not then redirect to first step again |
||
462 | if ( ! $this->is_valid_csv( $csv ) ) { |
||
463 | $url = give_import_page_url(); |
||
464 | ?> |
||
465 | <input type="hidden" name="csv_not_valid" class="csv_not_valid" value="<?php echo $url; ?>"/> |
||
466 | <?php |
||
467 | } else { |
||
468 | ?> |
||
469 | <tr valign="top" class="give-import-dropdown"> |
||
470 | <th colspan="2"> |
||
471 | <h2 id="give-import-title"><?php _e( 'Map CSV fields to donations', 'give' ) ?></h2> |
||
472 | |||
473 | <p class="give-import-donation-required-fields-title"><?php _e( 'Required Fields' ); ?></p> |
||
474 | |||
475 | <p class="give-field-description"><?php _e( 'These fields are required for the import to submitted' ); ?></p> |
||
476 | |||
477 | <ul class="give-import-donation-required-fields"> |
||
478 | <li class="give-import-donation-required-email" |
||
479 | title="Please configure all required fields to start the import process."> |
||
480 | <span class="give-import-donation-required-symbol dashicons dashicons-no-alt"></span> |
||
481 | <span class="give-import-donation-required-text"> |
||
482 | <?php |
||
483 | _e( 'Email Address', 'give' ); |
||
484 | ?> |
||
485 | </span> |
||
486 | </li> |
||
487 | |||
488 | <li class="give-import-donation-required-first" |
||
489 | title="Please configure all required fields to start the import process."> |
||
490 | <span class="give-import-donation-required-symbol dashicons dashicons-no-alt"></span> |
||
491 | <span class="give-import-donation-required-text"> |
||
492 | <?php |
||
493 | _e( 'First Name', 'give' ); |
||
494 | ?> |
||
495 | </span> |
||
496 | </li> |
||
497 | |||
498 | <li class="give-import-donation-required-amount" |
||
499 | title="Please configure all required fields to start the import process."> |
||
500 | <span class="give-import-donation-required-symbol dashicons dashicons-no-alt"></span> |
||
501 | <span class="give-import-donation-required-text"> |
||
502 | <?php |
||
503 | _e( 'Donation Amount', 'give' ); |
||
504 | ?> |
||
505 | </span> |
||
506 | </li> |
||
507 | |||
508 | <li class="give-import-donation-required-form" |
||
509 | title="Please configure all required fields to start the import process."> |
||
510 | <span class="give-import-donation-required-symbol dashicons dashicons-no-alt"></span> |
||
511 | <span class="give-import-donation-required-text"> |
||
512 | <?php |
||
513 | _e( 'Form Title or ID', 'give' ); |
||
514 | ?> |
||
515 | </span> |
||
516 | </li> |
||
517 | </ul> |
||
518 | |||
519 | <p class="give-field-description"><?php _e( 'Select fields from your CSV file to map against donations fields or to ignore during import.', 'give' ) ?></p> |
||
520 | </th> |
||
521 | </tr> |
||
522 | |||
523 | <tr valign="top" class="give-import-dropdown"> |
||
524 | <th><b><?php _e( 'Column name', 'give' ); ?></b></th> |
||
525 | <th><b><?php _e( 'Map to field', 'give' ); ?></b></th> |
||
526 | </tr> |
||
527 | |||
528 | <?php |
||
529 | $raw_key = $this->get_importer( $csv, 0, $delimiter ); |
||
530 | $mapto = (array) ( isset( $_REQUEST['mapto'] ) ? $_REQUEST['mapto'] : array() ); |
||
531 | |||
532 | foreach ( $raw_key as $index => $value ) { |
||
533 | ?> |
||
534 | <tr valign="middle" class="give-import-option"> |
||
535 | <th><?php echo $value; ?></th> |
||
536 | <th> |
||
537 | <?php |
||
538 | $this->get_columns( $index, $value, $mapto ); |
||
539 | ?> |
||
540 | </th> |
||
541 | </tr> |
||
542 | <?php |
||
543 | } |
||
544 | } |
||
545 | } |
||
546 | |||
547 | /** |
||
548 | * @param $option_value |
||
549 | * @param $value |
||
550 | * |
||
551 | * @return string |
||
552 | */ |
||
553 | public function selected( $option_value, $value ) { |
||
554 | $option_value = strtolower( $option_value ); |
||
555 | $value = strtolower( $value ); |
||
556 | |||
557 | $selected = ''; |
||
558 | if ( stristr( $value, $option_value ) ) { |
||
559 | $selected = 'selected'; |
||
560 | } elseif ( strrpos( $value, 'give_' ) && stristr( $option_value, __( 'Import as Meta', 'give' ) ) ) { |
||
561 | $selected = 'selected'; |
||
562 | } |
||
563 | |||
564 | return $selected; |
||
565 | } |
||
566 | |||
567 | /** |
||
568 | * Print the columns from the CSV. |
||
569 | * |
||
570 | * @since 1.8.14 |
||
571 | * @access private |
||
572 | * |
||
573 | * @param string $index |
||
574 | * @param bool $value |
||
575 | * @param array $mapto |
||
576 | * |
||
577 | * @return void |
||
578 | */ |
||
579 | private function get_columns( $index, $value = false, $mapto = array() ) { |
||
580 | $default = give_import_default_options(); |
||
581 | $current_mapto = (string) ( ! empty( $mapto[ $index ] ) ? $mapto[ $index ] : '' ); |
||
582 | ?> |
||
583 | <select name="mapto[<?php echo $index; ?>]"> |
||
584 | <?php $this->get_dropdown_option_html( $default, $current_mapto, $value ); ?> |
||
585 | |||
586 | <optgroup label="<?php _e( 'Donations', 'give' ); ?>"> |
||
587 | <?php |
||
588 | $this->get_dropdown_option_html( give_import_donations_options(), $current_mapto, $value ); |
||
589 | ?> |
||
590 | </optgroup> |
||
591 | |||
592 | <optgroup label="<?php _e( 'Donors', 'give' ); ?>"> |
||
593 | <?php |
||
594 | $this->get_dropdown_option_html( give_import_donor_options(), $current_mapto, $value ); |
||
595 | ?> |
||
596 | </optgroup> |
||
597 | |||
598 | <optgroup label="<?php _e( 'Forms', 'give' ); ?>"> |
||
599 | <?php |
||
600 | $this->get_dropdown_option_html( give_import_donation_form_options(), $current_mapto, $value ); |
||
601 | ?> |
||
602 | </optgroup> |
||
603 | |||
604 | <?php |
||
605 | /** |
||
606 | * Fire the action |
||
607 | * You can use this filter to add new options. |
||
608 | * |
||
609 | * @since 1.8.15 |
||
610 | */ |
||
611 | do_action( 'give_import_dropdown_option', $index, $value, $mapto, $current_mapto ); |
||
612 | ?> |
||
613 | </select> |
||
614 | <?php |
||
615 | } |
||
616 | |||
617 | /** |
||
618 | * Print the option html for select in importer |
||
619 | * |
||
620 | * @since 1.8.15 |
||
621 | * @access public |
||
622 | * |
||
623 | * @param array $options |
||
624 | * @param string $current_mapto |
||
625 | * @param bool $value |
||
626 | * |
||
627 | * @return void |
||
628 | */ |
||
629 | public function get_dropdown_option_html( $options, $current_mapto, $value = false ) { |
||
630 | |||
631 | foreach ( $options as $option => $option_value ) { |
||
632 | $ignore = array(); |
||
633 | if ( isset( $option_value['ignore'] ) && is_array( $option_value['ignore'] ) ) { |
||
634 | $ignore = $option_value['ignore']; |
||
635 | unset( $option_value['ignore'] ); |
||
636 | } |
||
637 | |||
638 | $option_value_texts = (array) $option_value; |
||
639 | $option_text = $option_value_texts[0]; |
||
640 | |||
641 | $checked = ( ( $current_mapto === $option ) ? 'selected' : false ); |
||
642 | if ( empty( $checked ) && ! in_array( $value, $ignore ) ) { |
||
643 | foreach ( $option_value_texts as $option_value_text ) { |
||
644 | $checked = $this->selected( $option_value_text, $value ); |
||
645 | if ( $checked ) { |
||
646 | break; |
||
647 | } |
||
648 | } |
||
649 | } |
||
650 | |||
651 | echo sprintf( |
||
652 | '<option value="%1$s" %2$s >%3$s</option>', |
||
653 | $option, |
||
654 | $checked, |
||
655 | $option_text |
||
656 | ); |
||
657 | } |
||
658 | } |
||
659 | |||
660 | /** |
||
661 | * Get column count of csv file. |
||
662 | * |
||
663 | * @since 1.8.14 |
||
664 | * |
||
665 | * @param $file_id |
||
666 | * |
||
667 | * @return bool|int |
||
668 | */ |
||
669 | public function get_csv_total( $file_id ) { |
||
680 | |||
681 | /** |
||
682 | * Get data from File |
||
683 | * |
||
684 | * @since 2.1 |
||
685 | * |
||
686 | * @param $file_dir |
||
687 | * |
||
688 | * @return bool|int |
||
689 | */ |
||
690 | public function get_csv_data_from_file_dir( $file_dir ) { |
||
700 | |||
701 | /** |
||
702 | * Get the CSV fields title from the CSV. |
||
703 | * |
||
704 | * @since 1.8.14 |
||
705 | * |
||
706 | * @param (int) $file_id |
||
707 | * @param int $index |
||
708 | * @param string $delimiter |
||
709 | * |
||
710 | * @return array|bool $raw_data title of the CSV file fields |
||
711 | */ |
||
712 | public function get_importer( $file_id, $index = 0, $delimiter = 'csv' ) { |
||
736 | |||
737 | /** |
||
738 | * Remove UTF-8 BOM signature. |
||
739 | * |
||
740 | * @since 1.8.14 |
||
741 | * |
||
742 | * @param string $string String to handle. |
||
743 | * |
||
744 | * @return string |
||
745 | */ |
||
746 | public function remove_utf8_bom( $string ) { |
||
753 | |||
754 | /** |
||
755 | * Is used to show the process when user upload the donor form. |
||
756 | * |
||
757 | * @since 1.8.14 |
||
758 | */ |
||
759 | public function render_progress() { |
||
778 | |||
779 | /** |
||
780 | * Will return the import step. |
||
781 | * |
||
782 | * @since 1.8.14 |
||
783 | * |
||
784 | * @return int $step on which step doest the import is on. |
||
785 | */ |
||
786 | View Code Duplication | public function get_step() { |
|
802 | |||
803 | /** |
||
804 | * Render donations import page |
||
805 | * |
||
806 | * @since 1.8.14 |
||
807 | */ |
||
808 | public function render_page() { |
||
811 | |||
812 | /** |
||
813 | * Print Dry Run HTML on donation import page |
||
814 | * |
||
815 | * @since 2.1 |
||
816 | */ |
||
817 | public function give_import_donation_submit_button_render_media_csv() { |
||
835 | |||
836 | /** |
||
837 | * Change submit button text on first step of importing donation. |
||
838 | * |
||
839 | * @since 2.1 |
||
840 | * |
||
841 | * @param $text |
||
842 | * |
||
843 | * @return string |
||
844 | */ |
||
845 | function give_import_donation_submit_text_render_media_csv( $text ) { |
||
848 | |||
849 | /** |
||
850 | * Add CSV upload HTMl |
||
851 | * |
||
852 | * Print the html of the file upload from which CSV will be uploaded. |
||
853 | * |
||
854 | * @since 1.8.14 |
||
855 | * @return void |
||
856 | */ |
||
857 | public function render_media_csv() { |
||
986 | |||
987 | /** |
||
988 | * Run when user click on the submit button. |
||
989 | * |
||
990 | * @since 1.8.14 |
||
991 | */ |
||
992 | public function save() { |
||
1024 | |||
1025 | /** |
||
1026 | * Check if user uploaded csv is valid or not. |
||
1027 | * |
||
1028 | * @since 1.8.14 |
||
1029 | * @access public |
||
1030 | * |
||
1031 | * @param mixed $csv ID of the CSV files. |
||
1032 | * @param string $match_url ID of the CSV files. |
||
1033 | * |
||
1034 | * @return bool $has_error CSV is valid or not. |
||
1035 | */ |
||
1036 | private function is_valid_csv( $csv = false, $match_url = '' ) { |
||
1059 | |||
1060 | |||
1061 | /** |
||
1062 | * Render report import field |
||
1063 | * |
||
1064 | * @since 1.8.14 |
||
1065 | * @access public |
||
1066 | * |
||
1067 | * @param $field |
||
1068 | * @param $option_value |
||
1069 | */ |
||
1070 | public function render_import_field( $field, $option_value ) { |
||
1073 | |||
1074 | /** |
||
1075 | * Get if current page import donations page or not |
||
1076 | * |
||
1077 | * @since 1.8.14 |
||
1078 | * @return bool |
||
1079 | */ |
||
1080 | private function is_donations_import_page() { |
||
1085 | } |
||
1086 | |||
1087 | Give_Import_Donations::get_instance()->setup(); |
||
1088 | } |
||
1089 |