Give_Donor_Wall_Widget

Complexity

Total Complexity

7

Size/Duplication

Total Lines	136
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	24	1
A	widget()	0	26	3
A	update()	0	9	1
A	form()	0	17	1
A	widget_init()	0	3	1

<?php
/**
 * Donors Gravatars
 *
 * @package     Give
 * @subpackage  Classes/Give_Donors_Gravatars
 * @copyright   Copyright (c) 2016, GiveWP
 * @license     https://opensource.org/licenses/gpl-license GNU Public License
 * @since       1.0
 */

// Exit if accessed directly.
if ( ! defined( 'ABSPATH' ) ) {
	exit;
}

/**
 * Give_Donor_Wall_Widget Class
 *
 * This class handles donors gravatars
 *
 * @since 1.0
 */
class Give_Donor_Wall_Widget extends WP_Widget {

	/**
	 * Widget constructor
	 *
	 * @since  1.0
	 * @access public
	 */
	public function __construct() {

		// widget settings
		$widget_ops = array(
			'classname'   => 'give-donors-gravatars',
			'description' => esc_html__( 'Displays gravatars of people who have donated using your your form. Will only show on the single form page.', 'give' ),
		);

		// widget control settings
		$control_ops = array(
			'width'   => 250,
			'height'  => 350,
			'id_base' => 'give_gravatars_widget'
		);

		// create the widget
		parent::__construct(
			'give_donors_gravatars_widget',
			esc_html__( 'Give Donors Gravatars', 'give' ),
			$widget_ops,
			$control_ops
		);

	}

	/**
	 * Donors gravatars widget content
	 *
	 * Outputs the content of the widget
	 *
	 * @since  1.0
	 * @access public
	 *
	 * @param  array $args     Display arguments including 'before_title', 'after_title', 'before_widget', and 'after_widget'.
	 * @param  array $instance Settings for the current Links widget instance.
	 *
	 * @return void
	 */
	public function widget( $args, $instance ) {

		//@TODO: Don't extract it!!!
		extract( $args );

extract() usage is highly discouraged, due to the complexity and unintended issues it might cause.

		if ( ! is_singular( 'give_forms' ) ) {
			return;
		}

		// Variables from widget settings
		$title = apply_filters( 'widget_title', $instance['title'] );

		// Used by themes. Opens the widget
		echo $before_widget;

Expected next thing to be a escaping function, not '$before_widget'

		// Display the widget title
		if ( $title ) {
			echo $before_title . $title . $after_title;

Expected next thing to be a escaping function, not '$before_title'

Expected next thing to be a escaping function, not '$title'

Expected next thing to be a escaping function, not '$after_title'

		}

		echo Give_Donor_Wall::get_instance()->gravatars( get_the_ID(), null ); // remove title

The method gravatars() does not seem to exist on object<Give_Donor_Wall>.

Expected a sanitizing function (see Codex for 'Data Validation'), but instead saw 'Give_Donor_Wall'

		// Used by themes. Closes the widget
		echo $after_widget;

Expected next thing to be a escaping function, not '$after_widget'

	}

	/**
	 * Update donors gravatars
	 *
	 * Processes widget options to be saved.
	 *
	 * @since  1.0
	 * @access public
	 *
	 * @param  array $new_instance New settings for this instance as input by the user via WP_Widget::form().
	 * @param  array $old_instance Old settings for this instance.
	 *
	 * @return array Updated settings to save.
	 */
	public function update( $new_instance, $old_instance ) {

		$instance = $old_instance;

		$instance['title'] = strip_tags( $new_instance['title'] );

		return $instance;

	}

	/**
	 * Output donors
	 *
	 * Displays the actual form on the widget page.
	 *
	 * @since  1.0
	 * @access public
	 *
	 * @param  array $instance Current settings.
	 *
	 * @return void
	 */
	public function form( $instance ) {

		// Set up some default widget settings.
		$defaults = array(
			'title' => '',
		);

		$instance = wp_parse_args( (array) $instance, $defaults ); ?>

		<!-- Title -->
		<p>
			<label for="<?php echo $this->get_field_id( 'title' ); ?>"><?php esc_html_e( 'Title:', 'give' ) ?></label>

Expected next thing to be a escaping function, not '$this'

			<input class="widefat" id="<?php echo $this->get_field_id( 'title' ); ?>" name="<?php echo $this->get_field_name( 'title' ); ?>" type="text" value="<?php echo $instance['title']; ?>" />

Expected next thing to be a escaping function, not '$this'

Expected next thing to be a escaping function, not '$instance'

		</p>

		<?php
	}

	/**
	 * Register the widget
	 *
	 * @return void
	 */
	function widget_init(){

It is generally recommended to explicitly declare the visibility for methods.

		register_widget( $this->self );
	}

}