Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
24 | class Give_DB_Donor_Meta extends Give_DB_Meta { |
||
25 | |||
26 | /** |
||
27 | * Meta supports. |
||
28 | * |
||
29 | * @since 2.0 |
||
30 | * @access protected |
||
31 | * @var array |
||
32 | */ |
||
33 | protected $supports = array(); |
||
34 | |||
35 | /** |
||
36 | * Meta type |
||
37 | * |
||
38 | * @since 2.0 |
||
39 | * @access public |
||
40 | * |
||
41 | * @var string |
||
42 | */ |
||
43 | public $meta_type = 'donor'; |
||
44 | |||
45 | |||
46 | /** |
||
47 | * Give_DB_Donor_Meta constructor. |
||
48 | * |
||
49 | * @access public |
||
50 | * @since 1.6 |
||
51 | */ |
||
52 | public function __construct() { |
||
53 | /* @var WPDB $wpdb */ |
||
54 | global $wpdb; |
||
55 | |||
56 | $wpdb->donormeta = $this->table_name = $wpdb->prefix . 'give_donormeta'; |
||
57 | $this->primary_key = 'meta_id'; |
||
58 | $this->version = '1.0'; |
||
59 | |||
60 | parent::__construct(); |
||
61 | |||
62 | $this->bc_200_params(); |
||
63 | } |
||
64 | |||
65 | /** |
||
66 | * Get table columns and data types. |
||
67 | * |
||
68 | * @access public |
||
69 | * @since 1.6 |
||
70 | * |
||
71 | * @return array Columns and formats. |
||
72 | */ |
||
73 | public function get_columns() { |
||
81 | |||
82 | /** |
||
83 | * Add backward compatibility for old table name |
||
84 | * |
||
85 | * @since 2.0 |
||
86 | * @access private |
||
87 | * @global wpdb $wpdb |
||
88 | */ |
||
89 | private function bc_200_params() { |
||
103 | |||
104 | /** |
||
105 | * Check if current id is valid |
||
106 | * |
||
107 | * @since 2.0 |
||
108 | * @access protected |
||
109 | * |
||
110 | * @param $ID |
||
111 | * |
||
112 | * @return bool |
||
113 | */ |
||
114 | protected function is_valid_post_type( $ID ) { |
||
117 | |||
118 | } |
||
119 |