Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
25 | class Give_API_V2 { |
||
|
|||
26 | /** |
||
27 | * API base prefix |
||
28 | * |
||
29 | * @since 2.1 |
||
30 | * @access private |
||
31 | * |
||
32 | * @var string |
||
33 | */ |
||
34 | private $rest_base = 'give-api/v2'; |
||
35 | |||
36 | /** |
||
37 | * Instance. |
||
38 | * |
||
39 | * @since 2.1 |
||
40 | * @access private |
||
41 | * |
||
42 | * @var Give_API_V2 |
||
43 | */ |
||
44 | static private $instance; |
||
45 | |||
46 | /** |
||
47 | * Singleton pattern. |
||
48 | * |
||
49 | * @since 2.1 |
||
50 | * @access private |
||
51 | */ |
||
52 | private function __construct() { |
||
54 | |||
55 | |||
56 | /** |
||
57 | * Get instance. |
||
58 | * |
||
59 | * @since 2.1 |
||
60 | * @access public |
||
61 | * @return Give_API_V2 |
||
62 | */ |
||
63 | View Code Duplication | public static function get_instance() { |
|
72 | |||
73 | |||
74 | /** |
||
75 | * Initialize API |
||
76 | * |
||
77 | * @since 2.1 |
||
78 | * @access private |
||
79 | */ |
||
80 | private function init() { |
||
86 | |||
87 | |||
88 | /** |
||
89 | * Register API routes |
||
90 | * Note: only for internal purpose. |
||
91 | * @todo : prevent cross domain api request |
||
92 | * |
||
93 | * @since 2.1 |
||
94 | * @access private |
||
95 | */ |
||
96 | public function register_routes() { |
||
112 | |||
113 | /** |
||
114 | * Add api localize data |
||
115 | * |
||
116 | * @since 2.1 |
||
117 | * @access public |
||
118 | */ |
||
119 | public function localize_script() { |
||
131 | |||
132 | /** |
||
133 | * Rest fetch form data callback |
||
134 | * |
||
135 | * @param WP_REST_Request $request |
||
136 | * |
||
137 | * @access public |
||
138 | * @return array|mixed|object |
||
139 | */ |
||
140 | public function get_forms_data( $request ) { |
||
150 | |||
151 | /** |
||
152 | * Rest fetch form data callback |
||
153 | * |
||
154 | * @param WP_REST_Request $request |
||
155 | * |
||
156 | * @access public |
||
157 | * @return array|mixed|object |
||
158 | */ |
||
159 | public function get_donation_grid( $request ) { |
||
164 | |||
165 | /** |
||
166 | * Rest fetch form data callback |
||
167 | * |
||
168 | * @param WP_REST_Request $request |
||
169 | * |
||
170 | * @access public |
||
171 | * @return array|mixed|object |
||
172 | */ |
||
173 | public function get_donor_wall( $request ) { |
||
178 | |||
179 | /** |
||
180 | * Get api reset url |
||
181 | * |
||
182 | * @since 2.1 |
||
183 | * @access public |
||
184 | * |
||
185 | * @param int $blog_id Optional. Blog ID. Default of null returns URL for current blog. |
||
186 | * @param string $path Optional. REST route. Default '/'. |
||
187 | * @param string $scheme Optional. Sanitization scheme. Default 'rest'. |
||
188 | * |
||
189 | * @return string Full URL to the endpoint. |
||
190 | */ |
||
191 | public static function get_rest_api( $blog_id = null, $path = '/', $scheme = 'rest' ) { |
||
194 | } |
||
195 | |||
197 |