OrangePaymentSlipTest - Code Metrics - Inspection of "Remove fragile tests" - ravage84/SwissPaymentSlip - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — issue-35 ( 936ba0...bbcdcc )

by Marc

created 2017-08-07 17:46 UTC

OrangePaymentSlipTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	422
Duplicated Lines	34.6 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	20
c	2
b	0
f	0
lcom	1
cbo	3
dl	146
loc	422
rs	10

20 Methods

Rating	Name	Duplication	Size	Complexity
B	setUp()	0	33	1
A	testGetPaymentSlipDataIsInstanceOf()	0	7	1
A	testSlipBackgroundDefaultValues()	0	4	1
A	testReferenceNumberLeftAttrDefaultValues()	14	14	1
A	testReferenceNumberRightAttrDefaultValues()	14	14	1
A	testCodeLineAttrDefaultValues()	15	15	1
A	testSetReferenceNumberLeftAttr()	0	6	1
A	testSetReferenceNumberRightAttr()	0	6	1
A	testSetCodeLineAttr()	0	6	1
A	testSetDisplayReferenceNr()	18	18	1
A	testSetDisplayReferenceNrInvalidParameter()	0	4	1
B	testSetDisplayCodeLine()	0	24	1
A	testSetDisplayCodeLineInvalidParameter()	0	4	1
A	testSetReferenceNrFormatted()	14	14	1
A	testSetReferenceNrFormattedInvalidParameter()	0	4	1
A	testSetReferenceNrFillZeros()	14	14	1
A	testSetReferenceNrFillZerosInvalidParameter()	0	4	1
B	testGetAllElements()	24	24	1
A	testGetAllElementsNoElementsShown()	16	16	1
A	testGetAllElementsDisabledData()	17	17	1

How to fix Duplicated Code

<?php
/**
 * Swiss Payment Slip
 *
 * @license http://www.opensource.org/licenses/mit-license.php MIT License
 * @copyright 2012-2016 Some nice Swiss guys
 * @author Marc Würth [email protected]
 * @author Manuel Reinhard <[email protected]>
 * @author Peter Siska <[email protected]>
 * @link https://github.com/ravage84/SwissPaymentSlip/
 */

namespace SwissPaymentSlip\SwissPaymentSlip\Tests;

use SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlip;
use SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlipData;

/**
 * Tests for the OrangePaymentSlip class
 *
 * @coversDefaultClass SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlip
 */
class OrangePaymentSlipTest extends PaymentSlipTestCase
{
    /**
     * The object under test
     *
     * @var OrangePaymentSlip
     */
    protected $paymentSlip;

    /**
     * Setup a slip to test and some default and set attributes to test
     *
     * @return void
     */
    protected function setUp()
    {
        $slipData = new OrangePaymentSlipData();
        $this->paymentSlip = new OrangePaymentSlip($slipData);

        $attributes = array();
        $attributes['PosX'] = 0;
        $attributes['PosY'] = 0;
        $attributes['Width'] = 0;
        $attributes['Height'] = 0;
        $attributes['Background'] = 'transparent';
        $attributes['FontFamily'] = 'Helvetica';
        $attributes['FontSize'] = '10';
        $attributes['FontColor'] = '#000';
        $attributes['LineHeight'] = 4;
        $attributes['TextAlign'] = 'L';

        $this->defaultAttributes = $attributes;

        $attributes = array();
        $attributes['PosX'] = 123;
        $attributes['PosY'] = 456;
        $attributes['Width'] = 987;
        $attributes['Height'] = 654;
        $attributes['Background'] = '#123456';
        $attributes['FontFamily'] = 'Courier';
        $attributes['FontSize'] = '1';
        $attributes['FontColor'] = '#654321';
        $attributes['LineHeight'] = '15';
        $attributes['TextAlign'] = 'C';

        $this->setAttributes = $attributes;
    }

    /**
     * Tests the getPaymentSlipData method
     *
     * @return void
     * @covers ::getPaymentSlipData
     */
    public function testGetPaymentSlipDataIsInstanceOf()
    {
        $this->assertInstanceOf(
            'SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlipData',
            $this->paymentSlip->getPaymentSlipData()
        );
    }

    /**
     * Tests the default background
     *
     * @return void
     * @covers ::setDefaults
     */
    public function testSlipBackgroundDefaultValues()
    {
        $this->assertEquals('ezs_orange.gif', basename($this->paymentSlip->getSlipBackground()));
    }

    /**
     * Tests the default attributes of the left reference number element
     *
     * @return void
     * @covers ::setDefaults
     */
    public function testReferenceNumberLeftAttrDefaultValues()

    {
        $attributes = $this->paymentSlip->getReferenceNumberLeftAttr();

        $expectedAttributes = $this->defaultAttributes;

        $expectedAttributes['PosX'] = 3;
        $expectedAttributes['PosY'] = 60;
        $expectedAttributes['Width'] = 50;
        $expectedAttributes['Height'] = 4;
        $expectedAttributes['FontSize'] = 8;

        $this->assertEquals($expectedAttributes, $attributes);
    }

    /**
     * Tests the default attributes of the right reference number element
     *
     * @return void
     * @covers ::setDefaults
     */
    public function testReferenceNumberRightAttrDefaultValues()

    {
        $attributes = $this->paymentSlip->getReferenceNumberRightAttr();

        $expectedAttributes = $this->defaultAttributes;

        $expectedAttributes['PosX'] = 125;
        $expectedAttributes['PosY'] = 33.5;
        $expectedAttributes['Width'] = 80;
        $expectedAttributes['Height'] = 4;
        $expectedAttributes['TextAlign'] = 'R';

        $this->assertEquals($expectedAttributes, $attributes);
    }

    /**
     * Tests the default attributes of the code line element
     *
     * @return void
     * @covers ::setDefaults
     */
    public function testCodeLineAttrDefaultValues()

    {
        $attributes = $this->paymentSlip->getCodeLineAttr();

        $expectedAttributes = $this->defaultAttributes;

        $expectedAttributes['PosX'] = 64;
        $expectedAttributes['PosY'] = 85;
        $expectedAttributes['Width'] = 140;
        $expectedAttributes['Height'] = 4;
        $expectedAttributes['FontFamily'] = 'OCRB10';
        $expectedAttributes['TextAlign'] = 'R';

        $this->assertEquals($expectedAttributes, $attributes);
    }

    /**
     * Tests the setReferenceNumberLeftAttr method
     *
     * @return void
     * @covers ::setReferenceNumberLeftAttr
     * @covers ::setAttributes
     * @covers ::getReferenceNumberLeftAttr
     */
    public function testSetReferenceNumberLeftAttr()
    {
        $returned = $this->paymentSlip->setReferenceNumberLeftAttr(123, 456, 987, 654, '#123456', 'Courier', '1', '#654321', '15', 'C');
        $this->assertInstanceOf('SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlip', $returned);
        $this->assertEquals($this->setAttributes, $this->paymentSlip->getReferenceNumberLeftAttr());
    }

    /**
     * Tests the setReferenceNumberRightAttr method
     *
     * @return void
     * @covers ::setReferenceNumberRightAttr
     * @covers ::setAttributes
     * @covers ::getReferenceNumberRightAttr
     */
    public function testSetReferenceNumberRightAttr()
    {
        $returned = $this->paymentSlip->setReferenceNumberRightAttr(123, 456, 987, 654, '#123456', 'Courier', '1', '#654321', '15', 'C');
        $this->assertInstanceOf('SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlip', $returned);
        $this->assertEquals($this->setAttributes, $this->paymentSlip->getReferenceNumberRightAttr());
    }

    /**
     * Tests the setCodeLineAttr method
     *
     * @return void
     * @covers ::setCodeLineAttr
     * @covers ::setAttributes
     * @covers ::getCodeLineAttr
     */
    public function testSetCodeLineAttr()
    {
        $returned = $this->paymentSlip->setCodeLineAttr(123, 456, 987, 654, '#123456', 'Courier', '1', '#654321', '15', 'C');
        $this->assertInstanceOf('SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlip', $returned);
        $this->assertEquals($this->setAttributes, $this->paymentSlip->getCodeLineAttr());
    }

    /**
     * Tests the setDisplayReferenceNr method
     *
     * @return void
     * @covers ::setDisplayReferenceNr
     * @covers ::getDisplayReferenceNr
     * @covers ::isBool
     */
    public function testSetDisplayReferenceNr()

    {
        // Test the default value
        $this->assertTrue($this->paymentSlip->getDisplayReferenceNr());

        // Disable the feature, also assert returned instance
        $returned = $this->paymentSlip->setDisplayReferenceNr(false);
        $this->assertInstanceOf('SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlip', $returned);
        $this->assertFalse($this->paymentSlip->getDisplayReferenceNr());

        // Re-enable the feature
        $this->paymentSlip->setDisplayReferenceNr();
        $this->assertTrue($this->paymentSlip->getDisplayReferenceNr());

        // Check if the data is disabled
        $this->paymentSlip->getPaymentSlipData()->setWithReferenceNumber(false);
        $this->assertFalse($this->paymentSlip->getDisplayReferenceNr());
    }

    /**
     * Tests the setDisplayReferenceNr method with an invalid parameter
     *
     * @return void
     * @expectedException \InvalidArgumentException
     * @expectedExceptionMessage $displayReferenceNr is not a boolean.
     * @covers ::setDisplayReferenceNr
     * @covers ::isBool
     */
    public function testSetDisplayReferenceNrInvalidParameter()
    {
        $this->paymentSlip->setDisplayReferenceNr('true');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Tests the setDisplayCodeLine method
     *
     * @return void
     * @covers ::setDisplayCodeLine
     * @covers ::getDisplayCodeLine
     * @covers ::isBool
     */
    public function testSetDisplayCodeLine()
    {
        // Test the default value
        $this->assertTrue($this->paymentSlip->getDisplayCodeLine());

        // Disable feature, also check for returned instance
        $returned = $this->paymentSlip->setDisplayCodeLine(false);
        $this->assertInstanceOf('SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlip', $returned);
        $this->assertFalse($this->paymentSlip->getDisplayCodeLine());

        // Re-enable the feature
        $this->paymentSlip->setDisplayCodeLine();
        $this->assertTrue($this->paymentSlip->getDisplayCodeLine());

        // Check if the data is disabled
        $this->paymentSlip->getPaymentSlipData()->setWithAccountNumber(true);
        $this->paymentSlip->getPaymentSlipData()->setWithReferenceNumber(false);
        $this->assertFalse($this->paymentSlip->getDisplayCodeLine());

        // Check if the data is disabled
        $this->paymentSlip->getPaymentSlipData()->setWithAccountNumber(false);
        $this->paymentSlip->getPaymentSlipData()->setWithReferenceNumber(true);
        $this->assertFalse($this->paymentSlip->getDisplayCodeLine());
    }

    /**
     * Tests the setDisplayCodeLine method with an invalid parameter
     *
     * @return void
     * @expectedException \InvalidArgumentException
     * @expectedExceptionMessage $displayCodeLine is not a boolean.
     * @covers ::setDisplayCodeLine
     * @covers ::isBool
     */
    public function testSetDisplayCodeLineInvalidParameter()
    {
        $this->paymentSlip->setDisplayCodeLine('true');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Tests the setReferenceNrFormatted method
     *
     * @return void
     * @covers ::setReferenceNrFormatted
     * @covers ::getReferenceNrFormatted
     * @covers ::isBool
     */
    public function testSetReferenceNrFormatted()

    {
        // Test the default value
        $this->assertTrue($this->paymentSlip->getReferenceNrFormatted());

        // Disable feature, also check for returned instance
        $returned = $this->paymentSlip->setReferenceNrFormatted(false);
        $this->assertInstanceOf('SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlip', $returned);
        $this->assertFalse($this->paymentSlip->getReferenceNrFormatted());

        // Re-enable the feature
        $this->paymentSlip->setReferenceNrFormatted(true);
        $this->assertTrue($this->paymentSlip->getReferenceNrFormatted());
    }

    /**
     * Tests the setReferenceNrFormatted method with an invalid parameter
     *
     * @return void
     * @expectedException \InvalidArgumentException
     * @expectedExceptionMessage $referenceNrFormatted is not a boolean.
     * @covers ::setReferenceNrFormatted
     * @covers ::isBool
     */
    public function testSetReferenceNrFormattedInvalidParameter()
    {
        $this->paymentSlip->setReferenceNrFormatted('true');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Tests the setReferenceNrFillZeros method
     *
     * @return void
     * @covers ::setReferenceNrFillZeros
     * @covers ::getReferenceNrFillZeros
     * @covers ::isBool
     */
    public function testSetReferenceNrFillZeros()

    {
        // Test the default value
        $this->assertTrue($this->paymentSlip->getReferenceNrFillZeros());

        // Disable feature, also check for returned instance
        $returned = $this->paymentSlip->setReferenceNrFillZeros(false);
        $this->assertInstanceOf('SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlip', $returned);
        $this->assertFalse($this->paymentSlip->getReferenceNrFillZeros());

        // Re-enable the feature
        $this->paymentSlip->setReferenceNrFillZeros(true);
        $this->assertTrue($this->paymentSlip->getReferenceNrFillZeros());
    }

    /**
     * Tests the setReferenceNrFillZeros method with an invalid parameter
     *
     * @return void
     * @expectedException \InvalidArgumentException
     * @expectedExceptionMessage $referenceNrFillZeros is not a boolean.
     * @covers ::setReferenceNrFillZeros
     * @covers ::isBool
     */
    public function testSetReferenceNrFillZerosInvalidParameter()
    {
        $this->paymentSlip->setReferenceNrFillZeros('true');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Tests the getAllElements method
     *
     * @return void
     * @covers ::getAllElements
     */
    public function testGetAllElements()

    {
        $elements = $this->paymentSlip->getAllElements();

        $expectedElements = array(
            'bankLeft',
            'bankRight',
            'recipientLeft',
            'recipientRight',
            'accountLeft',
            'accountRight',
            'amountFrancsLeft',
            'amountFrancsRight',
            'amountCentsLeft',
            'amountCentsRight',
            'referenceNumberLeft',
            'referenceNumberRight',
            'payerLeft',
            'payerRight',
            'codeLine'
        );

        $this->assertElementsArray($expectedElements, $elements);
    }

    /**
     * Tests the getAllElements method when no elements are shown
     *
     * @return void
     * @covers ::getAllElements
     */
    public function testGetAllElementsNoElementsShown()

    {
        $this->paymentSlip->setDisplayAccount(false);
        $this->paymentSlip->setDisplayAmount(false);
        $this->paymentSlip->setDisplayBank(false);
        $this->paymentSlip->setDisplayPayer(false);
        $this->paymentSlip->setDisplayRecipient(false);
        $this->paymentSlip->setDisplayCodeLine(false);
        $this->paymentSlip->setDisplayReferenceNr(false);

        $elements = $this->paymentSlip->getAllElements();

        $expectedElements = array();

        $this->assertElementsArray($expectedElements, $elements);
    }

    /**
     * Tests the getAllElements method when all data is disabled
     *
     * @return void
     * @covers ::getAllElements
     */
    public function testGetAllElementsDisabledData()

    {
        $paymentSlipData = $this->paymentSlip->getPaymentSlipData();
        $paymentSlipData->setWithAccountNumber(false);
        $paymentSlipData->setWithAmount(false);
        $paymentSlipData->setWithBank(false);
        $paymentSlipData->setWithPayer(false);
        $paymentSlipData->setWithRecipient(false);
        $paymentSlipData->setWithReferenceNumber(false);
        $paymentSlipData->setWithBankingCustomerId(false);

        $elements = $this->paymentSlip->getAllElements();

        $expectedElements = array();

        $this->assertElementsArray($expectedElements, $elements);
    }
}


1			<?php
2			/**
3			* Swiss Payment Slip
4			*
5			* @license http://www.opensource.org/licenses/mit-license.php MIT License
6			* @copyright 2012-2016 Some nice Swiss guys
7			* @author Marc Würth [email protected]
8			* @author Manuel Reinhard <[email protected]>
9			* @author Peter Siska <[email protected]>
10			* @link https://github.com/ravage84/SwissPaymentSlip/
11			*/
12
13			namespace SwissPaymentSlip\SwissPaymentSlip\Tests;
14
15			use SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlip;
16			use SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlipData;
17
18			/**
19			* Tests for the OrangePaymentSlip class
20			*
21			* @coversDefaultClass SwissPaymentSlip\SwissPaymentSlip\OrangePaymentSlip
22			*/
23			class OrangePaymentSlipTest extends PaymentSlipTestCase
24			{
25			/**
26			* The object under test
27			*
28			* @var OrangePaymentSlip
29			*/
30			protected $paymentSlip;
31
32			/**
33			* Setup a slip to test and some default and set attributes to test
34			*
35			* @return void
36			*/
37			protected function setUp()
38			{
39			$slipData = new OrangePaymentSlipData();
40			$this->paymentSlip = new OrangePaymentSlip($slipData);

ravage84 / SwissPaymentSlip

Push — issue-35 ( 936ba0...bbcdcc )

OrangePaymentSlipTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

20 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like